NetBSD Problem Report #18534

Received: (qmail 3662 invoked by uid 605); 5 Oct 2002 00:53:38 -0000
Message-Id: <15731-1033779169@rainier.reedmedia.net>
Date: Fri, 04 Oct 2002 17:52:49 -0700
From: reed@reedmedia.net
Sender: gnats-bugs-owner@netbsd.org
Reply-To: reed@reedmedia.net
To: gnats-bugs@gnats.netbsd.org
Subject: check for negative values in setitimer(2)?
X-Send-Pr-Version: 3.95

>Number:         18534
>Category:       security
>Synopsis:       check for negative argumentsvalues in setitimer(2)?
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    security-officer
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 05 00:54:00 +0000 2002
>Closed-Date:    Fri Apr 02 11:03:11 +0000 2004
>Last-Modified:  Fri Apr 02 11:03:11 +0000 2004
>Originator:     
>Release:        NetBSD 1.6
>Organization:
http://bsd.reedmedia.net/
>Environment:


System: NetBSD rainier.reedmedia.net 1.6 NetBSD 1.6 (JCR-20020927) #3: Sat Sep 28 13:40:20 PDT 2002 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/JCR-20020927 i386
Architecture: i386
Machine: i386
>Description:
I read OpenBSD errata and cvs for sys/kern/kern_time.c that said
that an incorrect argument checking in the setitimer(2) system call
may allow an attacker to write to kernel memory -- and check for
negative values.

I see that which in sys_getitimer() is a (signed) int, so maybe checking
for negative is what is needed. I don't know this code
and I don't know if matters. And I didn't see if it
was checked earlier or elsewhere.
>How-To-Repeat:
I didn't try a negative number in setitimer().
>Fix:
If this is applicable, here is a patch:

--- sys/kern/kern_time.c	Wed Jan 30 16:13:08 2002
+++ /home/users/r/reed/kern_time.c	Fri Oct  4 17:48:39 2002
@@ -578,7 +578,7 @@
 	const struct itimerval *itvp;
 	int s, error;

-	if ((u_int)which > ITIMER_PROF)
+	if ((u_int)which > ITIMER_PROF || which < ITIMER_REAL)
 		return (EINVAL);
 	itvp = SCARG(uap, itv);
 	if (itvp && 
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mrg 
State-Changed-When: Fri Apr 2 11:02:45 UTC 2004 
State-Changed-Why:  
the test already casts "which" to a u_int, so it is quite safe. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.