NetBSD Problem Report #18541
Received: (qmail 10813 invoked by uid 605); 5 Oct 2002 17:06:12 -0000
Message-Id: <20021005170604.16B05A@proven.weird.com>
Date: Sat, 5 Oct 2002 13:06:04 -0400 (EDT)
From: woods@weird.com (Greg A. Woods)
Sender: gnats-bugs-owner@netbsd.org
Reply-To: woods@planix.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org
Subject: parameters to 'env' are not properly quoted in www/mozilla/Makefile.common
X-Send-Pr-Version: 3.95
>Number: 18541
>Category: pkg
>Synopsis: parameters to 'env' are not properly quoted in www/mozilla/Makefile.common
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Oct 05 17:07:00 +0000 2002
>Closed-Date: Tue Oct 22 14:21:03 +0000 2002
>Last-Modified: Tue Oct 22 14:21:03 +0000 2002
>Originator: Greg A. Woods
>Release: pkgsrc-current 2002/10/04
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD 1.5W
Architecture: i386
Machine: i386
>Description:
It's always a good idea to quote the command-line parameters to
'env', and it's absolutely necessary when one of those
parameters might contain a character in $IFS.
>How-To-Repeat:
make the following correction to mk/defs.NetBSD.mk, which while
not strictly necessary, it can help to avoid many weird bugs
caused by strange environment settings, as well as identifying
bugs caused by missing settings necessary for the invoked program
***************
*** 41,52 ****
RM?= /bin/rm
RMDIR?= /bin/rmdir
SED?= /usr/bin/sed
! SETENV?= /usr/bin/env
SH?= /bin/sh
SHLOCK= /usr/bin/shlock
SORT?= /usr/bin/sort
--- 41,57 ----
RM?= /bin/rm
RMDIR?= /bin/rmdir
SED?= /usr/bin/sed
! SETENV?= /usr/bin/env -i
SH?= /bin/sh
SHLOCK= /usr/bin/shlock
SORT?= /usr/bin/sort
now try to install www/mozilla....
>Fix:
There are probably lots of other places such quoting should be
done, but this is the first major error-causing place I've
encountered (I normally only install a few hundred packages at
most).
note the final change is "cosmetic" and helps prevent the user
from thinking the install has hung on a "slow" machine....
Index: Makefile.common
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/www/mozilla/Makefile.common,v
retrieving revision 1.2
diff -c -c -r1.2 Makefile.common
*** Makefile.common 3 Oct 2002 16:08:13 -0000 1.2
--- Makefile.common 5 Oct 2002 16:03:25 -0000
***************
*** 62,81 ****
.endif
PLIST_SUBST+= SO_SUFFIX=${SO_SUFFIX}
! SCRIPTS_ENV+= OBJECT_FMT=${OBJECT_FMT}
! SCRIPTS_ENV+= PLIST_SRC=${PLIST_SRC}
! SCRIPTS_ENV+= SED=${SED}
! SCRIPTS_ENV+= RM=${RM}
! SCRIPTS_ENV+= EGREP=${EGREP}
! SCRIPTS_ENV+= CHOWN=${CHOWN}
! SCRIPTS_ENV+= CHGRP=${CHGRP}
! SCRIPTS_ENV+= CHMOD=${CHMOD}
! SCRIPTS_ENV+= BINOWN=${BINOWN}
! SCRIPTS_ENV+= BINGRP=${BINGRP}
! SCRIPTS_ENV+= BINMODE=${BINMODE}
! SCRIPTS_ENV+= SETENV=${SETENV}
! SCRIPTS_ENV+= MOZILLA=${MOZILLA}
! SCRIPTS_ENV+= SO_SUFFIX=${SO_SUFFIX}
PTHREAD_OPTS+= native optional
--- 62,81 ----
.endif
PLIST_SUBST+= SO_SUFFIX=${SO_SUFFIX}
! SCRIPTS_ENV+= OBJECT_FMT="${OBJECT_FMT}"
! SCRIPTS_ENV+= PLIST_SRC="${PLIST_SRC}"
! SCRIPTS_ENV+= SED="${SED}"
! SCRIPTS_ENV+= RM="${RM}"
! SCRIPTS_ENV+= EGREP="${EGREP}"
! SCRIPTS_ENV+= CHOWN="${CHOWN}"
! SCRIPTS_ENV+= CHGRP="${CHGRP}"
! SCRIPTS_ENV+= CHMOD="${CHMOD}"
! SCRIPTS_ENV+= BINOWN="${BINOWN}"
! SCRIPTS_ENV+= BINGRP="${BINGRP}"
! SCRIPTS_ENV+= BINMODE="${BINMODE}"
! SCRIPTS_ENV+= SETENV="${SETENV}"
! SCRIPTS_ENV+= MOZILLA="${MOZILLA}"
! SCRIPTS_ENV+= SO_SUFFIX="${SO_SUFFIX}"
PTHREAD_OPTS+= native optional
***************
*** 98,104 ****
${ECHO} locale,install,select,en-US >> ${WRKSRC}/dist/bin/chrome/installed-chrome.txt
do-install:
! ${SETENV} ${SCRIPTS_ENV} ${SH} ${FILESDIR}/moz-install
.include "../../mk/pthread.buildlink2.mk"
--- 98,104 ----
${ECHO} locale,install,select,en-US >> ${WRKSRC}/dist/bin/chrome/installed-chrome.txt
do-install:
! ${SETENV} ${SCRIPTS_ENV} ${SH} -x ${FILESDIR}/moz-install
.include "../../mk/pthread.buildlink2.mk"
>Release-Note:
>Audit-Trail:
From: Alan Barrett <apb@cequrux.com>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: Re: pkg/18541: parameters to 'env' are not properly quoted in www/mozilla/Makefile.common
Date: Sun, 6 Oct 2002 15:30:01 +0200
On Sat, 05 Oct 2002, Greg A. Woods wrote:
> ! SCRIPTS_ENV+= OBJECT_FMT="${OBJECT_FMT}"
This is make, not shell. Quote with ${FOO:Q}, not with "${FOO}".
(It makes a difference if the expansion includes any quotation marks,
dollar signs, backslashes, or other metacharacters that are interpreted
inside shell double quotes.)
--apb (Alan Barrett)
From: woods@weird.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org (NetBSD GNATS submissions and followups)
Cc:
Subject: Re: pkg/18541: parameters to 'env' are not properly quoted in www/mozilla/Makefile.common
Date: Sat, 19 Oct 2002 16:35:49 -0400 (EDT)
Alan Barrett suggested using make's :Q to quote things for safe passage
to the shell, and indeed this is a very good idea. Here's the correct
patch:
Index: www/mozilla/Makefile.common
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/www/mozilla/Makefile.common,v
retrieving revision 1.2
diff -c -r1.2 Makefile.common
*** www/mozilla/Makefile.common 3 Oct 2002 16:08:13 -0000 1.2
--- www/mozilla/Makefile.common 19 Oct 2002 20:32:05 -0000
***************
*** 62,81 ****
.endif
PLIST_SUBST+= SO_SUFFIX=${SO_SUFFIX}
! SCRIPTS_ENV+= OBJECT_FMT=${OBJECT_FMT}
! SCRIPTS_ENV+= PLIST_SRC=${PLIST_SRC}
! SCRIPTS_ENV+= SED=${SED}
! SCRIPTS_ENV+= RM=${RM}
! SCRIPTS_ENV+= EGREP=${EGREP}
! SCRIPTS_ENV+= CHOWN=${CHOWN}
! SCRIPTS_ENV+= CHGRP=${CHGRP}
! SCRIPTS_ENV+= CHMOD=${CHMOD}
! SCRIPTS_ENV+= BINOWN=${BINOWN}
! SCRIPTS_ENV+= BINGRP=${BINGRP}
! SCRIPTS_ENV+= BINMODE=${BINMODE}
! SCRIPTS_ENV+= SETENV=${SETENV}
! SCRIPTS_ENV+= MOZILLA=${MOZILLA}
! SCRIPTS_ENV+= SO_SUFFIX=${SO_SUFFIX}
PTHREAD_OPTS+= native optional
--- 62,81 ----
.endif
PLIST_SUBST+= SO_SUFFIX=${SO_SUFFIX}
! SCRIPTS_ENV+= OBJECT_FMT=${OBJECT_FMT:Q}
! SCRIPTS_ENV+= PLIST_SRC=${PLIST_SRC:Q}
! SCRIPTS_ENV+= SED=${SED:Q}
! SCRIPTS_ENV+= RM=${RM:Q}
! SCRIPTS_ENV+= EGREP=${EGREP:Q}
! SCRIPTS_ENV+= CHOWN=${CHOWN:Q}
! SCRIPTS_ENV+= CHGRP=${CHGRP:Q}
! SCRIPTS_ENV+= CHMOD=${CHMOD:Q}
! SCRIPTS_ENV+= BINOWN=${BINOWN:Q}
! SCRIPTS_ENV+= BINGRP=${BINGRP:Q}
! SCRIPTS_ENV+= BINMODE=${BINMODE:Q}
! SCRIPTS_ENV+= SETENV=${SETENV:Q}
! SCRIPTS_ENV+= MOZILLA=${MOZILLA:Q}
! SCRIPTS_ENV+= SO_SUFFIX=${SO_SUFFIX:Q}
PTHREAD_OPTS+= native optional
***************
*** 98,104 ****
${ECHO} locale,install,select,en-US >> ${WRKSRC}/dist/bin/chrome/installed-chrome.txt
do-install:
! ${SETENV} ${SCRIPTS_ENV} ${SH} ${FILESDIR}/moz-install
.include "../../mk/pthread.buildlink2.mk"
--- 98,104 ----
${ECHO} locale,install,select,en-US >> ${WRKSRC}/dist/bin/chrome/installed-chrome.txt
do-install:
! ${SETENV} ${SCRIPTS_ENV} ${SH} -x ${FILESDIR}/moz-install
.include "../../mk/pthread.buildlink2.mk"
--
Greg A. Woods
+1 416 218-0098; <g.a.woods@ieee.org>; <woods@robohack.ca>
Planix, Inc. <woods@planix.com>; VE3TCP; Secrets of the Weird <woods@weird.com>
From: woods@weird.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org (NetBSD GNATS submissions and followups),
netbsd-bugs@NetBSD.ORG (NetBSD Bugs and PR posting List)
Cc:
Subject: Re: pkg/18541: parameters to 'env' are not properly quoted in www/mozilla/Makefile.common
Date: Mon, 21 Oct 2002 02:35:20 -0400 (EDT)
Here's a corrected patch to the previously corrected patch to make
www/mozilla/Makefile.common properly quote macro values used to
initialize envrionment variables with :Q. The one in my previous
followup mail was not tested. This one has been tested with www/phoenix.
Index: www/mozilla/Makefile.common
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/www/mozilla/Makefile.common,v
retrieving revision 1.4
diff -c -r1.4 Makefile.common
*** www/mozilla/Makefile.common 19 Oct 2002 15:20:35 -0000 1.4
--- www/mozilla/Makefile.common 21 Oct 2002 05:55:11 -0000
***************
*** 57,91 ****
# directory
SCRIPTS_ENV+= HOME="${WRKDIR}"
! PLIST_SUBST+= MOZILLA="${MOZILLA}"
! PLIST_SUBST+= MOZILLA_BIN="${MOZILLA_BIN}"
.if ${OBJECT_FMT} == "ELF"
! SO_SUFFIX= "so"
.else
! SO_SUFFIX= "so.1.0"
.endif
PLIST_SUBST+= SO_SUFFIX=${SO_SUFFIX}
! SCRIPTS_ENV+= OBJECT_FMT=${OBJECT_FMT}
! SCRIPTS_ENV+= PLIST_SRC=${PLIST_SRC}
! SCRIPTS_ENV+= SED=${SED}
! SCRIPTS_ENV+= RM=${RM}
! SCRIPTS_ENV+= EGREP=${EGREP}
! SCRIPTS_ENV+= CHOWN=${CHOWN}
! SCRIPTS_ENV+= CHGRP=${CHGRP}
! SCRIPTS_ENV+= CHMOD=${CHMOD}
! SCRIPTS_ENV+= BINOWN=${BINOWN}
! SCRIPTS_ENV+= BINGRP=${BINGRP}
! SCRIPTS_ENV+= BINMODE=${BINMODE}
! SCRIPTS_ENV+= SETENV=${SETENV}
! SCRIPTS_ENV+= MOZILLA=${MOZILLA}
! SCRIPTS_ENV+= MOZILLA_BIN=${MOZILLA_BIN}
! SCRIPTS_ENV+= SO_SUFFIX=${SO_SUFFIX}
PTHREAD_OPTS+= native optional
COPTS?= -O2
! CONFIGURE_ARGS+= --enable-optimize="${COPTS}"
XPTCFILES+= xptcinvoke_asm_sparc64_netbsd.s xptcstubs_asm_sparc64_netbsd.s
XPTCFILES+= xptcinvoke_sparc64_netbsd.cpp xptcstubs_sparc64_netbsd.cpp
--- 57,91 ----
# directory
SCRIPTS_ENV+= HOME="${WRKDIR}"
! PLIST_SUBST+= MOZILLA=${MOZILLA}
! PLIST_SUBST+= MOZILLA_BIN=${MOZILLA_BIN}
.if ${OBJECT_FMT} == "ELF"
! SO_SUFFIX= so
.else
! SO_SUFFIX= so.1.0
.endif
PLIST_SUBST+= SO_SUFFIX=${SO_SUFFIX}
! SCRIPTS_ENV+= OBJECT_FMT=${OBJECT_FMT:Q}
! SCRIPTS_ENV+= PLIST_SRC=${PLIST_SRC:Q}
! SCRIPTS_ENV+= SED=${SED:Q}
! SCRIPTS_ENV+= RM=${RM:Q}
! SCRIPTS_ENV+= EGREP=${EGREP:Q}
! SCRIPTS_ENV+= CHOWN=${CHOWN:Q}
! SCRIPTS_ENV+= CHGRP=${CHGRP:Q}
! SCRIPTS_ENV+= CHMOD=${CHMOD:Q}
! SCRIPTS_ENV+= BINOWN=${BINOWN:Q}
! SCRIPTS_ENV+= BINGRP=${BINGRP:Q}
! SCRIPTS_ENV+= BINMODE=${BINMODE:Q}
! SCRIPTS_ENV+= SETENV=${SETENV:Q}
! SCRIPTS_ENV+= MOZILLA=${MOZILLA:Q}
! SCRIPTS_ENV+= MOZILLA_BIN=${MOZILLA_BIN:Q}
! SCRIPTS_ENV+= SO_SUFFIX=${SO_SUFFIX:Q}
PTHREAD_OPTS+= native optional
COPTS?= -O2
! CONFIGURE_ARGS+= --enable-optimize=${COPTS:Q}
XPTCFILES+= xptcinvoke_asm_sparc64_netbsd.s xptcstubs_asm_sparc64_netbsd.s
XPTCFILES+= xptcinvoke_sparc64_netbsd.cpp xptcstubs_sparc64_netbsd.cpp
***************
*** 103,109 ****
${ECHO} locale,install,select,en-US >> ${WRKSRC}/dist/bin/chrome/installed-chrome.txt
do-install:
! ${SETENV} ${SCRIPTS_ENV} ${SH} ${FILESDIR}/moz-install
.include "../../mk/pthread.buildlink2.mk"
--- 103,109 ----
${ECHO} locale,install,select,en-US >> ${WRKSRC}/dist/bin/chrome/installed-chrome.txt
do-install:
! ${SETENV} ${SCRIPTS_ENV} ${SH} -x ${FILESDIR}/moz-install
.include "../../mk/pthread.buildlink2.mk"
--
Greg A. Woods
+1 416 218-0098; <g.a.woods@ieee.org>; <woods@robohack.ca>
Planix, Inc. <woods@planix.com>; VE3TCP; Secrets of the Weird <woods@weird.com>
From: Shin'ichiro TAYA <taya@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: pr/18541 CVS commit: pkgsrc/www/mozilla
Date: Tue, 22 Oct 2002 17:16:33 +0300 (EEST)
Module Name: pkgsrc
Committed By: taya
Date: Tue Oct 22 14:16:33 UTC 2002
Modified Files:
pkgsrc/www/mozilla: Makefile.common
pkgsrc/www/mozilla/files: moz-install
Log Message:
- Quote macro value used as argument of env
fix PR#18541
- use ${WRKDIR} as temporary dir instead of /tmp
fix PR#18748
To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 pkgsrc/www/mozilla/Makefile.common
cvs rdiff -r1.4 -r1.5 pkgsrc/www/mozilla/files/moz-install
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: taya
State-Changed-When: Tue Oct 22 07:18:38 PDT 2002
State-Changed-Why:
patch merged.
thanks for reporting
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.