NetBSD Problem Report #18687

Received: (qmail 7355 invoked by uid 605); 17 Oct 2002 22:49:58 -0000
Message-Id: <20021017224953.7D8F3A@proven.weird.com>
Date: Thu, 17 Oct 2002 18:49:53 -0400 (EDT)
From: woods@weird.com (Greg A. Woods)
Sender: gnats-bugs-owner@netbsd.org
Reply-To: woods@planix.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org
Subject: update textproc/lout to 3.26 and fix default papersize configuration
X-Send-Pr-Version: 3.95

>Number:         18687
>Category:       pkg
>Synopsis:       update textproc/lout to 3.26 and fix default papersize configuration
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    agc
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 17 22:50:00 +0000 2002
>Closed-Date:    Mon Sep 15 10:54:56 +0000 2003
>Last-Modified:  Mon Sep 29 17:43:00 +0000 2003
>Originator:     Greg A. Woods
>Release:        pkgsrc-current 2002/10/15
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

	the following changes update textproc/lout to use the new 3.26
	release and also add a minor new feature to automatically and
	correctly set the default papersize according to local
	configuration settings.

>How-To-Repeat:

>Fix:

cvs diff: Diffing textproc/lout
Index: textproc/lout/DESCR
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/textproc/lout/DESCR,v
retrieving revision 1.1
diff -c -r1.1 DESCR
*** textproc/lout/DESCR	31 Oct 2001 22:57:24 -0000	1.1
--- textproc/lout/DESCR	19 Apr 2002 01:27:31 -0000
***************
*** 1,7 ****
  THE LOUT DOCUMENT FORMATTING SYSTEM

  Lout is a document formatting system similar in style to LaTeX.  It
! offers a very full range of features, including PostScript, PDF, and
  plain text output, optimal paragraph and page breaking, automatic
  hyphenation, PostScript EPS file inclusion and generation, equation
  formatting, tables, diagrams, rotation and scaling, sorted indexes,
--- 1,7 ----
  THE LOUT DOCUMENT FORMATTING SYSTEM

  Lout is a document formatting system similar in style to LaTeX.  It
! offers a very full range of features, including PostScript, and
  plain text output, optimal paragraph and page breaking, automatic
  hyphenation, PostScript EPS file inclusion and generation, equation
  formatting, tables, diagrams, rotation and scaling, sorted indexes,
Index: textproc/lout/Makefile
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/textproc/lout/Makefile,v
retrieving revision 1.5
diff -c -r1.5 Makefile
*** textproc/lout/Makefile	17 Feb 2001 17:37:33 -0000	1.5
--- textproc/lout/Makefile	16 Oct 2002 19:27:00 -0000
***************
*** 1,16 ****
  # $NetBSD: Makefile,v 1.5 2001/02/17 17:37:33 wiz Exp $
  #

! DISTNAME=	lout-3.21
  CATEGORIES=	textproc
! MASTER_SITES=	ftp://ftp.cs.usyd.edu.au/jeff/lout/

  MAINTAINER=	tsarna@netbsd.org
  HOMEPAGE=	http://snark.niif.spb.su/~uwe/lout/lout.html
! COMMENT=	Basser Lout, a TeX/troff-like formatter with PostScript/PDF output

  PLIST_SRC=      ${WRKDIR}/.PLIST_SRC
  INSTALL_TARGET=	allinstall

  do-configure:
  	${MV} ${WRKSRC}/makefile ${WRKSRC}/makefile.in
--- 1,26 ----
  # $NetBSD: Makefile,v 1.5 2001/02/17 17:37:33 wiz Exp $
  #

! DISTNAME=	lout-3.26
  CATEGORIES=	textproc
! MASTER_SITES=	ftp://ftp.it.usyd.edu.au/jeff/lout/

  MAINTAINER=	tsarna@netbsd.org
+ # XXX this page is sadly somewhat out-dated....
  HOMEPAGE=	http://snark.niif.spb.su/~uwe/lout/lout.html
! COMMENT=	The Lout Document Formatting System

  PLIST_SRC=      ${WRKDIR}/.PLIST_SRC
  INSTALL_TARGET=	allinstall
+ 
+ .include "../../mk/bsd.prefs.mk"
+ 
+ # XXX unfortunately this isn't in <bsd.prefs.mk>, but only in <bsd.pkg.mk>
+ PATCHDIR=	${.CURDIR}/patches
+ 
+ .if exists(${PATCHDIR}/patch-optional-${PAPERSIZE}-papersize)
+ OPTIONAL_PATCHFILES+=	${PATCHDIR}/patch-optional-${PAPERSIZE}-papersize
+ .endif

  do-configure:
  	${MV} ${WRKSRC}/makefile ${WRKSRC}/makefile.in
Index: textproc/lout/distinfo
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/textproc/lout/distinfo,v
retrieving revision 1.2
diff -c -r1.2 distinfo
*** textproc/lout/distinfo	20 Apr 2001 15:05:01 -0000	1.2
--- textproc/lout/distinfo	17 Oct 2002 22:18:51 -0000
***************
*** 1,5 ****
  $NetBSD: distinfo,v 1.2 2001/04/20 15:05:01 skrll Exp $

! SHA1 (lout-3.21.tar.gz) = f6b6599d7a0913c169465e7b1760b64d5d82170e
! Size (lout-3.21.tar.gz) = 1793297 bytes
! SHA1 (patch-aa) = cbd26d1a2a87af5a60ba53de294a40cbb16ae786
--- 1,6 ----
  $NetBSD: distinfo,v 1.2 2001/04/20 15:05:01 skrll Exp $

! SHA1 (lout-3.26.tar.gz) = f32c15a538a0b46b85ccaa1a9716c4c3b87dcd75
! Size (lout-3.26.tar.gz) = 1881323 bytes
! SHA1 (patch-aa) = 3806c7e0dbeb653f0c337721393fcdb35dc8019f
! SHA1 (patch-optional-Letter-papersize) = a7f6f36450db7b45a7b59dc94141b0b8f8522d64
cvs diff: Diffing textproc/lout/patches
Index: textproc/lout/patches/patch-aa
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/textproc/lout/patches/patch-aa,v
retrieving revision 1.3
diff -c -r1.3 patch-aa
*** textproc/lout/patches/patch-aa	16 Jun 2000 02:13:24 -0000	1.3
--- textproc/lout/patches/patch-aa	17 Oct 2002 22:18:49 -0000
***************
*** 1,36 ****
  $NetBSD: patch-aa,v 1.3 2000/06/16 02:13:24 itojun Exp $

! --- makefile.orig	Wed May 10 19:32:45 2000
! +++ makefile	Fri Jun 16 10:41:38 2000
! @@ -255,8 +255,8 @@
   USESTAT = 1
  -SAFEDFT = 0
  +SAFEDFT = 1

! -BINDIR	= /export/home/6monthspace/jeff/bin
! -LIBDIR	= /export/home/6monthspace/jeff/lout.lib
! -DOCDIR	= /export/home/6monthspace/jeff/lout.doc
! -MANDIR	= /export/home/6monthspace/jeff/lout.man
  +BINDIR	= @PREFIX@/bin
  +LIBDIR	= @PREFIX@/share/lout
  +DOCDIR	= @PREFIX@/share/doc/lout
  +MANDIR	= @PREFIX@/man/man1

! @@ -278,4 +278,4 @@

  -PDF_COMPRESSION	= 0
  -ZLIB		=
  +PDF_COMPRESSION	= 1
  +ZLIB		= -lz
   ZLIBPATH	=
! @@ -307,3 +307,3 @@
!  	  -DASSERT_ON=1 $(COPTS)				\
! -	  -DDEBUG_ON=1  -g					\
! +	  -DDEBUG_ON=1  -g -O2					\
!  	  -DPDF_COMPRESSION=$(PDF_COMPRESSION)			\
! @@ -317,2 +317,5 @@
!  	  z41.o z42.o z43.o z44.o z45.o z46.o z47.o z48.o
  +
  +all: lout prg2lout
  +allinstall: install installman installdoc

--- 1,49 ----
  $NetBSD: patch-aa,v 1.3 2000/06/16 02:13:24 itojun Exp $

! --- makefile.orig	Sun Dec 23 23:44:25 2001
! +++ makefile	Thu Apr 18 21:12:49 2002
! @@ -268,7 +268,7 @@
!  DBFIX   = 0
!  
   USESTAT = 1
  -SAFEDFT = 0
  +SAFEDFT = 1

!  # DEBUGGING = 0
!  # TRACING =
! @@ -276,10 +276,10 @@
!  DEBUGGING = 1
!  TRACING = -g
!  
! -BINDIR	= /home/jeff/bin
! -LIBDIR	= /home/jeff/lout.lib
! -DOCDIR	= /home/jeff/lout.doc
! -MANDIR	= /home/jeff/lout.man
  +BINDIR	= @PREFIX@/bin
  +LIBDIR	= @PREFIX@/share/lout
  +DOCDIR	= @PREFIX@/share/doc/lout
  +MANDIR	= @PREFIX@/man/man1

!  LIBFONT = font
!  LIBMAPS = maps
! @@ -297,8 +297,8 @@
!  
!  COLLATE	= 1

  -PDF_COMPRESSION	= 0
  -ZLIB		=
  +PDF_COMPRESSION	= 1
  +ZLIB		= -lz
   ZLIBPATH	=
!  
!  CC	= gcc
! @@ -338,6 +338,9 @@
!  	  z33.o z34.o z35.o z36.o z37.o z38.o z39.o z40.o	\
!  	  z41.o z42.o z43.o z44.o z45.o z46.o z47.o z48.o	\
!  	  z49.o z50.o z51.o
  +
  +all: lout prg2lout
  +allinstall: install installman installdoc

+  lout:	$(OBJS)
+  	$(CC) -o lout $(OBJS) $(ZLIB) -lm
Index: textproc/lout/patches/patch-optional-Letter-papersize
===================================================================
RCS file: textproc/lout/patches/patch-optional-Letter-papersize
diff -N textproc/lout/patches/patch-optional-Letter-papersize
*** /dev/null	1 Jan 1970 00:00:00 -0000
--- textproc/lout/patches/patch-optional-Letter-papersize	19 Apr 2002 01:17:34 -0000
***************
*** 0 ****
--- 1,13 ----
+ #ident "@(#)$NetBSD$"
+ 
+ --- include/dsf.orig	Thu Apr 18 21:15:30 2002
+ +++ include/dsf	Thu Apr 18 21:16:49 2002
+ @@ -56,7 +56,7 @@
+  
+  
+  def @DocumentSetup
+ -    named @PageType		{ A4    @OrIfPlain Other} # page type (width, height)
+ +    named @PageType		{ Letter @OrIfPlain Other} # page type (width, height)
+      named @PageWidth		{ 80s			} # page width if type Other
+      named @PageHeight		{ 66f			} # page height if type Other
+      named @PageOrientation	{ Portrait		} # Portrait, Landscape, etc.
>Release-Note:
>Audit-Trail:

From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/18687 CVS commit: pkgsrc/textproc/lout
Date: Mon, 15 Sep 2003 09:51:40 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Sep 15 09:51:40 UTC 2003

 Modified Files:
 	pkgsrc/textproc/lout: DESCR Makefile distinfo
 	pkgsrc/textproc/lout/patches: patch-aa

 Log Message:
 Update from version 3.21 to 3.26 of lout, the first part of PR 18687
 from Greg Woods.  (The second part of that PR is not the correct way
 to set papersize in pkgsrc). Main change is that the PDF is no longer
 maintained, a more complete list of changes follows:

 Changes and new features introduced in Version 3.22 [3 June 2000]
     Bug fixes
     More setup file options for controlling the appearance of reports
     Makefile now explicitly explains how to compile with debugging on/off
     Added quotesinglebase, quotedblbase, ellipsis to LtLatin2.LCM file
     Object-oriented back end (of interest to implementors only)
     Chapters without page breaks option (see @ChapterStartPages, User's Guide)
     Font includes all in page setups now (of interest to implementors only)

 Changes and new features introduced in Version 3.23 [24 June 2000]
     Bug fixes, including Uwe's fix of the nasty bug reported by Matej Cepl,
       and my fix of a table running headers bug reported by Matthew Neumann.
     Cross links (see User's Guide, Cross References and Links section)
     New symbols for expert users: @LinkSource and @LinkDest
     @Python symbol for typesetting Python programs using prg2lout.

 Changes and new features introduced in Version 3.24 [8 October 2000]
     Bug fixes, including a new and better fix for table running headers bugs

 Changes and new features introduced in Version 3.25 [December 2001]
     Bug fixes
     Finnish additions
     Croatian, Slovakian, Upper Sorbian
     Outdent is now settable e.g. { setoutdent 0.3f } @Break object
     @InitialOutdent options for initializing outdent value
     Updated barcodes package to work with recent Lout versions (@FontDef)
     "downifneeded @Scale" like "{} @Scale" but will only scale down, not up
     @F symbol yields a settable font, no longer hardwired to Courier
     @TitleOf symbol e.g. "@TitleOf azaleas" similar to "@NumberOf azaleas"
     @IndexText option to @Book etc., allows text just below Index title
     References may be printed in order of first citation
     New @Diag link types: @HVHLine, @HVHCurve, @VHVLine, @VHVCurve
     "baselinemark @Font" option (mark along baseline rather than half x height)
     @IncludeGraphicRepeated symbol: less output when EPS included repeatedly
     Arbitrary colours in @Colour, @Tbl, @Diag, and @Graph, done consistently
     Size of small caps can be set now e.g. "{ setsmallcaps 0.8 } @Font ..."
     Got rid of boxes around links when PostScript converted to PDF
     Revised end of sentence handling for some languages
     Symbols for embedding clickable URLs into PostScript output

     I've decided not to maintain the PDF back end, but I will try to ensure
     that Lout's PostScript output works with PostScript-to-PDF converters.

 Changes and new features introduced in Version 3.26 [October 2002]
     Fixed bug causing crash when breaking certain list items across pages
     Merged index entries completely reimplemented
     @DropTagItem (@DTI) now prevents page break after drop tag


 To generate a diff of this commit:
 cvs rdiff -r1.1 -r1.2 pkgsrc/textproc/lout/DESCR
 cvs rdiff -r1.7 -r1.8 pkgsrc/textproc/lout/Makefile
 cvs rdiff -r1.2 -r1.3 pkgsrc/textproc/lout/distinfo
 cvs rdiff -r1.3 -r1.4 pkgsrc/textproc/lout/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/18687 CVS commit: pkgsrc/doc
Date: Mon, 15 Sep 2003 09:52:39 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Sep 15 09:52:39 UTC 2003

 Modified Files:
 	pkgsrc/doc: CHANGES

 Log Message:
 Update from version 3.21 to 3.26 of lout, the first part of PR 18687
 from Greg Woods.  (The second part of that PR is not the correct way
 to set papersize in pkgsrc). Main change is that the PDF is no longer
 maintained, a more complete list of changes follows:

 Changes and new features introduced in Version 3.22 [3 June 2000]
     Bug fixes
     More setup file options for controlling the appearance of reports
     Makefile now explicitly explains how to compile with debugging on/off
     Added quotesinglebase, quotedblbase, ellipsis to LtLatin2.LCM file
     Object-oriented back end (of interest to implementors only)
     Chapters without page breaks option (see @ChapterStartPages, User's Guide)
     Font includes all in page setups now (of interest to implementors only)

 Changes and new features introduced in Version 3.23 [24 June 2000]
     Bug fixes, including Uwe's fix of the nasty bug reported by Matej Cepl,
       and my fix of a table running headers bug reported by Matthew Neumann.
     Cross links (see User's Guide, Cross References and Links section)
     New symbols for expert users: @LinkSource and @LinkDest
     @Python symbol for typesetting Python programs using prg2lout.

 Changes and new features introduced in Version 3.24 [8 October 2000]
     Bug fixes, including a new and better fix for table running headers bugs

 Changes and new features introduced in Version 3.25 [December 2001]
     Bug fixes
     Finnish additions
     Croatian, Slovakian, Upper Sorbian
     Outdent is now settable e.g. { setoutdent 0.3f } @Break object
     @InitialOutdent options for initializing outdent value
     Updated barcodes package to work with recent Lout versions (@FontDef)
     "downifneeded @Scale" like "{} @Scale" but will only scale down, not up
     @F symbol yields a settable font, no longer hardwired to Courier
     @TitleOf symbol e.g. "@TitleOf azaleas" similar to "@NumberOf azaleas"
     @IndexText option to @Book etc., allows text just below Index title
     References may be printed in order of first citation
     New @Diag link types: @HVHLine, @HVHCurve, @VHVLine, @VHVCurve
     "baselinemark @Font" option (mark along baseline rather than half x height)
     @IncludeGraphicRepeated symbol: less output when EPS included repeatedly
     Arbitrary colours in @Colour, @Tbl, @Diag, and @Graph, done consistently
     Size of small caps can be set now e.g. "{ setsmallcaps 0.8 } @Font ..."
     Got rid of boxes around links when PostScript converted to PDF
     Revised end of sentence handling for some languages
     Symbols for embedding clickable URLs into PostScript output

     I've decided not to maintain the PDF back end, but I will try to ensure
     that Lout's PostScript output works with PostScript-to-PDF converters.

 Changes and new features introduced in Version 3.26 [October 2002]
     Fixed bug causing crash when breaking certain list items across pages
     Merged index entries completely reimplemented
     @DropTagItem (@DTI) now prevents page break after drop tag


 To generate a diff of this commit:
 cvs rdiff -r1.3381 -r1.3382 pkgsrc/doc/CHANGES

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/18687 CVS commit: pkgsrc/print/papersize
Date: Mon, 15 Sep 2003 10:51:44 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Sep 15 10:51:41 UTC 2003

 Modified Files:
 	pkgsrc/print/papersize: Makefile
 	pkgsrc/print/papersize/files: getpapersize setpapersize

 Log Message:
 Add lout to the packages which can have their papersize set or queried
 by setpapersize/getpapersize.

 Addresses the second part of PR 18687 properly.


 To generate a diff of this commit:
 cvs rdiff -r1.15 -r1.16 pkgsrc/print/papersize/Makefile
 cvs rdiff -r1.8 -r1.9 pkgsrc/print/papersize/files/getpapersize
 cvs rdiff -r1.9 -r1.10 pkgsrc/print/papersize/files/setpapersize

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: agc 
State-Changed-When: Mon Sep 15 10:53:19 UTC 2003 
State-Changed-Why:  
agc updated the package to version 3.26 - thanks for the nudge. 

In pkgsrc, we use getpapersize/setpapersize to query and set the default paper  
size, so I've added lout to the packages which use that utility. 


Responsible-Changed-From-To: pkg-manager->agc 
Responsible-Changed-By: agc 
Responsible-Changed-When: Mon Sep 15 10:53:19 UTC 2003 
Responsible-Changed-Why:  
agc took responsibility for this one. 

From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/18687 CVS commit: pkgsrc/doc
Date: Mon, 15 Sep 2003 10:53:11 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Sep 15 10:53:08 UTC 2003

 Modified Files:
 	pkgsrc/doc: CHANGES

 Log Message:
 Add lout to the packages which can have their papersize set or queried
 by setpapersize/getpapersize.

 Addresses the second part of PR 18687 properly.


 To generate a diff of this commit:
 cvs rdiff -r1.3382 -r1.3383 pkgsrc/doc/CHANGES

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: "Greg A. Woods" <woods@weird.com>
To: gnats-bugs@gnats.netbsd.org (NetBSD GNATS submissions and followups)
Cc: netbsd-bugs@NetBSD.ORG (NetBSD Bugs and PR posting List), agc@netbsd.org,
  pkg-manager@netbsd.org
Subject: Re: pkg/18687: update textproc/lout to 3.26 and fix default papersize configuration
Date: Sun, 28 Sep 2003 17:34:55 -0400 (EDT)

 [ On , September 15, 2003 at 10:54:56 (-0000), agc@netbsd.org wrote: ]
 > Subject: Re: pkg/18687
 >
 > Synopsis: update textproc/lout to 3.26 and fix default papersize configuration
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: agc
 > State-Changed-When: Mon Sep 15 10:53:19 UTC 2003
 > State-Changed-Why: 
 > agc updated the package to version 3.26 - thanks for the nudge.

 Hmmm....  that "nudge" took so damn long to touch anyone that by the
 time you did the update the original package was already up to 3.29.
 Nearly a whole year has passed since I submitted this PR.

 I.e. three whole new releases were missed in that intervening year!

 I thought it was standard policy for official pkgsrc maintainers to
 always check to make sure they were indeed updating to the latest
 release, not just the one that was suggested in some possibly old PR.

 I can supply an updated Makefile and patch/patch-aa file for the current
 3.29 release if you wish, though the differences are quite trivial.


 > In pkgsrc, we use getpapersize/setpapersize to query and set the default paper 
 > size

 That's simply not true.

 mk/bsd.pkg.defaults.mk contains the following definition:

 	PAPERSIZE?=     A4
 	# Default paper size for packages.
 	# Possible: A4, Letter.
 	# Default: A4

 suggesting that the PAPERSIZE macro is in fact the fundamental way that
 the site-wide default papersize is pkgsrc is configured at install time.

 In fact I find no fewer than 48 occurances of PAPERSIZE in the Makefiles
 of 19 different pkgsrc modules in the current pkgsrc from CVS as of
 yesterday (and that's just "Makefile" files, not all "Make*" files :-).


 > so I've added lout to the packages which use that utility.

 That's not the most wise thing to do, is it?  It means making changes
 after install time to a core file from the lout package and thus causing
 problems (albiet minor problems) down the road when the package is
 deleted and/or upgraded, especially for a binary package.  I.e. the file
 that must be modified by setpapersize is _not_ a configuration file.

 I initially suggested in this PR that lout's initial install be patched
 to match the site-wide PAPERSIZE definition in accordance with the way
 print/psutils and the other 18 packages set their default runtime paper
 size at install time.

 They way I've suggested lout be patched at install time is the easiest
 and most elegant way I could find to work with patch.

 I suppose getpapersize could be used during the post-install target to
 patch the necessary file, but I really don't see the point.  However if
 a site maintainer installs print/papersize and then uses setpapersize to
 change the local default but do not also change the definition of
 PAPERSIZE in /etc/mk.conf to match they'll only confuse other packages
 such as print/psutils.

 At the very least I would strongly suggest that PAPERSIZE be honoured
 during the initial install of lout from pkgsrc, even if the setpapersize
 hack is also maintained.

 -- 
 						Greg A. Woods

 +1 416 218-0098                  VE3TCP            RoboHack <woods@robohack.ca>
 Planix, Inc. <woods@planix.com>          Secrets of the Weird <woods@weird.com>

From: Alistair Crooks <agc@wasabisystems.com>
To: NetBSD GNATS submissions and followups <gnats-bugs@gnats.netbsd.org>,
  NetBSD Bugs and PR posting List <netbsd-bugs@NetBSD.ORG>
Cc: pkg-manager@NetBSD.ORG
Subject: Re: pkg/18687: update textproc/lout to 3.26 and fix default papersize configuration
Date: Mon, 29 Sep 2003 14:40:55 +0200

 On Sun, Sep 28, 2003 at 05:34:55PM -0400, Greg A. Woods wrote:
 > [ On , September 15, 2003 at 10:54:56 (-0000), agc@netbsd.org wrote: ]
 > > Subject: Re: pkg/18687
 > >
 > > Synopsis: update textproc/lout to 3.26 and fix default papersize configuration
 > > 
 > > State-Changed-From-To: open->closed
 > > State-Changed-By: agc
 > > State-Changed-When: Mon Sep 15 10:53:19 UTC 2003
 > > State-Changed-Why: 
 > > agc updated the package to version 3.26 - thanks for the nudge.
 > 
 > Hmmm....  that "nudge" took so damn long to touch anyone that by the
 > time you did the update the original package was already up to 3.29.
 > Nearly a whole year has passed since I submitted this PR.

 You're welcome.

 > I.e. three whole new releases were missed in that intervening year!
 > 
 > I thought it was standard policy for official pkgsrc maintainers to
 > always check to make sure they were indeed updating to the latest
 > release, not just the one that was suggested in some possibly old PR.
 > 
 > I can supply an updated Makefile and patch/patch-aa file for the current
 > 3.29 release if you wish, though the differences are quite trivial.
 >
 > > In pkgsrc, we use getpapersize/setpapersize to query and set the default paper 
 > > size
 > 
 > That's simply not true.

 Well, I wrote the papersize package, and added it to pkgsrc; I wasn't
 aware that you had something to do with it, but I'll go back and
 check.

 > mk/bsd.pkg.defaults.mk contains the following definition:
 > 
 > 	PAPERSIZE?=     A4
 > 	# Default paper size for packages.
 > 	# Possible: A4, Letter.
 > 	# Default: A4
 > 
 > suggesting that the PAPERSIZE macro is in fact the fundamental way that
 > the site-wide default papersize is pkgsrc is configured at install time.
 > 
 > In fact I find no fewer than 48 occurances of PAPERSIZE in the Makefiles
 > of 19 different pkgsrc modules in the current pkgsrc from CVS as of
 > yesterday (and that's just "Makefile" files, not all "Make*" files :-).
 > 
 > 
 > > so I've added lout to the packages which use that utility.
 > 
 > That's not the most wise thing to do, is it?  It means making changes
 > after install time to a core file from the lout package and thus causing
 > problems (albiet minor problems) down the road when the package is
 > deleted and/or upgraded, especially for a binary package.  I.e. the file
 > that must be modified by setpapersize is _not_ a configuration file.
 > 
 > I initially suggested in this PR that lout's initial install be patched
 > to match the site-wide PAPERSIZE definition in accordance with the way
 > print/psutils and the other 18 packages set their default runtime paper
 > size at install time.
 > 
 > They way I've suggested lout be patched at install time is the easiest
 > and most elegant way I could find to work with patch.
 > 
 > I suppose getpapersize could be used during the post-install target to
 > patch the necessary file, but I really don't see the point.  However if
 > a site maintainer installs print/papersize and then uses setpapersize to
 > change the local default but do not also change the definition of
 > PAPERSIZE in /etc/mk.conf to match they'll only confuse other packages
 > such as print/psutils.
 > 
 > At the very least I would strongly suggest that PAPERSIZE be honoured
 > during the initial install of lout from pkgsrc, even if the setpapersize
 > hack is also maintained.

 Thanks for your comments, Greg.

 Regards,
 Alistair

From: "Greg A. Woods" <woods@weird.com>
To: Alistair Crooks <agc@wasabisystems.com>
Cc: NetBSD GNATS submissions and followups <gnats-bugs@gnats.netbsd.org>,
  NetBSD Bugs and PR posting List <netbsd-bugs@NetBSD.ORG>,
  pkg-manager@NetBSD.ORG
Subject: Re: pkg/18687: update textproc/lout to 3.26 and fix default papersize configuration
Date: Mon, 29 Sep 2003 13:42:57 -0400 (EDT)

 [ On Monday, September 29, 2003 at 14:40:55 (+0200), Alistair Crooks wrote: ]
 > Subject: Re: pkg/18687: update textproc/lout to 3.26 and fix default papersize configuration
 >
 > > Hmmm....  that "nudge" took so damn long to touch anyone that by the
 > > time you did the update the original package was already up to 3.29.
 > > Nearly a whole year has passed since I submitted this PR.
 > 
 > You're welcome.

 What do I have to say "thanks" for?  I'm already way past you and other
 pkgsrc maintainers (and its users) as I have been using 3.29, via my
 local pkgsrc, pretty much since it came out.  I only offered my changes
 to help some pkgsrc maintainer, yourself for example, or even some other
 pkgsrc user, save some time when they finally got around to updating the
 module so that _others_ could benefit from it.  Given the delay of
 nearly a year and the fact that the result is a package still just as
 stale, or maybe even more-so, as it was when I submitted this PR in the
 first place, I have even less to be thankful for.  Indeed I feel very
 much as though my effort in submitting the PR was totally wasted and
 that all I've done for other NetBSD users is help maintain the
 perception that NetBSD's pkgsrc is forever on the trailing edge.

 You're the one who should be thanking me, at least in some small way,
 not the other way around.  The only thing I've been lame about is not
 updating this PR when I updated my local pkgsrc, though given the way
 these things obviously go I'm far more inclined to wait for someone to
 ask if I've done any more since than I am to waste more of my time if
 it's just going to sit languishing until I update it yet again, maybe
 twice more, before it finally makes it into the official pkgsrc.

 I.e. pkgsrc maintainers such as yourself must remember that you are
 working as a _team_ with those third party developers who supply
 assistance.  You've way over-stepped the line of offering technical
 criticism of my free offerings.  Why should I continue to help you if
 (a) you ignore my help for so long, and then (b) when you finally do
 make use of it you fail to check to see if maybe your own effort isn't
 going to be wasted by creating a new package that's already way out of
 date?  I.e. what's the point here?  Are we not both trying to give
 NetBSD users easy access to the most useful and most up-to-date
 third-party packages available?  I fully realize there's a serious lack
 of available volunteer effort to do the work, but you must realize that
 the same scarcity affects almost all third-party developers as well.

 After all you had only to check to see if there was a newer release of
 lout available, and then think to ask me if maybe I didn't already have
 a newer pkgsrc module available as well.

 (Note that as a maintainer of other third party packages I've taken to
 moving or removing some of my out-of-date releases specifically to
 prevent folks such as yourself from publishing "packages" based on
 out-of-date releases.)

 > Well, I wrote the papersize package, and added it to pkgsrc; I wasn't
 > aware that you had something to do with it, but I'll go back and
 > check.

 Perhaps you should discuss these issues of print/papersize vs. PAPERSIZE
 with those of your compatriots who are still doing things differently
 than you seem to think they should be doing in pkgsrc before you go
 knocking off advice and suggestions coming from a third-party developer
 such as myself.  I.e. don't make me a part of your fight over this
 issue, if that's what it is, with other pkgsrc maintainers.  I made what
 I believe was the best technical choice amongst the options currently
 being offered in pkgsrc for dealing with this kind of problem in the
 environment presented by a package such as lout.

 I'm not saying anything at all about the print/papersize package itself.
 Indeed until you brought it up I was more or less completely ignoring
 it.  I'm simply pointing out that in my environment the existing
 PAPERSIZE mechanism is sufficient and I for one will never install or
 run setpapersize.  I'm also pointing out that I'm obviously not alone in
 finding PAPERSIZE sufficient and worth supporting in lout.  That doesn't
 mean print/papersize bad or useless, or that it shouldn't also support
 lout -- just that I don't need it, especially not when I can use
 PAPERSIZE to choose my site-wide defaults.  If you can convince everyone
 else to give up PAPERSIZE then I'll revisit this issue as well, but in
 the mean time it's the best, available, solution for me and for lout in
 general.

 > Thanks for your comments, Greg.

 If I didn't think you were being sarcastic then I'd say "You're welcome!".

 -- 
 						Greg A. Woods

 +1 416 218-0098                  VE3TCP            RoboHack <woods@robohack.ca>
 Planix, Inc. <woods@planix.com>          Secrets of the Weird <woods@weird.com>
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.