NetBSD Problem Report #18720

Received: (qmail 19462 invoked by uid 605); 19 Oct 2002 19:47:42 -0000
Message-Id: <20021019194738.3065CA@proven.weird.com>
Date: Sat, 19 Oct 2002 15:47:38 -0400 (EDT)
From: woods@weird.com (Greg A. Woods)
Sender: gnats-bugs-owner@netbsd.org
Reply-To: woods@planix.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org
Subject: minor tweaks for lang/ruby-base
X-Send-Pr-Version: 3.95

>Number:         18720
>Category:       pkg
>Synopsis:       minor tweaks for lang/ruby-base
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 19 19:48:00 +0000 2002
>Closed-Date:    Sun Oct 20 00:41:20 +0000 2002
>Last-Modified:  Sun Oct 20 00:41:20 +0000 2002
>Originator:     Greg A. Woods
>Release:        pkgsrc-current 2002/10/18
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD

>Description:

	I don't remember exactly why I needed this fix, but it may have
	something to do with using 'env -i' to catch bugs.  In any case
	it makes a lot of common sense to pass MAKE_ENV to MAKE,
	especially when SETENV is used to call MAKE!  ;-)

	also there is a fix for a small typo in a message string

>How-To-Repeat:

>Fix:

Index: lang/ruby-base/Makefile.common
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/lang/ruby-base/Makefile.common,v
retrieving revision 1.8
diff -c -r1.8 Makefile.common
*** lang/ruby-base/Makefile.common	9 Jun 2002 11:29:53 -0000	1.8
--- lang/ruby-base/Makefile.common	18 Jun 2002 04:29:27 -0000
***************
*** 162,168 ****
  ruby-extconf-build:
  .for d in ${RUBY_EXTCONF_SUBDIRS}
  	@${ECHO_MSG} "===>  Building ${d}"
! 	@cd ${WRKSRC}/${d}; ${SETENV} ${MAKE} ${ALL_TARGET}
  .endfor
  .endif

--- 162,168 ----
  ruby-extconf-build:
  .for d in ${RUBY_EXTCONF_SUBDIRS}
  	@${ECHO_MSG} "===>  Building ${d}"
! 	@cd ${WRKSRC}/${d}; ${SETENV} ${MAKE_ENV} ${MAKE} ${ALL_TARGET}
  .endfor
  .endif

***************
*** 242,248 ****
  		esac ;; \
  	esac; ${ECHO} "no"
  .if ${_RUBY_PROVIDED} == "no"
! IGNORE+=		"This package require ruby ${RUBY_REQD} or later."
  .endif
  .else
  RUBY_REQD?=		${RUBY_VERSION}
--- 242,248 ----
  		esac ;; \
  	esac; ${ECHO} "no"
  .if ${_RUBY_PROVIDED} == "no"
! IGNORE+=		"This package requires ruby ${RUBY_REQD} or later."
  .endif
  .else
  RUBY_REQD?=		${RUBY_VERSION}
>Release-Note:
>Audit-Trail:

From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/18720 CVS commit: pkgsrc/lang/ruby-base
Date: Sun, 20 Oct 2002 03:39:54 +0300 (EEST)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sun Oct 20 00:39:53 UTC 2002

 Modified Files:
 	pkgsrc/lang/ruby-base: Makefile.common

 Log Message:
 Pass MAKE_ENV to MAKE (two places, one of them from PR 18720).
 Fix typo in IGNORE message (also from PR 18720).


 To generate a diff of this commit:
 cvs rdiff -r1.8 -r1.9 pkgsrc/lang/ruby-base/Makefile.common

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: wiz 
State-Changed-When: Sat Oct 19 17:41:07 PDT 2002 
State-Changed-Why:  
Added MAKE_ENV as noted in your PR, and for consistency in a second place. 
Thanks! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.