NetBSD Problem Report #18741

Received: (qmail 14811 invoked by uid 605); 20 Oct 2002 21:04:18 -0000
Message-Id: <200210202104.g9KL4Bs03881@lucifer.inet>
Date: Sun, 20 Oct 2002 23:04:11 +0200 (CEST)
From: pino@dohd.org
Sender: gnats-bugs-owner@netbsd.org
Reply-To: pino@dohd.org
To: gnats-bugs@gnats.netbsd.org
Subject: update audio/mp3blaster 3.1.1 -> 3.1.3
X-Send-Pr-Version: 3.95

>Number:         18741
>Category:       pkg
>Synopsis:       update audio/mp3blaster 3.1.1 -> 3.1.3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jschauma
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 20 21:05:01 +0000 2002
>Closed-Date:    Wed Oct 08 06:23:39 +0000 2003
>Last-Modified:  Wed Oct 08 06:23:39 +0000 2003
>Originator:     Martijn van Buul
>Release:        NetBSD 1.6I
>Organization:

>Environment:


System: NetBSD lucifer.ipv6.stack.nl 1.6I NetBSD 1.6I (LUCIFER) #3: Sat Oct 19 09:57:24 CEST 2002 martijnb@lucifer.ipv6.stack.nl:/usr/src/sys/arch/i386/compile/LUCIFER i386
Architecture: i386
Machine: i386
>Description:
	Update for audio/mp3blaster from version 3.1.1 to 3.1.3

	Previous maintainer, Rui-Xiang Guo <rxg@1111.com.tw> asked me to 
	take over this package.

	Changes since 3.1.1:

	V3.1.3 2002/10/20
	=================
	-Changed RPM .spec file such that all compression methods for man files
	 will be honoured
	-Fixed a bug that could cause the playlist repeat to stop (thanks to
	 Alex Rasmussen for finding the bug)
	-Command line options for nmixer changed, and it's now possible to
	 select a different hardware mixer device.
	-Fixed a bug that caused mp3blaster to quit when the user's homedir
	 could not be determined.

	V3.1.2 2002/09/03
	=================
	-Compiles on gcc-3.* without errors
	-Trailing slash in HTTP URLs is only appended after the hostname, not
	 in URLs that contain a path following the hostname. This means that
	 mp3's can now be played straight from an URL again.
	-For HTTP streams, HTTP/1.1 is used instead of HTTP/1.0 (this, and
	 previous suggestion submitted by Markus Jerger. Thanks!)


>How-To-Repeat:
	.
>Fix:

diff -u -r mp3blaster/Makefile mp3blaster-new/Makefile
--- mp3blaster/Makefile	Tue Sep  3 08:15:56 2002
+++ mp3blaster-new/Makefile	Sun Oct 20 22:18:43 2002
@@ -1,11 +1,11 @@
 # $NetBSD: Makefile,v 1.4 2002/08/01 05:48:05 jlam Exp $

-DISTNAME=	mp3blaster-3.1.1
+DISTNAME=	mp3blaster-3.1.3
 CATEGORIES=	audio
 MASTER_SITES=	ftp://mud.stack.nl/pub/mp3blaster/ \
 		http://mp3blaster.linuxave.net/src/

-MAINTAINER=	rxg@netbsd.org
+MAINTAINER=	pino@dohd.org
 HOMEPAGE=	http://www.stack.nl/~brama/mp3blaster.html
 COMMENT=	MP3 console curses-based player

diff -u -r mp3blaster/PLIST mp3blaster-new/PLIST
--- mp3blaster/PLIST	Mon Mar 18 15:13:50 2002
+++ mp3blaster-new/PLIST	Sun Oct 20 22:33:28 2002
@@ -4,13 +4,14 @@
 bin/nmixer
 man/man1/mp3blaster.1
 man/man1/nmixer.1
-share/mp3blaster/README
-share/mp3blaster/chargen.c
+share/mp3blaster/charmap/README
+share/mp3blaster/charmap/chargen.c
+share/mp3blaster/charmap/koi8-r
+share/mp3blaster/charmap/makefile.charmap
+share/mp3blaster/charmap/maketbl.c
+share/mp3blaster/charmap/win1251
+share/mp3blaster/charmap/win2koi.tbl
 share/mp3blaster/commands.txt
-share/mp3blaster/koi8-r
-share/mp3blaster/makefile
-share/mp3blaster/maketbl.c
 share/mp3blaster/sample.mp3blasterrc
-share/mp3blaster/win1251
-share/mp3blaster/win2koi.tbl
+@dirrm share/mp3blaster/charmap
 @dirrm share/mp3blaster
diff -u -r mp3blaster/distinfo mp3blaster-new/distinfo
--- mp3blaster/distinfo	Mon Mar 18 15:13:51 2002
+++ mp3blaster-new/distinfo	Sun Oct 20 22:48:24 2002
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.1.1.1 2002/02/23 07:43:19 rxg Exp $
+$NetBSD$

-SHA1 (mp3blaster-3.1.1.tar.gz) = 794e87ac78f915bedf72a685080e729bf2f13337
-Size (mp3blaster-3.1.1.tar.gz) = 286621 bytes
-SHA1 (patch-ab) = 02a1245efef23f1807c05aab530bf0ae4502fd5a
-SHA1 (patch-ac) = fb99e0330bbec8c0813eb8a38fe534e090878c43
+SHA1 (mp3blaster-3.1.3.tar.gz) = 516f0b55443c9b7035ef2a82903b369c13a8f001
+Size (mp3blaster-3.1.3.tar.gz) = 273688 bytes
+SHA1 (patch-ab) = 84ff166adf1e467504f90fd933fa3398a16ee843
+SHA1 (patch-ac) = 4e0e4b9debae30db23a246580b487788cad140eb
Only in mp3blaster/patches: CVS
diff -u -r mp3blaster/patches/patch-ab mp3blaster-new/patches/patch-ab
--- mp3blaster/patches/patch-ab	Mon Mar 18 15:13:53 2002
+++ mp3blaster-new/patches/patch-ab	Sun Oct 20 22:28:17 2002
@@ -1,22 +1,14 @@
 $NetBSD$

---- src/Makefile.in.orig	Sun Mar 17 04:00:49 2002
+--- src/Makefile.in.orig	Sun Oct 20 19:05:08 2002
 +++ src/Makefile.in
-@@ -85,8 +85,7 @@
- am__quote = @am__quote@
- install_sh = @install_sh@
+@@ -75,8 +75,7 @@ SID_LIBS = @SID_LIBS@
+ SRCDIRS = @SRCDIRS@
+ VERSION = @VERSION@

 -bin_PROGRAMS = mp3blaster mp3tag splay
 -#bin_PROGRAMS		= mp3blaster mp3tag
-+bin_PROGRAMS = mp3blaster mp3tag
- mp3blaster_SOURCES = fileman.cc \
- 			  main.cc \
- 			  scrollwin.cc \
-@@ -131,7 +130,6 @@
- mkinstalldirs = $(SHELL) $(top_srcdir)/mkinstalldirs
- CONFIG_HEADER = $(top_builddir)/config.h
- CONFIG_CLEAN_FILES =
--bin_PROGRAMS = mp3blaster$(EXEEXT) mp3tag$(EXEEXT) splay$(EXEEXT)
- PROGRAMS = $(bin_PROGRAMS)
++bin_PROGRAMS		= mp3blaster mp3tag
+ mp3blaster_SOURCES = fileman.cc 			  main.cc 			  scrollwin.cc 			  getopt.c 			  getopt1.c 			  fileman.h 			  genretab.h 			  getopt.h 				id3parse.cc 			  id3parse.h 			  mp3blaster.h 			  global.cc 			  global.h 			  config.cc 			  scrollwin.h 			  winitem.cc 			  winitem.h 			  mp3win.cc 			  mp3win.h 			  mp3item.cc 			  mp3item.h 				keybindings.h 				history.cc 				history.h 				getinput.cc 				getinput.h 				interface.cc 				interface.h

- am_mp3blaster_OBJECTS = fileman.$(OBJEXT) main.$(OBJEXT) \
+ splay_SOURCES = splay.cc splay.h splay_common.cc
diff -u -r mp3blaster/patches/patch-ac mp3blaster-new/patches/patch-ac
--- mp3blaster/patches/patch-ac	Mon Mar 18 15:13:53 2002
+++ mp3blaster-new/patches/patch-ac	Sun Oct 20 22:28:16 2002
@@ -1,13 +1,13 @@
 $NetBSD$

---- Makefile.in.orig	Sun Mar 17 04:00:46 2002
+--- Makefile.in.orig	Sun Oct 20 19:05:07 2002
 +++ Makefile.in
-@@ -86,7 +86,7 @@
- install_sh = @install_sh@
+@@ -76,7 +76,7 @@ SRCDIRS = @SRCDIRS@
+ VERSION = @VERSION@

  SUBDIRS = mpegsound nmixer src doc
 -man_MANS = mp3blaster.1 nmixer.1 splay.1
-+man_MANS = mp3blaster.1 nmixer.1
- EXTRA_DIST = CREDITS TODO FAQ id3scripts/id3name.sh mp3blaster.1 nmixer.1 \
- 	winnt/AUTHORS winnt/README.txt winnt/getopt.c winnt/getopt.h \
- 	winnt/id3parse.cpp winnt/id3parse.h winnt/mp3tag.cpp winnt/mp3tag.mak \
++man_MANS = mp3blaster.1 nmixer.1 
+ EXTRA_DIST = CREDITS TODO FAQ mp3blaster.1 nmixer.1 	BUGS splay.1 mp3blaster.list mp3blaster.spec
+ 
+ ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
>Release-Note:
>Audit-Trail:

From: Hubert Feyrer <hubert.feyrer@informatik.fh-regensburg.de>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: Re: pkg/18741
Date: Mon, 21 Oct 2002 06:45:27 +0200 (MEST)

 I've only tried the package after the upgrade, but this seems to have
 problems:
  * mp3blaster hangs with printing "Setting up PTH thread"
  * the "decrease volume" (cursor left) doesn't work in nmixer.
    This does _not_ seem to be a curses problem.


  - Hubert

 -- 
 Want to get a clue on IPv6 but don't know where to start? Try this:
 * Basics -> http://www.onlamp.com/pub/a/onlamp/2001/05/24/ipv6_tutorial.html
 * Setup  -> http://www.onlamp.com/pub/a/onlamp/2001/06/01/ipv6_tutorial.html
 Of course with your #1 IPv6 ready operating system -> http://www.NetBSD.org/


From: Martijn van Buul <pino@dohd.org>
To: Hubert Feyrer <hubert.feyrer@informatik.fh-regensburg.de>
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/18741
Date: Thu, 31 Oct 2002 13:08:04 +0100

 Sorry for this late response. I did not receive your message (nor did it
 pop up on the bugs list), and I only just stumbled across it on the NetBSD
 webpage..

 Please Cc: me !

 Hubert Feyrer wrote:

 > I've only tried the package after the upgrade, but this seems to have
 > problems:
 >  * mp3blaster hangs with printing "Setting up PTH thread"

 Hmm, I cannot reproduce that (on my 1.6J/i386 machine), with pth-1.4.1nb5. The
 default keybindings have some issues with them due to ncurses (especially under
 X!), maybe I should change them. Could you be so kind to redefine the function
 keys (which are the culprit here)? A sample .mp3blasterrc file can be found
 in /usr/pkg/share/mp3blaster. The example given there works perfectly (but
 needs to be un-commented)

 >  * the "decrease volume" (cursor left) doesn't work in nmixer.
 >    This does _not_ seem to be a curses problem.

 Erk, you're right. I hadn't noticed it. Will look into it.

 Kind regards,

 Martijn

 -- 
     Martijn van Buul -  Pino@dohd.org - http://www.stack.nl/~martijnb/
 	 Geek code: G--  - Visit OuterSpace: mud.stack.nl 3333
    Kees J. Bot: The sum of CPU power and user brain power is a constant.
Responsible-Changed-From-To: pkg-manager->jschauma 
Responsible-Changed-By: jschauma 
Responsible-Changed-When: Mon Nov 25 11:10:41 PST 2002 
Responsible-Changed-Why:  

I updated the package -- however, I did not yet fix the problem described 
in this PR, which I believe to be in nmixer.cc, where, if decreasing the 
value the original value is re-initialized.  I'll investigate this further. 


From: Quentin Garnier <netbsd@quatriemek.com>
To: tech-kern@netbsd.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: pkg/18741 : kernel or userland issue with mixers?
Date: Sun, 21 Sep 2003 20:13:02 +0200

 This is a multi-part message in MIME format.

 --Multipart_Sun__21_Sep_2003_20:13:02_+0200_0a804600
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit

 The PR pkg/18741 describes an issue with operation on mixer settings in
 mp3blaster: single-step decrement doesn't seem to do anything.

 The reason for that is quite simple and not specific to mp3blaster (I had
 a report for mplayer, but I haven't checked if it is indeed that same
 issue).

 The mixer application of mp3blaster increments or decrements by 2 percents
 for a single step. This is an issue with AC-97 hardware (and maybe other,
 that should be checked too), since mixer values are stored in 5 bits,
 which means a single step is roughly 3 percents. Thus a single decrement
 in mp3blaster doesn't reach the next value, and nothing happens.

 I'm not sure if such applications should be just patched, because
 finer-grained settings are usable with some other hardware, like good old
 SB16.

 I came up with the attached patch that does the following:

 1. get current values
 2. compare current and new values on 8 bits
 3. if the current and new values differ, but the stripped (5 bits) values
    do not, then adjust the new values

 Also, in the case 2-channel values are provided for a 1-channel control,
 use 'r' value instead of 'l'. Thus l is always the 8 most significant bits
 of the resulting value, and the rest of the hack does the right thing in
 that case.

 That fixes the mixer issue for mp3blaster, and I guess will too for other
 applications with that same issue.

 A check should be made in order to find whether some other audio drivers
 need a similar change.

 So, userland or kernel issue?

 -- 
 Quentin Garnier - cube@cubidou.net
 "Feels like I'm fiddling while Rome is burning down.
 Should I lay my fiddle down and take a rifle from the ground ?"
 Leigh Nash/Sixpence None The Richer, Paralyzed, Divine Discontents, 2002.

 --Multipart_Sun__21_Sep_2003_20:13:02_+0200_0a804600
 Content-Type: text/plain;
  name="ac97.diff"
 Content-Disposition: attachment;
  filename="ac97.diff"
 Content-Transfer-Encoding: 7bit

 Index: ac97.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/ic/ac97.c,v
 retrieving revision 1.47
 diff -u -r1.47 ac97.c
 --- ac97.c	2003/09/11 09:21:29	1.47
 +++ ac97.c	2003/09/21 18:00:59
 @@ -1149,7 +1149,8 @@
  	case AUDIO_MIXER_VALUE:
  	{
  		const struct audio_mixer_value *value = si->info;
 -		u_int16_t  l, r;
 +		u_int16_t  l, r, ol, or;
 +		int deltal, deltar;

  		if ((cp->un.value.num_channels <= 0) ||
  		    (cp->un.value.num_channels > value->num_channels))
 @@ -1173,12 +1174,23 @@
  			r = 255 - r;
  		}

 +		ol = (val >> (8+si->ofs)) & mask;
 +		or = (val >> si->ofs) & mask;
 +
 +		deltal = (ol << (8 - si->bits)) - l;
 +		deltar = (or << (8 - si->bits)) - r;
 +
  		l = l >> (8 - si->bits);
  		r = r >> (8 - si->bits);
 +
 +		if (deltal && ol == l)
 +			l += (deltal > 0) ? (l ? -1 : 0) : (l < mask ? 1 : 0);
 +		if (deltar && or == r)
 +			r += (deltar > 0) ? (r ? -1 : 0) : (r < mask ? 1 : 0);

 -		newval = ((l & mask) << si->ofs);
 +		newval = ((r & mask) << si->ofs);
  		if (value->num_channels == 2) {
 -			newval = (newval << 8) | ((r & mask) << si->ofs);
 +			newval = newval | ((r & mask) << (si->ofs+8));
  			mask |= (mask << 8);
  		}
  		mask = mask << si->ofs;

 --Multipart_Sun__21_Sep_2003_20:13:02_+0200_0a804600--

From: Daniel Carosone <dan@geek.com.au>
To: Quentin Garnier <netbsd@quatriemek.com>
Cc: tech-kern@netbsd.org, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/18741 : kernel or userland issue with mixers?
Date: Mon, 22 Sep 2003 21:27:05 +1000

 On Sun, Sep 21, 2003 at 08:13:02PM +0200, Quentin Garnier wrote:
 > The PR pkg/18741 describes an issue with operation on mixer settings in
 > mp3blaster: single-step decrement doesn't seem to do anything.

 hah. I have seen this with xmms trying to use kbd control with arrow keys.

 --
 Dan.

From: Quentin Garnier <cube@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/18741 CVS commit: src/sys/dev/ic
Date: Sun, 28 Sep 2003 22:24:09 +0000 (UTC)

 Module Name:	src
 Committed By:	cube
 Date:		Sun Sep 28 22:24:09 UTC 2003

 Modified Files:
 	src/sys/dev/ic: ac97.c

 Log Message:
 Change the way of setting a port value so that a change too small to
 fit in the number of bits used for the port still does something.

 This fixes PR pkg/18741 for ac97-based hardware. Other audio drivers
 might need a similar fix.


 To generate a diff of this commit:
 cvs rdiff -r1.48 -r1.49 src/sys/dev/ic/ac97.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: cube 
State-Changed-When: Wed Oct 8 06:13:53 UTC 2003 
State-Changed-Why:  
mp3blaster has been updated, and now builds fine even with gcc3. 
The mixer issue is not a mp3blaster bug, see: 
http://mail-index.netbsd.org/tech-kern/2003/09/21/0002.html 
http://mail-index.netbsd.org/tech-kern/2003/10/07/0029.html 
Thanks for the initial patch! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.