NetBSD Problem Report #18811

Received: (qmail 22704 invoked by uid 605); 26 Oct 2002 12:44:15 -0000
Message-Id: <20021026144407.142e33fb.christianbiere@gmx.de>
Date: Sat, 26 Oct 2002 14:44:07 +0200
From: Christian Biere <christianbiere@gmx.de>
Sender: gnats-bugs-owner@netbsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: Generator: Problem with stat() solved

>Number:         18811
>Category:       pkg
>Synopsis:       Generator: Problem with stat() solved
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    agc
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 26 12:45:00 +0000 2002
>Closed-Date:    Tue Nov 19 20:55:28 +0000 2002
>Last-Modified:  Tue Nov 19 20:56:00 +0000 2002
>Originator:     Christian Biere
>Release:        NetBSD 1.6J
>Organization:

>Environment:

Architecture: i386
Machine: i386

>Description:

patch-ab for pkgsrc/emulators/generator was a workaround for a problem
with stat(). I've found the reason for this problem. Generator is compiled
with -malign-double if a x86 architecture is detected. This produces code
which is not binary compatible with the stat structure (see man stat(2)).
This might also lead to incompatibilities with other structures. I've
totally removed the automatic pentium optimizations from configure and
configure.in. If at all desired such options should be set manually and I
doubt -march=pentium produces the optimum code for actual x86 CPUs.
Note that -malign-double has alread been removed in the CVS repository of
Generator. I suggest replacing the workaround patch-ab with the attached
file.

Christian

>How-To-Repeat:

>Fix:
--Multipart_Sat__26_Oct_2002_14:44:07_+0200_081fea00
Content-Type: text/plain;
 name="patch.udif"
Content-Disposition: attachment;
 filename="patch.udif"
Content-Transfer-Encoding: 7bit

--- configure	2002/10/26 12:11:38	1.1
+++ configure	2002/10/26 12:12:44
@@ -1581,13 +1581,6 @@
 echo "${ECHO_T}Turning on gcc 3 optimisations" >&6
         CFLAGS="$CFLAGS -minline-all-stringops -fno-math-errno"
       fi
-      case $target_cpu in
-        i?86) echo "$as_me:1585: result: Turning on pentium optimisations" >&5
-echo "${ECHO_T}Turning on pentium optimisations" >&6
-              CFLAGS="$CFLAGS -march=pentium -malign-double -malign-loops=5"
-              CFLAGS="$CFLAGS -malign-jumps=5 -malign-functions=5"
-              ;;
-      esac
     else
       { echo "$as_me:1592: WARNING: You did not opt for gcc optimisations!" >&5
 echo "$as_me: WARNING: You did not opt for gcc optimisations!" >&2;}
--- configure.in	2002/10/26 12:11:38	1.1
+++ configure.in	2002/10/26 12:13:15
@@ -123,12 +123,6 @@
         AC_MSG_RESULT(Turning on gcc 3 optimisations)
         CFLAGS="$CFLAGS -minline-all-stringops -fno-math-errno"
       fi
-      case $target_cpu in
-        i?86) AC_MSG_RESULT(Turning on pentium optimisations)
-              CFLAGS="$CFLAGS -march=pentium -malign-double -malign-loops=5"
-              CFLAGS="$CFLAGS -malign-jumps=5 -malign-functions=5"
-              ;;
-      esac
     else
       AC_MSG_WARN(You did not opt for gcc optimisations!)
       optimum=no

--Multipart_Sat__26_Oct_2002_14:44:07_+0200_081fea00--
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: agc 
State-Changed-When: Tue Nov 19 12:54:44 PST 2002 
State-Changed-Why:  
agc applied the fixes provided. Much cleaner - thanks. 


Responsible-Changed-From-To: pkg-manager->agc 
Responsible-Changed-By: agc 
Responsible-Changed-When: Tue Nov 19 12:54:44 PST 2002 
Responsible-Changed-Why:  
agc took responsibility for this one 

From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/18811 CVS commit: pkgsrc/emulators/generator
Date: Tue, 19 Nov 2002 22:54:22 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Tue Nov 19 20:54:21 UTC 2002

 Modified Files:
 	pkgsrc/emulators/generator: distinfo
 Added Files:
 	pkgsrc/emulators/generator/patches: patch-ac patch-ad
 Removed Files:
 	pkgsrc/emulators/generator/patches: patch-ab

 Log Message:
 Fix from Christian Biere in PR 18811 to remove the -malign-double
 configuration parameter which was causing problems with the stat(2)
 structure.


 To generate a diff of this commit:
 cvs rdiff -r1.2 -r1.3 pkgsrc/emulators/generator/distinfo
 cvs rdiff -r1.1 -r0 pkgsrc/emulators/generator/patches/patch-ab
 cvs rdiff -r0 -r1.1 pkgsrc/emulators/generator/patches/patch-ac \
     pkgsrc/emulators/generator/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:
 This is a multi-part message in MIME format.

 --Multipart_Sat__26_Oct_2002_14:44:07_+0200_081fea00
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.