NetBSD Problem Report #18934

Received: (qmail 9504 invoked by uid 605); 4 Nov 2002 23:21:36 -0000
Message-Id: <20021104232132.858C1B@proven.weird.com>
Date: Mon,  4 Nov 2002 18:21:32 -0500 (EST)
From: woods@weird.com (Greg A. Woods)
Sender: gnats-bugs-owner@netbsd.org
Reply-To: woods@planix.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org
Subject: ftpd (among others) complains too loudly about some unimportant errors
X-Send-Pr-Version: 3.95

>Number:         18934
>Category:       bin
>Synopsis:       ftpd (among others) complains too loudly about some unimportant errors
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lukem
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 04 23:22:00 +0000 2002
>Closed-Date:    Sun Sep 04 23:17:37 +0000 2011
>Last-Modified:  Mon Mar 25 04:15:05 +0000 2013
>Originator:     Greg A. Woods
>Release:        netbsd-1-6
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD 1.6
>Description:

	ftpd (among others) complains far too loudly if it fails just
	because the client disconnects before it gets going.

>How-To-Repeat:

	run the simple netsaint/nagios/etc. checks to test your ftp server

>Fix:

	here's an example fix for ftpd:

Index: ftpd.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/basesrc/libexec/ftpd/ftpd.c,v
retrieving revision 1.138.2.1
diff -c -c -r1.138.2.1 ftpd.c
*** ftpd.c	30 Sep 2002 13:07:15 -0000	1.138.2.1
--- ftpd.c	4 Nov 2002 23:08:48 -0000
***************
*** 380,386 ****
  	memset((char *)&his_addr, 0, sizeof(his_addr));
  	addrlen = sizeof(his_addr.si_su);
  	if (getpeername(0, (struct sockaddr *)&his_addr.si_su, &addrlen) < 0) {
! 		syslog(LOG_ERR, "getpeername (%s): %m",argv[0]);
  		exit(1);
  	}
  	his_addr.su_len = addrlen;
--- 380,386 ----
  	memset((char *)&his_addr, 0, sizeof(his_addr));
  	addrlen = sizeof(his_addr.si_su);
  	if (getpeername(0, (struct sockaddr *)&his_addr.si_su, &addrlen) < 0) {
! 		syslog((errno == ENOTCONN) ? LOG_NOTICE : LOG_ERR, "getpeername (%s): %m",argv[0]);
  		exit(1);
  	}
  	his_addr.su_len = addrlen;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: bin-bug-people->lukem
Responsible-Changed-By: lukem@NetBSD.org
Responsible-Changed-When: Sun, 04 Sep 2011 23:17:37 +0000
Responsible-Changed-Why:
I dealt with it


State-Changed-From-To: open->closed
State-Changed-By: lukem@NetBSD.org
State-Changed-When: Sun, 04 Sep 2011 23:17:37 +0000
State-Changed-Why:
Fixed in -current.
Thanks for the patch.


From: "Luke Mewburn" <lukem@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/18934 CVS commit: src/libexec/ftpd
Date: Sun, 4 Sep 2011 23:16:42 +0000

 Module Name:	src
 Committed By:	lukem
 Date:		Sun Sep  4 23:16:42 UTC 2011

 Modified Files:
 	src/libexec/ftpd: ftpd.c

 Log Message:
 Reduce priority of syslog message if getpeername returns ENOTCONN.
 PR bin/18934 by Greg A. Woods (with supplied fix).


 To generate a diff of this commit:
 cvs rdiff -u -r1.195 -r1.196 src/libexec/ftpd/ftpd.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Luke Mewburn" <lukem@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/18934 CVS commit: src/libexec/ftpd
Date: Thu, 21 Mar 2013 00:17:26 +0000

 Module Name:	src
 Committed By:	lukem
 Date:		Thu Mar 21 00:17:26 UTC 2013

 Modified Files:
 	src/libexec/ftpd: version.h

 Log Message:
 Update version to 20110904 for the user-visible change I made back then:
    Reduce priority of syslog message if getpeername returns ENOTCONN.
    PR bin/18934 by Greg A. Woods (with supplied fix).


 To generate a diff of this commit:
 cvs rdiff -u -r1.74 -r1.75 src/libexec/ftpd/version.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Luke Mewburn" <lukem@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/18934 CVS commit: othersrc/libexec/tnftpd/src
Date: Thu, 21 Mar 2013 00:58:18 +0000

 Module Name:	othersrc
 Committed By:	lukem
 Date:		Thu Mar 21 00:58:18 UTC 2013

 Update of /cvsroot/othersrc/libexec/tnftpd/src
 In directory ivanova.netbsd.org:/tmp/cvs-serv29049

 Log Message:
 Import NetBSD-ftpd 20100320:
 - Fix warnings and build issues
 - Fix memcpy usage
 - Fix remote crash (fix was already pulled up manually to tnftpd).  PR/43023
 - Reduce priority of syslog message if getpeername returns ENOTCONN.  PR/18934

 Status:

 Vendor Tag:	TNF
 Release Tags:	NetBSD-20130321

 C othersrc/libexec/tnftpd/src/cmds.c
 C othersrc/libexec/tnftpd/src/ftpd.c
 U othersrc/libexec/tnftpd/src/pathnames.h
 U othersrc/libexec/tnftpd/src/ftpusers.5
 C othersrc/libexec/tnftpd/src/popen.c
 U othersrc/libexec/tnftpd/src/ftpd.conf.5
 C othersrc/libexec/tnftpd/src/logutmp.c
 C othersrc/libexec/tnftpd/src/version.h
 U othersrc/libexec/tnftpd/src/ftpd.8
 C othersrc/libexec/tnftpd/src/ftpcmd.y
 C othersrc/libexec/tnftpd/src/extern.h
 U othersrc/libexec/tnftpd/src/logwtmp.c
 C othersrc/libexec/tnftpd/src/Makefile
 C othersrc/libexec/tnftpd/src/conf.c

 9 conflicts created by this import.
 Use the following command to help the merge:

 	cvs checkout -jTNF:yesterday -jTNF othersrc/libexec/tnftpd/src

From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/18934 CVS commit: pkgsrc/net/tnftpd
Date: Mon, 25 Mar 2013 04:11:25 +0000

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Mar 25 04:11:25 UTC 2013

 Modified Files:
 	pkgsrc/net/tnftpd: Makefile distinfo

 Log Message:
 Security fix to tnftpd, to bring the version to 20130325.

 Differences from previous 20100324 version:

 	Mon Mar 25 03:51:20 UTC 2013	lukem

 		* Fix incorrect use of test(1) in configure.

 	Fri Mar 22 09:00:00 UTC 2013	lukem

 		* Release as "tnftpd 20130322"

 		* Update build framekwork to autoconf 2.69, automake 1.11.1,
 		  libtool 2.4.2.

 		* Replace glob with newer copy from NetBSD that does not suffer
 		  from DoS exhaustion attacks.
 		  Fix in NetBSD from Maksymilian Arciemowicz.  See CVE-2010-2632

 		* Update to NetBSD-ftpd 20130321:
 			* Fix warnings and build issues
 			* Fix memcpy usage
 			* Fix remote crash (fix was already pulled up manually to
 			  tnftpd 20100324).  PR/43023 from Bruce Cran.
 			* Reduce priority of syslog message if getpeername returns
 			  ENOTCONN.  PR/18934 from Greg A Woods.

 pkgsrc changes - use pkgsrc libtool and add LICENSE


 To generate a diff of this commit:
 cvs rdiff -u -r1.23 -r1.24 pkgsrc/net/tnftpd/Makefile
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/net/tnftpd/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search