NetBSD Problem Report #18973

Received: (qmail 18831 invoked by uid 605); 8 Nov 2002 16:54:11 -0000
Message-Id: <1036773067.939011.583.nullmailer@yamt.dyndns.org>
Date: Sat, 09 Nov 2002 01:31:07 +0900
From: yamt@mwd.biglobe.ne.jp
Sender: gnats-bugs-owner@netbsd.org
Reply-To: yamt@mwd.biglobe.ne.jp
To: gnats-bugs@gnats.netbsd.org
Subject: lfs_sync wrong wait point
X-Send-Pr-Version: 3.95

>Number:         18973
>Category:       kern
>Synopsis:       lfs_sync wrong wait point
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 08 16:55:01 +0000 2002
>Closed-Date:    Sun Nov 24 08:59:34 +0000 2002
>Last-Modified:  Sun Nov 24 08:59:34 +0000 2002
>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release:        NetBSD 1.6K
>Organization:

>Environment:


System: NetBSD kaeru 1.6K NetBSD 1.6K (build.kaeru) #170: Sat Nov 9 00:41:22 JST 2002 takashi@kaeru:/usr/home/takashi/work/kernel/build.kaeru i386
Architecture: i386
Machine: i386
>Description:
	it seems lfs_sync waits on wrong address.
>How-To-Repeat:

>Fix:

Index: lfs_vfsops.c
===================================================================
RCS file: /cvs/NetBSD/syssrc/sys/ufs/lfs/lfs_vfsops.c,v
retrieving revision 1.82
diff -u -p -r1.82 lfs_vfsops.c
--- lfs_vfsops.c	2002/09/27 15:38:07	1.82
+++ lfs_vfsops.c	2002/10/26 11:34:01
@@ -1313,7 +1313,7 @@ lfs_sync(struct mount *mp, int waitfor, 
 	if (fs->lfs_ronly)
 		return 0;
 	while (fs->lfs_dirops)
-		error = tsleep(&fs->lfs_dirops, PRIBIO + 1, "lfs_dirops", 0);
+		error = tsleep(&fs->lfs_writer, PRIBIO + 1, "lfs_dirops", 0);
 	fs->lfs_writer++;

 	/* All syncs must be checkpoints until roll-forward is implemented. */
>Release-Note:
>Audit-Trail:

From: YAMAMOTO Takashi <yamt@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/18973 CVS commit: syssrc/sys/ufs/lfs
Date: Sun, 24 Nov 2002 10:37:44 +0200 (EET)

 Module Name:	syssrc
 Committed By:	yamt
 Date:		Sun Nov 24 08:37:44 UTC 2002

 Modified Files:
 	syssrc/sys/ufs/lfs: lfs_vfsops.c

 Log Message:
 lfs_sync should wait at lfs_writer, not lfs_dirops.
 PR 18973.


 To generate a diff of this commit:
 cvs rdiff -r1.82 -r1.83 syssrc/sys/ufs/lfs/lfs_vfsops.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: yamt 
State-Changed-When: Sun Nov 24 00:59:21 PST 2002 
State-Changed-Why:  
fixed 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.