NetBSD Problem Report #18988

Received: (qmail 2656 invoked by uid 605); 9 Nov 2002 07:31:13 -0000
Message-Id: <200211090731.gA97VBs00387@nforce.naobsd.org>
Date: Sat, 9 Nov 2002 16:31:11 +0900 (JST)
From: naoki@fukaumi.org
Sender: gnats-bugs-owner@netbsd.org
Reply-To: naoki@fukaumi.org
To: gnats-bugs@gnats.netbsd.org
Subject: ehci.c compile error
X-Send-Pr-Version: 3.95

>Number:         18988
>Category:       kern
>Synopsis:       ehci.c compile error
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 09 07:32:00 +0000 2002
>Closed-Date:    Sat Nov 09 09:02:26 +0000 2002
>Last-Modified:  Sat Nov 09 09:02:26 +0000 2002
>Originator:     FUKAUMI Naoki
>Release:        NetBSD 1.6J
>Organization:
	FUKAUMI Naoki
>Environment:
System: NetBSD nforce.naobsd.org 1.6J NetBSD 1.6J (NFORCE) #0: Wed Nov 6 11:49:59 JST 2002 fun@nforce.naobsd.org:/usr/obj/i386/sys/arch/i386/compile/NFORCE i386
Architecture: i386
Machine: i386
>Description:
	ehci.c can't compile if (EHCI_DEBUG && !DIAGNOSTIC) case.
	ehci_dump is not used. ehci_dump_exfer is used only DIAGNOSTIC.
>How-To-Repeat:
	enable options EHCI_DEBUG and disable options DIAGNOSTIC.
>Fix:
	patch

Index: ehci.c
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/usb/ehci.c,v
retrieving revision 1.37
diff -u -r1.37 ehci.c
--- ehci.c	2002/09/27 15:37:34	1.37
+++ ehci.c	2002/10/28 01:42:20
@@ -200,15 +200,16 @@

 #ifdef EHCI_DEBUG
 Static void		ehci_dump_regs(ehci_softc_t *);
-Static void		ehci_dump(void);
 Static ehci_softc_t 	*theehci;
 Static void		ehci_dump_link(ehci_link_t, int);
 Static void		ehci_dump_sqtds(ehci_soft_qtd_t *);
 Static void		ehci_dump_sqtd(ehci_soft_qtd_t *);
 Static void		ehci_dump_qtd(ehci_qtd_t *);
 Static void		ehci_dump_sqh(ehci_soft_qh_t *);
+#ifdef DIAGNOSTIC
 Static void		ehci_dump_exfer(struct ehci_xfer *);
 #endif
+#endif

 #define MS_TO_TICKS(ms) ((ms) * hz / 1000)

@@ -1054,12 +1055,6 @@
 }

 void
-ehci_dump()
-{
-	ehci_dump_regs(theehci);
-}
-
-void
 ehci_dump_link(ehci_link_t link, int type)
 {
 	link = le32toh(link);
@@ -1152,11 +1147,13 @@
 	ehci_dump_qtd(&qh->qh_qtd);
 }

+#ifdef DIAGNOSTIC
 Static void
 ehci_dump_exfer(struct ehci_xfer *ex)
 {
 	printf("ehci_dump_exfer: ex=%p\n", ex);
 }
+#endif
 #endif

 usbd_status
>Release-Note:
>Audit-Trail:

From: Martin Husemann <martin@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/18988 CVS commit: syssrc/sys/dev/usb
Date: Sat,  9 Nov 2002 10:59:47 +0200 (EET)

 Module Name:	syssrc
 Committed By:	martin
 Date:		Sat Nov  9 08:59:47 UTC 2002

 Modified Files:
 	syssrc/sys/dev/usb: ehci.c

 Log Message:
 Move ehci_dump_exfer into #ifdef DIAGNOSTIC, it's not called w/o.
 From FUKAUMI Naoki in PR 18988.


 To generate a diff of this commit:
 cvs rdiff -r1.37 -r1.38 syssrc/sys/dev/usb/ehci.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: martin 
State-Changed-When: Sat Nov 9 01:01:54 PST 2002 
State-Changed-Why:  
Patch commited, thanks! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.