NetBSD Problem Report #18991

Received: (qmail 9973 invoked by uid 605); 9 Nov 2002 09:57:10 -0000
Message-Id: <200211091002.gA9A28203194@darkstar.local>
Date: Sat, 9 Nov 2002 11:02:08 +0100 (CET)
From: Julio Merino <jmmv@menta.net>
Sender: gnats-bugs-owner@netbsd.org
Reply-To: jmmv@menta.net
To: gnats-bugs@gnats.netbsd.org
Subject: Make print/psutils honor PKG_SYSCONFDIR (plus fixes)
X-Send-Pr-Version: 3.95

>Number:         18991
>Category:       pkg
>Synopsis:       Make print/psutils honor PKG_SYSCONFDIR (plus fixes)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 09 09:58:00 +0000 2002
>Closed-Date:    Tue Nov 26 10:16:27 +0000 2002
>Last-Modified:  Tue Nov 26 10:16:27 +0000 2002
>Originator:     Julio Merino
>Release:        NetBSD 1.6K
>Organization:
HispaBSD
>Environment:


System: NetBSD darkstar.local 1.6K NetBSD 1.6K (DARKSTAR) #130: Thu Nov 7 23:22:44 CET 2002 jmmv@darkstar.local:/var/build/kernel/DARKSTAR i386
Architecture: i386
Machine: i386
>Description:
	The package print/psutils currently installs a configuration file
	directly inside ${PREFIX}/etc. This file should be managed with
	PKG_SYSCONFDIR stuff instead.

	The other problem is that the psutils.cfg file is not even
	registered by the PLIST.

	The attached patch also adds a HOMEPAGE to the package, to shut up
	pkglint.
>How-To-Repeat:

>Fix:
	Apply this patch:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/print/psutils/Makefile,v
retrieving revision 1.20
diff -u -u -r1.20 Makefile
--- Makefile	2001/09/27 23:18:36	1.20
+++ Makefile	2002/11/09 09:54:24
@@ -4,10 +4,12 @@

 DISTNAME=	psutils-p17
 PKGNAME=	psutils-1.17
+PKGREVISION=	1
 CATEGORIES=	print
 MASTER_SITES=	ftp://ftp.dcs.ed.ac.uk/pub/ajcd/

 MAINTAINER=	packages@netbsd.org
+HOMEPAGE=	http://www.go.dlr.de:8081/pdinfo_dv/psutils.html
 COMMENT=	Utilities for manipulating PostScript documents

 DEPENDS+=	papersize-[0-9]*:../../print/papersize
@@ -23,6 +25,9 @@
 MAKE_FLAGS+=	PAPER=`${ECHO} ${PAPERSIZE} | ${TR} '[A-Z]' '[a-z]'`
 MAKEFILE=	Makefile.unix

+EGDIR=		${PREFIX}/share/examples/psutils
+CONF_FILES=	${EGDIR}/psutils.cfg ${PKG_SYSCONFDIR}/psutils.cfg
+
 pre-configure:
 	@case "X${PAPERSIZE}" in					\
 	XA4|XLetter)							\
@@ -48,9 +53,9 @@
 	for f in epsffit psbook psnup psresize psselect pstops; do	\
 		strip ${PREFIX}/bin/$$f;				\
 	done
+	${INSTALL_DATA_DIR} ${EGDIR}
 	low=`${ECHO} ${PAPERSIZE} | ${TR} '[A-Z]' '[a-z]'`;		\
-	if [ ! -f ${PREFIX}/etc/psutils.cfg ]; then			\
-		${ECHO} "PAPERSIZE=$$low" > ${PREFIX}/etc/psutils.cfg;	\
-	fi
+	${ECHO} "PAPERSIZE=$$low" > ${EGDIR}/psutils.cfg;

+.include "../../mk/bsd.pkg.install.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/print/psutils/PLIST,v
retrieving revision 1.1
diff -u -u -r1.1 PLIST
--- PLIST	2001/10/31 23:28:00	1.1
+++ PLIST	2002/11/09 09:54:24
@@ -40,6 +40,8 @@
 man/man1/psresize.1.gz
 man/man1/psselect.1.gz
 man/man1/pstops.1.gz
+share/examples/psutils/psutils.cfg
 share/psutils/md68_0.ps
 share/psutils/md71_0.ps
+@dirrm share/examples/psutils
 @dirrm share/psutils


	Thank you!
>Release-Note:
>Audit-Trail:

From: Julio Merino <jmmv@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/18991 CVS commit: pkgsrc/print/psutils
Date: Tue, 26 Nov 2002 12:13:21 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	jmmv
 Date:		Tue Nov 26 10:13:20 UTC 2002

 Modified Files:
 	pkgsrc/print/psutils: Makefile PLIST

 Log Message:
 Make this package install its configuration file in the examples directory
 and use PKG_SYSCONFDIR to copy it to the right place. (Bump PKGREVISION to
 1 for this).
 Also add a HOMEPAGE, as the program has one.

 Approved by wiz.

 This closes my own PR 18991.


 To generate a diff of this commit:
 cvs rdiff -r1.20 -r1.21 pkgsrc/print/psutils/Makefile
 cvs rdiff -r1.1 -r1.2 pkgsrc/print/psutils/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: jmmv 
State-Changed-When: Tue Nov 26 02:15:39 PST 2002 
State-Changed-Why:  
The patch has been commited. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.