NetBSD Problem Report #19190

Received: (qmail 11875 invoked by uid 605); 27 Nov 2002 23:47:05 -0000
Message-Id: <20021127234702.A55CBA@proven.weird.com>
Date: Wed, 27 Nov 2002 18:47:02 -0500 (EST)
From: woods@weird.com (Greg A. Woods)
Sender: gnats-bugs-owner@netbsd.org
Reply-To: woods@planix.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org
Subject: shells/ast-ksh is not correct (and as a result, does not build)
X-Send-Pr-Version: 3.95

>Number:         19190
>Category:       pkg
>Synopsis:       shells/ast-ksh is not correct (and as a result, does not build)
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 27 23:48:00 +0000 2002
>Closed-Date:    Fri Nov 29 04:19:22 +0000 2002
>Last-Modified:  Fri Nov 29 04:19:22 +0000 2002
>Originator:     Greg A. Woods
>Release:        pkgsrc-current 2002/11/26
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD 1.5W
Architecture: i386 sparc
Machine: i386 sparc
>Description:

	the shells/ast-ksh build rules don't follow the documentation
	properly.

	the command to build ksh is "make", not "${MAKE}"!!!!

	also, it seems the build script is not /bin/sh compatible, at
	least not on my 1.5W systems....

	as a result of fixing these problems it seems ast-ksh is indeed
	entirely compatible with BUILDLINK2.

	also as a result ast-ksh should work on any NetBSD, not just
	i386.  (seems to run OK on my sparc systems as well)


	ast-ksh can no doubt be made to work on other platforms too by
	using shells/pdksh whenever the native /bin/sh is not viable and
	when an older native ksh (or xpg4 sh) is not available.

>How-To-Repeat:

>Fix:

Index: shells/ast-ksh/Makefile
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/shells/ast-ksh/Makefile,v
retrieving revision 1.3
diff -c -r1.3 Makefile
*** shells/ast-ksh/Makefile	17 Nov 2002 09:01:59 -0000	1.3
--- shells/ast-ksh/Makefile	27 Nov 2002 23:07:16 -0000
***************
*** 17,35 ****
  NO_SRC_ON_CDROM=${RESTRICTED}
  NO_SRC_ON_FTP=	${RESTRICTED}

! ONLY_FOR_PLATFORM=	NetBSD-*-i386

  ASTKSH_VERSION=	2002-09-22

! NO_BUILDLINK2=	# arcane build procedure causes buildlink2 to not work
  WRKSRC=		${WRKDIR}
! MAKE_FLAGS=	CC="${BUILDLINK_CC}" CCFLAGS="${CFLAGS}"

  PKG_SHELL=	${PREFIX}/bin/ksh93

  do-build:
  	cd ${WRKSRC}; \
! 	${SETENV} SHELL=${SH} ${SH} ./bin/package ${MAKE_PROGRAM} ${MAKE_FLAGS}

  do-install:
  	arch=`${WRKSRC}/bin/package host`; \
--- 17,36 ----
  NO_SRC_ON_CDROM=${RESTRICTED}
  NO_SRC_ON_FTP=	${RESTRICTED}

! # needs pdksh
! ONLY_FOR_PLATFORM=	NetBSD-*

  ASTKSH_VERSION=	2002-09-22

! USE_BUILDLINK2=	YES
  WRKSRC=		${WRKDIR}
! MAKE_FLAGS=	CC="${CC}" CCFLAGS="${CFLAGS}"

  PKG_SHELL=	${PREFIX}/bin/ksh93

  do-build:
  	cd ${WRKSRC}; \
! 	${SETENV} SHELL=/bin/ksh /bin/ksh ./bin/package make

  do-install:
  	arch=`${WRKSRC}/bin/package host`; \
>Release-Note:
>Audit-Trail:

From: Masao Uebayashi <uebayasi@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/19190 CVS commit: pkgsrc/shells/ast-ksh
Date: Fri, 29 Nov 2002 06:16:46 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	uebayasi
 Date:		Fri Nov 29 04:16:46 UTC 2002

 Modified Files:
 	pkgsrc/shells/ast-ksh: Makefile

 Log Message:
 Build script needs to be run with Pdksh.  Reconverted to Buildlink2.

 Fix provided in PR19190 by Greg A. Woods.


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.4 pkgsrc/shells/ast-ksh/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: uebayasi 
State-Changed-When: Thu Nov 28 20:18:34 PST 2002 
State-Changed-Why:  
Patch is applied with slight changes by me.  Thanks for the report! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.