NetBSD Problem Report #19305

Received: (qmail 29547 invoked by uid 605); 6 Dec 2002 19:56:19 -0000
Message-Id: <20021206195617.0C3F011124@narn.netbsd.org>
Date: Fri,  6 Dec 2002 11:56:17 -0800 (PST)
From: sketch@rd.bbc.co.uk
Sender: gnats-bugs-owner@netbsd.org
Reply-To: sketch@rd.bbc.co.uk
To: gnats-bugs@gnats.netbsd.org
Subject: Make pkgsrc/net/tinyfugue respect $CC and $CFLAGS
X-Send-Pr-Version: www-1.0

>Number:         19305
>Category:       pkg
>Synopsis:       Make pkgsrc/net/tinyfugue respect $CC and $CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 06 19:57:00 +0000 2002
>Closed-Date:    Thu Dec 12 21:04:04 +0000 2002
>Last-Modified:  Thu Dec 12 21:05:00 +0000 2002
>Originator:     Jonathan Perkin
>Release:        Today's CVS
>Organization:
British Broadcasting Corporation
>Environment:
SunOS sunf25 5.7 Generic_106541-16 sun4u sparc SUNW,Ultra-5_10
>Description:
tinyfugue pkgsrc doesn't pass down or use $CC nor $CFLAGS, so defaults
to gcc and -O.  This is suboptimal on e.g. Solaris machines using Sun
Workshop compiler "cc", especially if gcc does not exist.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/tinyfugue/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile    2001/05/16 15:39:10     1.7
+++ Makefile    2002/12/06 19:53:39
@@ -17,5 +17,6 @@
 INSTALL_TARGET=        ${MAKE_ARGS} install

 MAKE_ARGS=     TFVER=${DISTNAME:S/^tf-//}
+MAKE_ENV=      CC=${CC} CFLAGS=${CFLAGS}

 .include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/net/tinyfugue/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo    2001/05/16 15:39:11     1.3
+++ distinfo    2002/12/06 19:53:39
@@ -2,5 +2,5 @@

 SHA1 (tf-40s1.tar.gz) = 89ee75d0d8501dd7fe5440c81cf9b294e5ccf746
 Size (tf-40s1.tar.gz) = 349239 bytes
-SHA1 (patch-ab) = f6a691a2d6f1555da2adacb419b0f63316ab5b9a
+SHA1 (patch-ab) = c5f724e5f035129a05d6c1301e8ec93d08ea3192
 SHA1 (patch-ac) = fddc7d415ca8716be1fc45c95a5b5e6888cbf1ae
Index: patches/patch-ab
===================================================================
RCS file: /cvsroot/pkgsrc/net/tinyfugue/patches/patch-ab,v
retrieving revision 1.3
diff -u -r1.3 patch-ab
--- patches/patch-ab    1998/08/07 11:11:01     1.3
+++ patches/patch-ab    2002/12/06 19:53:39
@@ -29,3 +29,14 @@


  ### Flags.
+@@ -109,8 +112,8 @@
+ # If unixmake told you to set CC=cc, be sure to uncomment the line below
+ # by removing the leading "#".
+ 
+-# CC=cc
+-# CCFLAGS="-g"
++CC=${CC}
++CCFLAGS=${CFLAGS}
+ 
+ 
+ ### Stripping.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jmmv 
State-Changed-When: Thu Dec 12 13:03:19 PST 2002 
State-Changed-Why:  
I have fixed the problem. Thanks for the PR! 

From: Julio Merino <jmmv@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/19305 CVS commit: pkgsrc/net/tinyfugue
Date: Thu, 12 Dec 2002 23:02:59 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	jmmv
 Date:		Thu Dec 12 21:02:59 UTC 2002

 Modified Files:
 	pkgsrc/net/tinyfugue: Makefile distinfo
 	pkgsrc/net/tinyfugue/patches: patch-ab

 Log Message:
 Convert this package to use buildlink2, so it passes sane variables to the
 build process. This way it is easier to respect CC and CFLAGS.

 Based on patch provided in PR pkg/19305 by Jonathan Perkin.

 Also depend on gettext-lib, as the program links against -lintl.


 To generate a diff of this commit:
 cvs rdiff -r1.7 -r1.8 pkgsrc/net/tinyfugue/Makefile
 cvs rdiff -r1.3 -r1.4 pkgsrc/net/tinyfugue/distinfo
 cvs rdiff -r1.3 -r1.4 pkgsrc/net/tinyfugue/patches/patch-ab

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.