NetBSD Problem Report #19344

Received: (qmail 234 invoked by uid 605); 11 Dec 2002 03:47:05 -0000
Message-Id: <20021211034659.248581B323A@zembla.Princeton.EDU>
Date: Tue, 10 Dec 2002 22:46:59 -0500 (EST)
From: Christopher Richards <richards+netbsd@CS.Princeton.EDU>
Sender: gnats-bugs-owner@netbsd.org
Reply-To: richards+netbsd@CS.Princeton.EDU
To: gnats-bugs@gnats.netbsd.org
Subject: lang/nawk: Unquoted CFLAGS causes build failure (patch)
X-Send-Pr-Version: 3.95

>Number:         19344
>Category:       pkg
>Synopsis:       lang/nawk: Unquoted CFLAGS causes build failure (patch)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 11 03:48:01 +0000 2002
>Closed-Date:    Wed Dec 11 10:22:00 +0000 2002
>Last-Modified:  Wed Dec 11 10:22:03 +0000 2002
>Originator:     Christopher Richards
>Release:        NetBSD 1.6_STABLE
>Organization:

>Environment:


System: NetBSD zembla.Princeton.EDU 1.6_STABLE NetBSD 1.6_STABLE (ZEMBLA) #16: Mon Dec 2 21:44:56 EST 2002 richards@zembla.Princeton.EDU:/home/richards/x/src/kern i386
Architecture: i386
Machine: i386
>Description:

	If the user's CFLAGS contains spaces, lang/nawk fails to build
	due to improper quoting.

>How-To-Repeat:

	cd /usr/pkgsrc/lang/nawk; make CFLAGS="-O2 -g"

>Fix:
	Patch follows.  (Includes small manpage spelling fix also.)

Index: lang/nawk/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nawk/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- lang/nawk/Makefile	2002/12/09 00:05:27	1.7
+++ lang/nawk/Makefile	2002/12/11 03:38:58
@@ -14,11 +14,12 @@

 WRKSRC=		${WRKDIR}
 MAKEFILE=	makefile
-MAKEFLAGS+=	CC=${CC} YACC=${YACC} CFLAGS=${CFLAGS}
+MAKEFLAGS+=	CC=${CC} YACC=${YACC} CFLAGS=${CFLAGS:Q}
 ALL_TARGET=	a.out

 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/a.out ${PREFIX}/bin/nawk
-	${SED} -e 's|awk|nawk|g' ${WRKSRC}/awk.1 > ${PREFIX}/man/man1/nawk.1
+	${SED} -e 's|awk|nawk|g' -e 's|Awk|Nawk|g' \
+		${WRKSRC}/awk.1 > ${PREFIX}/man/man1/nawk.1

 .include "../../mk/bsd.pkg.mk"

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jmmv 
State-Changed-When: Wed Dec 11 02:21:26 PST 2002 
State-Changed-Why:  
I have applied the patch. 
Thank you for the PR! 

From: Julio Merino <jmmv@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/19344 CVS commit: pkgsrc/lang/nawk
Date: Wed, 11 Dec 2002 12:21:19 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	jmmv
 Date:		Wed Dec 11 10:21:18 UTC 2002

 Modified Files:
 	pkgsrc/lang/nawk: Makefile

 Log Message:
 Quote CFLAGS when passing them to MAKEFLAGS; if they contain spaces, build
 will fail. Also fix a "typo" in the manpage (Awk->Nawk). Patch provided by
 Christopher Richards in PR pkg/19344.

 While I'm here, move manpage generation to the post-build target (where it
 should be) and use INSTALL_MAN to install it (instead of generating it in
 place).


 To generate a diff of this commit:
 cvs rdiff -r1.7 -r1.8 pkgsrc/lang/nawk/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.