NetBSD Problem Report #19614

Received: (qmail 18075 invoked by uid 605); 30 Dec 2002 23:31:44 -0000
Message-Id: <20021230233138.27B2611124@narn.netbsd.org>
Date: Mon, 30 Dec 2002 15:31:38 -0800 (PST)
From: roskens@elfin.net
Sender: gnats-bugs-owner@netbsd.org
Reply-To: roskens@elfin.net
To: gnats-bugs@gnats.netbsd.org
Subject: audio device uses play ringbuffer information for record ringbuffer watermarks
X-Send-Pr-Version: www-1.0

>Number:         19614
>Category:       kern
>Synopsis:       audio device uses play ringbuffer information for record ringbuffer watermarks
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 30 23:32:01 +0000 2002
>Closed-Date:    Tue Dec 31 00:34:05 +0000 2002
>Last-Modified:  Tue Dec 31 00:34:05 +0000 2002
>Originator:     Ron Roskens
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
The audio device driver has a typo in the audio_calcwater() function. When defining the record high watermark, it should be against sc_rr not sc_pr.

If you have an audio device which returns different values for the buffersizes, you'll hit this problem if the record buffer is larger than the play buffer.
>How-To-Repeat:

>Fix:
diff -w -u -r1.170 audio.c
--- /usr/src/sys/dev/audio.c    2002/12/20 18:30:01     1.170
+++ /usr/src/sys/dev/audio.c    2002/12/30 23:27:32
@@ -872,7 +872,7 @@
        if (sc->sc_pr.usedlow == sc->sc_pr.usedhigh)
                sc->sc_pr.usedlow -= sc->sc_pr.blksize;
        sc->sc_rr.usedhigh =
-               sc->sc_pr.end - sc->sc_pr.start - sc->sc_pr.blksize;
+               sc->sc_rr.end - sc->sc_rr.start - sc->sc_rr.blksize;
        sc->sc_rr.usedlow = 0;
 }


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: augustss 
State-Changed-When: Mon Dec 30 16:33:38 PST 2002 
State-Changed-Why:  
Patch applied. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.