NetBSD Problem Report #19967

Received: (qmail 845 invoked by uid 605); 20 Jan 2003 22:20:05 -0000
Message-Id: <200301202219.h0KMJuj02060@lucifer.inet>
Date: Mon, 20 Jan 2003 23:19:56 +0100 (CET)
From: pino@dohd.org
Sender: gnats-bugs-owner@netbsd.org
Reply-To: pino@dohd.org
To: gnats-bugs@gnats.netbsd.org
Subject: audio/mp3blaster doesn't build with native threading
X-Send-Pr-Version: 3.95

>Number:         19967
>Category:       pkg
>Synopsis:       audio/mp3blaster doesn't build with native threading
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 20 22:21:00 +0000 2003
>Closed-Date:    Tue Jan 21 17:43:14 +0000 2003
>Last-Modified:  Sat Apr 29 09:05:39 +0000 2006
>Originator:     
>Release:        NetBSD 1.6M
>Organization:

>Environment:


System: NetBSD lucifer.ipv6.stack.nl 1.6M NetBSD 1.6M (LUCIFER) #8: Mon Jan 20 11:51:21 CET 2003 martijnb@lucifer.ipv6.stack.nl:/sys/arch/i386/compile/LUCIFER i386
Architecture: i386
Machine: i386
>Description:
	mp3blaster doesn't compile with native threading at the moment. It
	is currently being configured with an alternative buffering 
	technique (Written by yours truly) which uses specific pth calls, and
	therefore requires pth (and not native threading). It has not yet
	been ported to pthreads.

	The "standard" threading version works with native threading, but has
	serious performance issues with pth.

>How-To-Repeat:

	On a NetBSD system with native threading:

	cd audio/mp3blaster; make

	Watch how the configure script enables pth without checking for it
	(this bug has been reported to the original author, and will be 
	 fixed), and watch it try to use pth include files.

>Fix:

    The following patch will only enable the 'newthreads' scheme when
    pth is being used.

--- Makefile.org	Mon Jan 20 20:59:16 2003
+++ Makefile	Mon Jan 20 21:00:28 2003
@@ -16,10 +16,14 @@
 CONFIGURE_ARGS+="--with-cxxflags=${CXXFLAGS}" \
 		--with-curses \
 		--with-oggvorbis 
-		--enable-newthreads

 .include "../../audio/libvorbis/buildlink2.mk"
 .include "../../devel/ncurses/buildlink2.mk"
 .include "../../mk/ossaudio.buildlink2.mk"
 .include "../../mk/pthread.buildlink2.mk"
+
+.if defined(PTHREAD_TYPE) && (${PTHREAD_TYPE} == "pth")
+   CONFIGURE_ARGS+= --enable-newthreads
+.endif
+
 .include "../../mk/bsd.pkg.mk"
>Release-Note:
>Audit-Trail:

From: Stoned Elipot <seb@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/19967 CVS commit: pkgsrc/audio/mp3blaster
Date: Tue, 21 Jan 2003 19:40:32 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	seb
 Date:		Tue Jan 21 17:40:31 UTC 2003

 Modified Files:
 	pkgsrc/audio/mp3blaster: Makefile

 Log Message:
 Fix build with native threads on -current.
 Provided in PR pkg/19967 by <pino at dohd dot org>.
 PKGREVISION++


 To generate a diff of this commit:
 cvs rdiff -r1.6 -r1.7 pkgsrc/audio/mp3blaster/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: seb 
State-Changed-When: Tue Jan 21 09:42:49 PST 2003 
State-Changed-Why:  
Fix applied. Thanks! 

From: Stoned Elipot <seb@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/19967 CVS commit: pkgsrc/doc
Date: Tue, 21 Jan 2003 19:42:52 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	seb
 Date:		Tue Jan 21 17:42:49 UTC 2003

 Modified Files:
 	pkgsrc/doc: CHANGES

 Log Message:
 Note update of audio/mp3blaster to 3.1.3nb1 [native threads fix]
 From PR pkg/19967 by <pino at dohd dot org>.


 To generate a diff of this commit:
 cvs rdiff -r1.1184 -r1.1185 pkgsrc/doc/CHANGES

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.