NetBSD Problem Report #19985

Received: (qmail 23315 invoked by uid 605); 21 Jan 2003 16:24:51 -0000
Message-Id: <20030121162446.3255619A3CD@leeloo.intern.geht.de>
Date: Tue, 21 Jan 2003 17:24:46 +0100 (CET)
From: marc@informatik.uni-bremen.de
Sender: gnats-bugs-owner@netbsd.org
Reply-To: marc@informatik.uni-bremen.de
To: gnats-bugs@gnats.netbsd.org
Cc: wiz@netbsd.org
Subject: pkg ncurses needed by aspell?
X-Send-Pr-Version: 3.95

>Number:         19985
>Category:       pkg
>Synopsis:       devel/ncurses unnecessary in textproc/aspell !(?)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 21 16:25:00 +0000 2003
>Closed-Date:    Wed Jan 22 10:38:59 +0000 2003
>Last-Modified:  Wed Jan 22 10:38:59 +0000 2003
>Originator:     Marc Recht
>Release:        NetBSD 1.6M
>Organization:

>Environment:


System: NetBSD leeloo.intern.geht.de 1.6M NetBSD 1.6M (LEELOO) #1: Tue Jan 21 14:38:35 CET 2003 root@leeloo.intern.geht.de:/usr/obj/sys/arch/i386/compile/LEELOO i386
Architecture: i386
Machine: i386
>Description:
The forced (USE_NCURSES=YES) usage of devel/ncurses in textproc/aspell seems to be unnecessary. On mordern systems the halfdelay function should be present. (It's required by "The Single UNIX ® Specification, Version 2", http://www.opengroup.org/onlinepubs/007908799/xcurses/halfdelay.html)
For older systems ncurses will be build, because of the inclusion of devel/ncurses/buildlink2.mk .


>How-To-Repeat:
cd textproc/aspell ; make

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/aspell/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile    2003/01/15 00:23:55     1.4
+++ Makefile    2003/01/21 16:05:58
@@ -15,9 +15,6 @@
 USE_LIBTOOL=           yes
 LIBTOOL_OVERRIDE=      ${WRKSRC}/libtool

-# halfdelay()
-USE_NCURSES=           yes
-
 CONFIGURE_ARGS+=       --enable-doc-dir=${PREFIX}/share/doc/aspell
 CONFIGURE_ARGS+=       --enable-curses=ncurses


>Release-Note:
>Audit-Trail:

From: Lubomir Sedlacik <salo@Xtrmntr.org>
To: marc@informatik.uni-bremen.de
Cc: gnats-bugs@gnats.netbsd.org, wiz@netbsd.org
Subject: Re: pkg/19985: pkg ncurses needed by aspell?
Date: Tue, 21 Jan 2003 17:54:54 +0100

 --sdtB3X0nJg68CQEu
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 hi,

 On Tue, Jan 21, 2003 at 05:24:46PM +0100, marc@informatik.uni-bremen.de wro=
 te:
 > >Fix:
 > Index: Makefile
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/pkgsrc/textproc/aspell/Makefile,v
 > retrieving revision 1.4
 > diff -u -r1.4 Makefile
 > --- Makefile    2003/01/15 00:23:55     1.4
 > +++ Makefile    2003/01/21 16:05:58
 > @@ -15,9 +15,6 @@
 >  USE_LIBTOOL=3D           yes
 >  LIBTOOL_OVERRIDE=3D      ${WRKSRC}/libtool
 > =20
 > -# halfdelay()
 > -USE_NCURSES=3D           yes
 > -
 >  CONFIGURE_ARGS+=3D       --enable-doc-dir=3D${PREFIX}/share/doc/aspell
 >  CONFIGURE_ARGS+=3D       --enable-curses=3Dncurses
 > =20

 have you actually tried that?

 =2E..
 c++ -DHAVE_CONFIG_H -I. -I. -I../common -I../common/ -I../interfaces/cc/ -I=
 ../modules/speller/default/   -I/usr/pkg/include  -O2 -march=3Dpentiumpro -=
 pipe -I/usr/pkg/include -march=3Dpentiumpro -pipe -c -o check_funs.o `test =
 -f 'check_funs.cpp' || echo './'`check_funs.cpp
 check_funs.cpp: In function `void layout_screen()':
 check_funs.cpp:208: implicit declaration of function `int halfdelay(...)'
 gmake[1]: *** [check_funs.o] Error 1
 =2E..

 this is on -current system.  inspecting /usr/lib/libcurses.so reveals
 that there is no halfdelay() in netbsd-1-5 or netbsd-1-6 either.  the
 USE_NCURSES is perfectly valid here.


 regards,

 --=20
 -- Lubomir Sedlacik <salo@Xtrmntr.org>                   --
 --                  <salo@silcnet.org>                   --

 --sdtB3X0nJg68CQEu
 Content-Type: application/pgp-signature
 Content-Disposition: inline

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (NetBSD)

 iD8DBQE+LXteiwjDDlS8cmMRAnB2AJwJ0+8CP+8tdSEQIhtC0aeI9EkIfACfWBZm
 8smyzyfZeDuJmxpxIu3hYjI=
 =uDCu
 -----END PGP SIGNATURE-----

 --sdtB3X0nJg68CQEu--

From: Marc Recht <marc@informatik.uni-bremen.de>
To: Lubomir Sedlacik <salo@Xtrmntr.org>
Cc: gnats-bugs@gnats.netbsd.org, wiz@netbsd.org
Subject: Re: pkg/19985: pkg ncurses needed by aspell?
Date: Tue, 21 Jan 2003 18:12:27 +0100

 --==========1747082778==========
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline

 > have you actually tried that?
 Of course.

 > c++ -DHAVE_CONFIG_H -I. -I. -I../common -I../common/ -I../interfaces/cc/
 [..]
 > gmake[1]: *** [check_funs.o] Error 1
 > ...

 > this is on -current system.  inspecting /usr/lib/libcurses.so reveals
 > that there is no halfdelay() in netbsd-1-5 or netbsd-1-6 either.  the
 > USE_NCURSES is perfectly valid here.
 Builds and installs fine (and seems to work) on my 1.6M (today's sources).

 Maybe this USE_NCURSES could be dependent on the NetBSD version or =
 something
 like USE_NCURSES=3Dhalfdelay could be implemented in ncurses' =
 buildlink2.mk?

 Regards,
 Marc

 --
 "Premature optimization is the root of all evil." -- Donald E. Knuth
 --==========1747082778==========
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (NetBSD)

 iD8DBQE+LX977YQCetAaG3MRAqw/AJ9hEmCqHcpNuxq3xflk6RREiksjmQCfcGLJ
 Y4kquOj/yzmD6boX06Dr3TQ=
 =TdUu
 -----END PGP SIGNATURE-----

 --==========1747082778==========--


From: Thomas Klausner <wiz@netbsd.org>
To: Marc Recht <marc@informatik.uni-bremen.de>
Cc: Lubomir Sedlacik <salo@Xtrmntr.org>, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/19985: pkg ncurses needed by aspell?
Date: Tue, 21 Jan 2003 18:16:06 +0100

 On Tue, Jan 21, 2003 at 06:12:27PM +0100, Marc Recht wrote:
 > Builds and installs fine (and seems to work) on my 1.6M (today's sources).
 > 
 > Maybe this USE_NCURSES could be dependent on the NetBSD version or something
 > like USE_NCURSES=halfdelay could be implemented in ncurses' buildlink2.mk?

 halfdelay was added beginning of this year.
 USE_NCURSES in aspell should be replaced by
 INCOMPAT_CURSES=	NetBSD-1.[45]*-* NetBSD-1.6-* NetBSD-1.6.*-* NetBSD-1.6[A-L]-*
 or something similar (1.6M is the first working version, I think).

 I wanted to do that, but didn't get around to it.

 Actually, there's some more packages that could be changed this way, but
 I didn't get around to it. :)

 Cheers,
  Thomas

From: Lubomir Sedlacik <salo@Xtrmntr.org>
To: marc@informatik.uni-bremen.de
Cc: gnats-bugs@gnats.netbsd.org, wiz@netbsd.org
Subject: Re: pkg/19985: pkg ncurses needed by aspell?
Date: Tue, 21 Jan 2003 18:31:20 +0100

 hi,

 On Tue, Jan 21, 2003 at 06:16:06PM +0100, Thomas Klausner wrote:
 >
 > I wanted to do that, but didn't get around to it.

 will you do that or can i commit it && close PR?

 > Actually, there's some more packages that could be changed this way,
 > but I didn't get around to it. :)

 i can check them all (there are not that many of them anymore) as soon
 as i update my laptop to 1.6M (sometime this week).  do you have some
 preliminary list of them?


 regards,

 --=20
 -- Lubomir Sedlacik <salo@Xtrmntr.org>                   --
 --                  <salo@silcnet.org>                   --

From: Lubomir Sedlacik <salo@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/19985 CVS commit: pkgsrc/textproc/aspell
Date: Wed, 22 Jan 2003 12:26:16 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	salo
 Date:		Wed Jan 22 10:26:15 UTC 2003

 Modified Files:
 	pkgsrc/textproc/aspell: Makefile PLIST

 Log Message:
 Limit dependency on ncurses only to systems which really need it.
 We have halfdelay() in NetBSD 1.6M curses already.  Also fix PLIST.
 Bump PKGREVISION.

 Per discussion with wiz.  Addresses PR pkg/19985.

 XXX: Operating systems other than NetBSD and SunOS don't have any
      reasonable defaults set in devel/ncurses/buildlink2.mk.
      This should be addressed!


 To generate a diff of this commit:
 cvs rdiff -r1.4 -r1.5 pkgsrc/textproc/aspell/Makefile
 cvs rdiff -r1.2 -r1.3 pkgsrc/textproc/aspell/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: salo 
State-Changed-When: Wed Jan 22 02:37:40 PST 2003 
State-Changed-Why:  
issue fixed but slightly different using INCOMPAT_CURSES.  thanks! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.