NetBSD Problem Report #20760

Received: (qmail 14030 invoked by uid 605); 17 Mar 2003 01:51:36 -0000
Message-Id: <20030317015134.D6BB95DCA@home.mewburn.net>
Date: Mon, 17 Mar 2003 12:51:34 +1100 (EST)
From: lukem@netbsd.org
Sender: gnats-bugs-owner@netbsd.org
Reply-To: lukem@netbsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: libxml2 installs tutorial with incorrect owner
X-Send-Pr-Version: 3.95

>Number:         20760
>Category:       pkg
>Synopsis:       libxml2 installs tutorial with incorrect owner
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 17 01:52:00 +0000 2003
>Closed-Date:    Tue Mar 18 22:43:40 +0000 2003
>Last-Modified:  Tue Mar 18 22:43:40 +0000 2003
>Originator:     Luke Mewburn
>Release:        NetBSD 1.6.1_RC2
>Organization:
>Environment:
System: NetBSD argo.mewburn.net 1.6.1_RC2 NetBSD 1.6.1_RC2 (ARGO from GENERIC-$Revision: 1.491.4.2 $) #1: Fri Mar 14 11:08:41 EST 2003 lukem@argo.mewburn.net:/var/obj/i386-1-6/ARGO i386
Architecture: i386
Machine: i386
>Description:
	Install pkgsrc/textproc/libxml2 as a non-root user,
	relying upon mk.conf(5)'s "SU_CMD" to do the right thing.

	Notice that
		/usr/pkg/share/doc/html/libxml2/tutorial
	and all the files under there are owned by "you"
	not root:wheel.

>How-To-Repeat:
	See above.

>Fix:
	Whack the package?
>Release-Note:
>Audit-Trail:

From: David Ferlier <david@netbsd-fr.org>
To: lukem@netbsd.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760: libxml2 installs tutorial with incorrect owner
Date: Mon, 17 Mar 2003 08:05:53 +0100

 On Mon, Mar 17, 2003 at 12:51:34PM +1100, lukem@netbsd.org wrote:
 > 
 > >Number:         20760
 > >Category:       pkg
 > >Synopsis:       libxml2 installs tutorial with incorrect owner
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Sun Mar 16 17:52:00 PST 2003
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Luke Mewburn
 > >Release:        NetBSD 1.6.1_RC2
 > >Organization:
 > >Environment:
 > System: NetBSD argo.mewburn.net 1.6.1_RC2 NetBSD 1.6.1_RC2 (ARGO from GENERIC-$Revision: 1.491.4.2 $) #1: Fri Mar 14 11:08:41 EST 2003 lukem@argo.mewburn.net:/var/obj/i386-1-6/ARGO i386
 > Architecture: i386
 > Machine: i386
 > >Description:
 > 	Install pkgsrc/textproc/libxml2 as a non-root user,
 > 	relying upon mk.conf(5)'s "SU_CMD" to do the right thing.
 > 
 > 	Notice that
 > 		/usr/pkg/share/doc/html/libxml2/tutorial
 > 	and all the files under there are owned by "you"
 > 	not root:wheel.
 > 	
 > >How-To-Repeat:
 > 	See above.
 > 
 > >Fix:
 > 	Whack the package?
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:

 Hi Luke,

 Actually, they are not installed as "you", but as the user that originally owns
 the files in the xml2 tree : if you watch closely in work/libxml2-2.5.4 or
 whatever version you currently have, you'll see that all the files are owned by
 user id 50138 and group id 69. Since doc/Makefile uses tar(1) to install the
 tutorial directory and not install(1), the installed files are given these
 values (this is the default behavior of tar).

 Just apply the following patch in /usr/pkgsrc/textproc/libxml2 (this is the best
 way to do it, we could patch doc/Makefile.am and use install instead of tar, but
 there are some directories inside tutorial so it's easier to use tar)

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/textproc/libxml2/Makefile,v
 retrieving revision 1.23
 diff -b -u -r1.23 Makefile
 --- Makefile	2003/03/04 16:52:07	1.23
 +++ Makefile	2003/03/17 06:56:53
 @@ -26,6 +26,9 @@
  CFLAGS+=	-DXML_SGML_DEFAULT_CATALOG=\"\\\"${SGML_DEFAULT_CATALOG}\\\"\"
  CFLAGS+=	-DXML_XML_DEFAULT_CATALOG=\"\\\"${XML_DEFAULT_CATALOG}\\\"\"

 +pre-patch:
 +	chown -R `id -u`:`id -g` ${WRKSRC}
 +
  .include "../../devel/zlib/buildlink2.mk"
  .include "../../converters/libiconv/buildlink2.mk"
  .include "../../textproc/xmlcatmgr/catalogs.mk"

 -- 
 	David Ferlier -- david@netbsd-fr.org

     http://happy-hacking.homeunix.org/~krp		(IPV4)  ||
     http://fortress.segfault.quatriemek.com/~krp	(IPV6)


From: Luke Mewburn <lukem@netbsd.org>
To: David Ferlier <david@netbsd-fr.org>
Cc: lukem@netbsd.org, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760: libxml2 installs tutorial with incorrect owner
Date: Mon, 17 Mar 2003 18:22:15 +1100

 On Mon, Mar 17, 2003 at 08:05:53AM +0100, David Ferlier wrote:
   | Hi Luke,
   | 
   | Actually, they are not installed as "you", but as the user that originally owns
   | the files in the xml2 tree : if you watch closely in work/libxml2-2.5.4 or
   | whatever version you currently have, you'll see that all the files are owned by
   | user id 50138 and group id 69. Since doc/Makefile uses tar(1) to install the
   | tutorial directory and not install(1), the installed files are given these
   | values (this is the default behavior of tar).

 hi david.

 actually, they *are* installed as "me", not the user in the original
 tar file, since i extract, patch, configure and build as my ordinary
 user, and when i run "make install" pkgsrc invokes SU_CMD (from
 mk.conf) to run the installation as root.


   | Just apply the following patch in /usr/pkgsrc/textproc/libxml2
   | (this is the best way to do it, we could patch doc/Makefile.am and
   | use install instead of tar, but there are some directories inside
   | tutorial so it's easier to use tar)

 this won't work; see above.

 a more appropriate fix would probably be to add:

 	post-install:
 		chown -R root:wheel ${PREFIX}/share/doc/html/libxml2/tutorial


 i'm still not convinced that the above is "pkgsrc correct", which is
 why i submitted the PR to enable the pkgsrc gurus to comment :)


   | Index: Makefile
   | ===================================================================
   | RCS file: /cvsroot/pkgsrc/textproc/libxml2/Makefile,v
   | retrieving revision 1.23
   | diff -b -u -r1.23 Makefile
   | --- Makefile	2003/03/04 16:52:07	1.23
   | +++ Makefile	2003/03/17 06:56:53
   | @@ -26,6 +26,9 @@
   |  CFLAGS+=	-DXML_SGML_DEFAULT_CATALOG=\"\\\"${SGML_DEFAULT_CATALOG}\\\"\"
   |  CFLAGS+=	-DXML_XML_DEFAULT_CATALOG=\"\\\"${XML_DEFAULT_CATALOG}\\\"\"
   |  
   | +pre-patch:
   | +	chown -R `id -u`:`id -g` ${WRKSRC}
   | +
   |  .include "../../devel/zlib/buildlink2.mk"
   |  .include "../../converters/libiconv/buildlink2.mk"
   |  .include "../../textproc/xmlcatmgr/catalogs.mk"



 luke.

From: Julio Merino <jmmv@menta.net>
To: gnats-bugs@gnats.netbsd.org
Cc: david@netbsd-fr.org, lukem@netbsd.org
Subject: Re: pkg/20760
Date: Mon, 17 Mar 2003 16:04:20 +0000

 I don't see why this is happening.  Furthermore, in my system, all those
 files are properly installed.

 Take a look at patch-ad, which is actually touching the relevant thing in
 doc/Makefile.in:

 -       -@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xvf -))
 +       -@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xmvf -))

 (we add the -m flag so that print-PLIST works better)

 Tar is not given the -p flag, so it should not preserve ownerships at all.
 Note that that command is only run when installing, so you are already root.
 Copied files should be root:wheel... so why are them?

 About the patch posted by David, it's wrong. You should not call commands
 directly (see ${CHOWN} and the like). Anyway, it could be good enought to
 do something like this at post-install:
 ${CHOWN} -R ${ROOT_USER}:${ROOT_GROUP} ${PREFIX}/share/doc/libxml2/tutorial
 iff we don't find why it's failing to do the Right Thing (TM) by default.

 -- 
 Julio M. Merino Vidal <jmmv@menta.net>
 The NetBSD Project - http://www.NetBSD.org/

From: David Ferlier <david@netbsd-fr.org>
To: Luke Mewburn <lukem@netbsd.org>
Cc: David Ferlier <david@netbsd-fr.org>, gnats-bugs@gnats.netbsd.org,
  jmmv@menta.net
Subject: Re: pkg/20760: libxml2 installs tutorial with incorrect owner
Date: Tue, 18 Mar 2003 06:43:35 +0100

 On Mon, Mar 17, 2003 at 06:22:15PM +1100, Luke Mewburn wrote:
 > On Mon, Mar 17, 2003 at 08:05:53AM +0100, David Ferlier wrote:
 >   | Hi Luke,
 >   | 
 >   | Actually, they are not installed as "you", but as the user that originally owns
 >   | the files in the xml2 tree : if you watch closely in work/libxml2-2.5.4 or
 >   | whatever version you currently have, you'll see that all the files are owned by
 >   | user id 50138 and group id 69. Since doc/Makefile uses tar(1) to install the
 >   | tutorial directory and not install(1), the installed files are given these
 >   | values (this is the default behavior of tar).
 > 
 > hi david.
 > 
 > actually, they *are* installed as "me", not the user in the original
 > tar file, since i extract, patch, configure and build as my ordinary
 > user, and when i run "make install" pkgsrc invokes SU_CMD (from
 > mk.conf) to run the installation as root.
 > 
 > 
 >   | Just apply the following patch in /usr/pkgsrc/textproc/libxml2
 >   | (this is the best way to do it, we could patch doc/Makefile.am and
 >   | use install instead of tar, but there are some directories inside
 >   | tutorial so it's easier to use tar)
 > 
 > this won't work; see above.
 > 
 > a more appropriate fix would probably be to add:
 > 
 > 	post-install:
 > 		chown -R root:wheel ${PREFIX}/share/doc/html/libxml2/tutorial
 > 
 > 
 > i'm still not convinced that the above is "pkgsrc correct", which is
 > why i submitted the PR to enable the pkgsrc gurus to comment :)
 > 
 > 
 >   | Index: Makefile
 >   | ===================================================================
 >   | RCS file: /cvsroot/pkgsrc/textproc/libxml2/Makefile,v
 >   | retrieving revision 1.23
 >   | diff -b -u -r1.23 Makefile
 >   | --- Makefile	2003/03/04 16:52:07	1.23
 >   | +++ Makefile	2003/03/17 06:56:53
 >   | @@ -26,6 +26,9 @@
 >   |  CFLAGS+=	-DXML_SGML_DEFAULT_CATALOG=\"\\\"${SGML_DEFAULT_CATALOG}\\\"\"
 >   |  CFLAGS+=	-DXML_XML_DEFAULT_CATALOG=\"\\\"${XML_DEFAULT_CATALOG}\\\"\"
 >   |  
 >   | +pre-patch:
 >   | +	chown -R `id -u`:`id -g` ${WRKSRC}
 >   | +
 >   |  .include "../../devel/zlib/buildlink2.mk"
 >   |  .include "../../converters/libiconv/buildlink2.mk"
 >   |  .include "../../textproc/xmlcatmgr/catalogs.mk"
 > 
 > 
 > 
 > luke.

 Sorry luke, i just looked at your reply and realized my patch was incorrect (at
 least for your problem, but we have different problems. It was working for me)

 Julio proposed to put a ${CHOWN} in post-install, but there's even better. With
 the following patch, i pipe the tar xmvf to xargs chown root:wheel, no need to
 badly and temporarly patch the Makefile.

 David

 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/textproc/libxml2/distinfo,v
 retrieving revision 1.21
 diff -b -u -r1.21 distinfo
 --- distinfo	2003/03/04 16:52:07	1.21
 +++ distinfo	2003/03/18 05:22:48
 @@ -3,5 +3,5 @@
  SHA1 (libxml2-2.5.4.tar.gz) = d2dcd5889e0d547c86fc4ba266eeb28f03167d8c
  Size (libxml2-2.5.4.tar.gz) = 2923095 bytes
  SHA1 (patch-aa) = c079f9cc5083fa6d9817c1161ff20ae782e86c92
 -SHA1 (patch-ad) = 812ce13682ee70e44e7127e2ead326395e299f4e
 +SHA1 (patch-ad) = f4a4be90c00610d86300c897c7a362e1557808c9
  SHA1 (patch-ae) = a94390e26b8344b94d78b0faa4b9ce50390e5e5b
 Index: patches/patch-ad
 ===================================================================
 RCS file: /cvsroot/pkgsrc/textproc/libxml2/patches/patch-ad,v
 retrieving revision 1.9
 diff -b -u -r1.9 patch-ad
 --- patches/patch-ad	2003/02/25 14:41:37	1.9
 +++ patches/patch-ad	2003/03/18 05:22:49
 @@ -1,8 +1,6 @@
 -$NetBSD: patch-ad,v 1.9 2003/02/25 14:41:37 jmmv Exp $
 -
 ---- doc/Makefile.in.orig	2003-02-10 17:28:02.000000000 +0100
 -+++ doc/Makefile.in
 -@@ -137,7 +137,7 @@ XPTR_OBJ = @XPTR_OBJ@
 +--- doc/Makefile.in.orig	Mon Feb 24 21:15:02 2003
 ++++ doc/Makefile.in	Tue Mar 18 06:20:31 2003
 +@@ -138,7 +138,7 @@
   Z_CFLAGS = @Z_CFLAGS@
   Z_LIBS = @Z_LIBS@

 @@ -11,7 +9,7 @@

   # The top-level SGML file.
   DOC_MAIN_SGML_FILE = gnome-xml.sgml
 -@@ -147,7 +147,7 @@ DOC_SOURCE_DIR = ..
 +@@ -148,7 +148,7 @@

   HTML_DIR = $(datadir)/doc

 @@ -20,13 +18,14 @@
   PAGES = architecture.html bugs.html contribs.html docs.html DOM.html \
       downloads.html entities.html example.html help.html index.html \
       interface.html intro.html library.html namespaces.html news.html \
 -@@ -369,8 +369,7 @@ install-data-local: 
 +@@ -370,8 +370,8 @@
   	-@INSTALL@ -m 0644 $(srcdir)/xml.html $(srcdir)/encoding.html $(srcdir)/FAQ.html $(srcdir)/structure.gif $(srcdir)/DOM.gif $(srcdir)/smallfootonly.gif $(srcdir)/redhat.gif $(srcdir)/libxml.gif $(srcdir)/w3c.png $(srcdir)/Libxml2-Logo-180x168.gif $(srcdir)/Libxml2-Logo-90x34.gif $(DESTDIR)$(TARGET_DIR)
   	-@INSTALL@ -m 0644 $(srcdir)/html/*.html $(DESTDIR)$(TARGET_DIR)
   	-@INSTALL@ -m 0644 $(srcdir)/html/index.sgml $(DESTDIR)$(TARGET_DIR)
  -	-(cd $(DESTDIR); gtkdoc-fixxref --module=libxml --html-dir=$(HTML_DIR))
  -	-@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xvf -))
 -+	-@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xmvf -))
 ++	-@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xmvf - | \
 ++		xargs chown root:wheel))

   .PHONY : html sgml templates scan


 -- 
 	David Ferlier -- david@netbsd-fr.org

     http://happy-hacking.homeunix.org/~krp		(IPV4)  ||
     http://fortress.segfault.quatriemek.com/~krp	(IPV6)


From: Luke Mewburn <lukem@netbsd.org>
To: Julio Merino <jmmv@menta.net>
Cc: gnats-bugs@gnats.netbsd.org, david@netbsd-fr.org, lukem@netbsd.org
Subject: Re: pkg/20760
Date: Tue, 18 Mar 2003 21:55:21 +1100

 On Mon, Mar 17, 2003 at 04:04:20PM +0000, Julio Merino wrote:
   | I don't see why this is happening.  Furthermore, in my system, all those
   | files are properly installed.
   | 
   | Take a look at patch-ad, which is actually touching the relevant thing in
   | doc/Makefile.in:
   | 
   | -       -@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xvf -))
   | +       -@(tar cf - tutorial | (cd $(DESTDIR)$(TARGET_DIR) && tar xmvf -))
   | 
   | (we add the -m flag so that print-PLIST works better)
   | 
   | Tar is not given the -p flag, so it should not preserve ownerships at all.
   | Note that that command is only run when installing, so you are already root.
   | Copied files should be root:wheel... so why are them?

 Because tar run as root will retain the ownership (even without -p),
 and the ownership of the tutorial directory is me and not root.

 The simple solution appears to run chown in post-install...

 Luke.

From: Luke Mewburn <lukem@netbsd.org>
To: David Ferlier <david@netbsd-fr.org>
Cc: Luke Mewburn <lukem@netbsd.org>, gnats-bugs@gnats.netbsd.org,
  jmmv@menta.net
Subject: Re: pkg/20760: libxml2 installs tutorial with incorrect owner
Date: Tue, 18 Mar 2003 21:56:32 +1100

 On Tue, Mar 18, 2003 at 06:43:35AM +0100, David Ferlier wrote:
   | Sorry luke, i just looked at your reply and realized my patch
   | was incorrect (at least for your problem, but we have different
   | problems. It was working for me)
   |
   | Julio proposed to put a ${CHOWN} in post-install, but there's even
   | better. With the following patch, i pipe the tar xmvf to xargs chown
   | root:wheel, no need to badly and temporarly patch the Makefile.

 that's fragile if files have whitespace in them.

 The chown -R  approach in post-install seems to be the best to me,
 but I'll wait to see what the senior pkgsrc developers have to say.

From: Julio Merino <jmmv@menta.net>
To: Luke Mewburn <lukem@netbsd.org>
Cc: gnats-bugs@gnats.netbsd.org, david@netbsd-fr.org
Subject: Re: pkg/20760
Date: Tue, 18 Mar 2003 14:23:49 +0000

 On Tue, 18 Mar 2003 21:55:21 +1100
 Luke Mewburn <lukem@netbsd.org> wrote:

 > Because tar run as root will retain the ownership (even without -p),
 > and the ownership of the tutorial directory is me and not root.
 > 
 > The simple solution appears to run chown in post-install...

 Note: do _not_ set ownerships of files to root in the work directory.
 If you do so, then "make clean" will break as an unprivileged user...
 Anyway, why I don't see this behavior in -current?

 Another thing, can pax (not tar) extract files and set ownerships on
 the fly? (I mean, discard original ownerships). If so, we can simply
 replace the tar call with a call to pax...

 -- 
 Julio M. Merino Vidal <jmmv@menta.net>
 The NetBSD Project - http://www.NetBSD.org/

From: Luke Mewburn <lukem@netbsd.org>
To: Julio Merino <jmmv@menta.net>
Cc: Luke Mewburn <lukem@netbsd.org>, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760
Date: Wed, 19 Mar 2003 00:53:30 +1100

 On Tue, Mar 18, 2003 at 02:23:49PM +0000, Julio Merino wrote:
   | On Tue, 18 Mar 2003 21:55:21 +1100
   | Luke Mewburn <lukem@netbsd.org> wrote:
   | 
   | > Because tar run as root will retain the ownership (even without -p),
   | > and the ownership of the tutorial directory is me and not root.
   | > 
   | > The simple solution appears to run chown in post-install...
   | 
   | Note: do _not_ set ownerships of files to root in the work directory.
   | If you do so, then "make clean" will break as an unprivileged user...

 I wasn't suggesting changing the ownership of the files in the work
 directory; where did you get that idea from?  I was talking about
 chowning the files in the installed location after installation, which
 is why the "post-install" target was suggested.


   | Anyway, why I don't see this behavior in -current?

 Do you build as "you"?
 Do you install as "root" (using SU_CMD)?

 It could be that pax-as-tar in -current has different permission
 preservation semantics than gnutar-as-tar in NetBSD 1.6.
 Since we still support 1.6, we can't rely upon -current's behaviour.


   | Another thing, can pax (not tar) extract files and set ownerships on
   | the fly? (I mean, discard original ownerships). If so, we can simply
   | replace the tar call with a call to pax...

 Sounds more complicated than we need.

From: Luke Mewburn <lukem@netbsd.org>
To: Julio Merino <jmmv@menta.net>
Cc: Luke Mewburn <lukem@netbsd.org>, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760
Date: Wed, 19 Mar 2003 00:55:16 +1100

 On Wed, Mar 19, 2003 at 12:53:30AM +1100, Luke Mewburn wrote:
   | It could be that pax-as-tar in -current has different permission
   | preservation semantics than gnutar-as-tar in NetBSD 1.6.
   | Since we still support 1.6, we can't rely upon -current's behaviour.

 To clarify, different semantics when "-p" is not given.

From: Julio Merino <jmmv@menta.net>
To: Luke Mewburn <lukem@netbsd.org>
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760
Date: Tue, 18 Mar 2003 15:12:10 +0000

 On Wed, 19 Mar 2003 00:53:30 +1100
 Luke Mewburn <lukem@netbsd.org> wrote:

 > On Tue, Mar 18, 2003 at 02:23:49PM +0000, Julio Merino wrote:
 >   | On Tue, 18 Mar 2003 21:55:21 +1100
 >   | Luke Mewburn <lukem@netbsd.org> wrote:
 >   | 
 >   | > Because tar run as root will retain the ownership (even without -p),
 >   | > and the ownership of the tutorial directory is me and not root.
 >   | > 
 >   | > The simple solution appears to run chown in post-install...
 >   | 
 >   | Note: do _not_ set ownerships of files to root in the work directory.
 >   | If you do so, then "make clean" will break as an unprivileged user...
 > 
 > I wasn't suggesting changing the ownership of the files in the work
 > directory; where did you get that idea from?  I was talking about
 > chowning the files in the installed location after installation, which
 > is why the "post-install" target was suggested.

 Yes, I know you said nothing about this.  I just pointed this out (to
 clarify something related with one of the previous replies).

 >   | Anyway, why I don't see this behavior in -current?
 > 
 > Do you build as "you"?
 > Do you install as "root" (using SU_CMD)?

 Yes, and yes.

 > It could be that pax-as-tar in -current has different permission
 > preservation semantics than gnutar-as-tar in NetBSD 1.6.
 > Since we still support 1.6, we can't rely upon -current's behaviour.

 Well, but we can forget tar and tweak the package to directly use pax
 if it solves the problem.  pax is as well included in the bootstrap kit.
 If current pax behaves the same as 1.6/1.5 pax, I think the problem goes
 away by using it (for example, see char/pircbot which uses pax to copy
 files, and I see that permissions are properly set).

 >   | Another thing, can pax (not tar) extract files and set ownerships on
 >   | the fly? (I mean, discard original ownerships). If so, we can simply
 >   | replace the tar call with a call to pax...
 > 
 > Sounds more complicated than we need.

 It is not. It's just changing one line (that we are already patching,
 anyway).

 -- 
 Julio M. Merino Vidal <jmmv@menta.net>
 The NetBSD Project - http://www.NetBSD.org/

From: Luke Mewburn <lukem@netbsd.org>
To: Julio Merino <jmmv@menta.net>
Cc: Luke Mewburn <lukem@netbsd.org>, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760
Date: Wed, 19 Mar 2003 01:13:12 +1100

 On Tue, Mar 18, 2003 at 03:12:10PM +0000, Julio Merino wrote:
   | It is not. It's just changing one line (that we are already patching,
   | anyway).

 Feel free to do this and test appropriately.
 (I'll reopen the PR with a /brick if you don't fix it correctly though ;-)
State-Changed-From-To: open->feedback 
State-Changed-By: jmmv 
State-Changed-When: Tue Mar 18 07:06:39 PST 2003 
State-Changed-Why:  
I've changed the package to use pax instead of tar to put files in place. 
Luke, can you check if this solves the problem?  Thanks. 

From: Julio Merino <jmmv@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/20760 CVS commit: pkgsrc/textproc/libxml2
Date: Tue, 18 Mar 2003 17:06:22 +0200 (EET)

 Module Name:	pkgsrc
 Committed By:	jmmv
 Date:		Tue Mar 18 15:06:21 UTC 2003

 Modified Files:
 	pkgsrc/textproc/libxml2: Makefile distinfo
 	pkgsrc/textproc/libxml2/patches: patch-ad

 Log Message:
 Use pax instead of tar to install the tutorial.  Hopefully fixes PR pkg/20760.


 To generate a diff of this commit:
 cvs rdiff -r1.23 -r1.24 pkgsrc/textproc/libxml2/Makefile
 cvs rdiff -r1.21 -r1.22 pkgsrc/textproc/libxml2/distinfo
 cvs rdiff -r1.9 -r1.10 pkgsrc/textproc/libxml2/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Luke Mewburn <lukem@netbsd.org>
To: jmmv@netbsd.org
Cc: lukem@netbsd.org, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/20760
Date: Wed, 19 Mar 2003 09:38:26 +1100

 On Tue, Mar 18, 2003 at 03:07:36PM -0000, jmmv@netbsd.org wrote:
   | Synopsis: libxml2 installs tutorial with incorrect owner
   | 
   | State-Changed-From-To: open->feedback
   | State-Changed-By: jmmv
   | State-Changed-When: Tue Mar 18 07:06:39 PST 2003
   | State-Changed-Why: 
   | I've changed the package to use pax instead of tar to put files in place.
   | Luke, can you check if this solves the problem?  Thanks.

 It does for ownership.

 For permissions, it does not.  However, since the pkg system complains
 at you if your umask is 077 (or similar), that indicates to me that
 many other packages are probably similarly affected, and it's not
 worth pursuing this any further at this time.  There is the semi-contrived
 failure case where you build as a normal user with umask 077 and install
 as root with umask of 022, and various items will inherit the
 077-affected-perms from the build.  Again, that probably affects a bunch
 of packages, so I'm not going to pursue this further.

 In short, close the PR.

 Thanks for fixing this,
 Luke.
State-Changed-From-To: feedback->closed 
State-Changed-By: jmmv 
State-Changed-When: Tue Mar 18 14:43:09 PST 2003 
State-Changed-Why:  
Luke confirms that the problem has been fixed (for the ownerships). 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.