NetBSD Problem Report #20763

Received: (qmail 2985 invoked by uid 605); 17 Mar 2003 04:53:46 -0000
Message-Id: <20030317045328.AA06E77810@burden>
Date: Sun, 16 Mar 2003 23:53:28 -0500 (EST)
From: jwjr@panix.com
Sender: gnats-bugs-owner@netbsd.org
Reply-To: jwjr@panix.com
To: gnats-bugs@gnats.netbsd.org
Subject: abcde shell script gives errors when enconders not installed
X-Send-Pr-Version: 3.95

>Number:         20763
>Category:       pkg
>Synopsis:       abcde shell script gives errors when enconders not installed
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    agc
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 17 04:54:00 +0000 2003
>Closed-Date:    Mon Sep 15 11:19:25 +0000 2003
>Last-Modified:  Mon Sep 15 11:20:00 +0000 2003
>Originator:     James B. Wetterau Jr.
>Release:        NetBSD 1.6P Tue Mar 11 15:06:39 EST 2003
>Organization:
Never!
>Environment:
System: NetBSD burden 1.6P NetBSD 1.6P (BURDEN) #0: Tue Mar 11 15:06:39 EST 2003 jwjr@burden:/usr/obj/sys/arch/i386/compile/BURDEN i386
Architecture: i386
Machine: i386
>Description:
	If oggenc, lame or some other enconder is not installed, a section of
	the abcde shell script for encoding CD's will fail, reporting
	on STDERR something like: 
[: oggenc: unexpected operator
[: vorbiscomment: unexpected operator
>How-To-Repeat:
	Install abcde from pkgsrc on a machine that does not have
oggenc or other encoders installed.  Insert a CD in the CDROM drive
and try "abcde".
>Fix:
	I have prepared the following patch in unified diff format.  I
worked with a version of abcde in /tmp/bcde until I was satisfied I
had it working.  The patch follows this line immediately:
--- /usr/pkg/bin/abcde	2003-03-16 23:15:46.000000000 -0500
+++ /tmp/bcde	2003-03-16 23:04:37.000000000 -0500
@@ -1237,7 +1237,9 @@
 do
 	# Cut off the command-line options we just added in
 	X=$(echo $X | cut -d' ' -f2)
-	if [ "$(which $X)" = "" ]; then
+	# edited to make this work properly on NetBSD
+	Y="$(which $X | cut -d' ' -f1,2)"
+	if [ "$Y" = "" -o "$Y" = "no $X" ]; then
 		echo "abcde error: $X is not in your path." >&2
 		exit 1
 	elif [ ! -x $(which $X) ]; then

>Release-Note:
>Audit-Trail:

From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/20763 CVS commit: pkgsrc/audio/abcde
Date: Mon, 15 Sep 2003 11:17:29 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Sep 15 11:17:28 UTC 2003

 Modified Files:
 	pkgsrc/audio/abcde: Makefile distinfo
 	pkgsrc/audio/abcde/patches: patch-ac
 Removed Files:
 	pkgsrc/audio/abcde/patches: patch-ae

 Log Message:
 Incorporate James Wetterau's patch from PR 20763 to warn if there is no
 encoder in the path.

 Unify patch-ac and patch-ae which both patch the same file.

 Bump pkgrevision to nb4


 To generate a diff of this commit:
 cvs rdiff -r1.16 -r1.17 pkgsrc/audio/abcde/Makefile
 cvs rdiff -r1.18 -r1.19 pkgsrc/audio/abcde/distinfo
 cvs rdiff -r1.13 -r1.14 pkgsrc/audio/abcde/patches/patch-ac
 cvs rdiff -r1.1 -r0 pkgsrc/audio/abcde/patches/patch-ae

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: agc 
State-Changed-When: Mon Sep 15 11:18:42 UTC 2003 
State-Changed-Why:  
agc added the patch to the package - thanks for providing it! 


Responsible-Changed-From-To: pkg-manager->agc 
Responsible-Changed-By: agc 
Responsible-Changed-When: Mon Sep 15 11:18:42 UTC 2003 
Responsible-Changed-Why:  
agc took responsibility for this one 

From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/20763 CVS commit: pkgsrc/doc
Date: Mon, 15 Sep 2003 11:18:30 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	agc
 Date:		Mon Sep 15 11:18:29 UTC 2003

 Modified Files:
 	pkgsrc/doc: CHANGES

 Log Message:
 Incorporate James Wetterau's patch from PR 20763 to warn if there is no
 encoder in the path.

 Unify patch-ac and patch-ae which both patch the same file.

 Bump pkgrevision to nb4


 To generate a diff of this commit:
 cvs rdiff -r1.3384 -r1.3385 pkgsrc/doc/CHANGES

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.