NetBSD Problem Report #21656

Received: (qmail 21884 invoked by uid 605); 23 May 2003 07:51:53 -0000
Message-Id: <20030523075153.21883.qmail@mail.netbsd.org>
Date: Fri, 23 May 2003 16:51:48 +0900
From: Toru TAKAMIZU <ttaka@earth.email.ne.jp>
Sender: gnats-bugs-owner@netbsd.org
Reply-To: ttaka@earth.email.ne.jp
To: gnats-bugs@gnats.netbsd.org
Subject: pkgsrc/wm/golem/Makefile should use "CFLAGS+=", not "CFLAGS="
X-Send-Pr-Version: 3.95

>Number:         21656
>Category:       pkg
>Synopsis:       pkgsrc/wm/golem/Makefile should use "CFLAGS+=", not "CFLAGS="
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 23 07:52:00 +0000 2003
>Closed-Date:    Fri May 23 07:53:53 +0000 2003
>Last-Modified:  Fri May 23 07:54:00 +0000 2003
>Originator:     Toru TAKAMIZU
>Release:        NetBSD 1.6.1_STABLE
>Organization:
>Environment:
System: NetBSD localhost 1.6.1_STABLE NetBSD 1.6.1_STABLE (MIWA) #27: Mon Apr 28 18:45:35 JST 2003 toru@localhost:/usr/src/sys/arch/i386/compile/MIWA i386
Architecture: i386
Machine: i386
>Description:
Unless you have a good reason to use "CFLAGS=", you have to use
"CFLAGS+=" (with `+'). Am I right?
>How-To-Repeat:
Under pkgsrc/wm/golem, type "make".
>Fix:
Add `+'.

Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/wm/golem/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	2003/05/18 21:09:07	1.2
+++ Makefile	2003/05/23 07:50:27
@@ -33,7 +33,7 @@
 PLIST_SUBST=		NOT_SOUND="@comment "
 .endif

-CFLAGS=		-DPKG_SYSCONFDIR=\"\\\"${PKG_SYSCONFDIR}\\\"\"
+CFLAGS+=		-DPKG_SYSCONFDIR=\"\\\"${PKG_SYSCONFDIR}\\\"\"

 EGDIR=		${PREFIX}/share/examples/golem
 CONF_FILES=	${EGDIR}/golemrc.default ${PKG_SYSCONFDIR}/golemrc
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: wiz 
State-Changed-When: Fri May 23 07:53:29 UTC 2003 
State-Changed-Why:  
You are right -- fixed, thanks. 

From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/21656 CVS commit: pkgsrc/wm/golem
Date: Fri, 23 May 2003 07:53:19 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Fri May 23 07:53:18 UTC 2003

 Modified Files:
 	pkgsrc/wm/golem: Makefile

 Log Message:
 CFLAGS+=, not CFLAGS=. From Toru TAKAMIZU in PR 21656.


 To generate a diff of this commit:
 cvs rdiff -r1.2 -r1.3 pkgsrc/wm/golem/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search