NetBSD Problem Report #21671

Received: (qmail 26738 invoked by uid 605); 25 May 2003 10:00:57 -0000
Message-Id: <20030525100001.DD44947C5E@Nocturno.xtraeme.unixbsd.org>
Date: Sun, 25 May 2003 12:00:01 +0200 (CEST)
From: juan@xtraeme.unixbsd.org
Sender: gnats-bugs-owner@netbsd.org
Reply-To: juan@xtraeme.unixbsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: Updated package audio/abcde
X-Send-Pr-Version: 3.95

>Number:         21671
>Category:       pkg
>Synopsis:       Updated package audio/abcde
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun May 25 10:01:00 +0000 2003
>Closed-Date:    Tue Jun 10 06:35:28 +0000 2003
>Last-Modified:  Tue Jun 10 06:35:28 +0000 2003
>Originator:     Juan RP
>Release:        NetBSD 1.6T
>Organization:
Juan RP		jrp@hispabsd.org
--
>Environment:
System: NetBSD Nocturno 1.6T NetBSD 1.6T (Nocturno) #5: Sat May 24 16:22:04 CEST 2003 juan@Insomnio:/home/juan/current/obj/sys/arch/i386/compile/Nocturno i386
Architecture: i386
Machine: i386
>Description:

abcde 2.1.4 is the latest version.

MASTER_SITE has been changed too.

Changes:

  * Small bug fixes:
    + COMMENT should work now.
    + Aesthetic padding on the total amount of tracks.
    + CDROM typo
    + CDROM is now checked after reading the user defined entries.
  * Remove trailing args from $EDITOR when checking -x: Closes #179222.

abcde 2.1.3

  * Makefile was missing cddb-tool.1.
  * Introduced dagrab as CD ripping utility.
  * cddb-tool seq calls converted to functions. No more distro dependencies.
  * WGET* variables converted to HTTPGET* variables. FreeBSD can safelly use
    fetch.
  * More FreeBSD specific bits: CDROM and EJECT changes.
  * Typo in abcde.conf
  * Added CDDBPROTO for specifying the protocol level of the cddb query.
  * CDDB protocol upgraded to 5. CDYEAR and CDGENRE are now used for CD
    tagging.
  * COMMENT is now used for inline tagging with oggenc (my mistake it was
    missing): Closes: #191475.

abcde 2.1.2

  * Documentation updates: Closes: #186230.
  * Usual set of bug fixes and corrections.
  * Default behaviour of VAOUTPUTFORMAT output changed to avoid multiple
    directories for a same album. I think the format is more logical, and you
    can always split the files once they are created.
  * Padding track wavs with 0 so if you want to burn those wavs just cdrecord
    *.wav will do it. Use "-p" to force it when encoding a small (<9) number
    of files (Closes: #111627).
  * Added "KEEPWAVS" as a variable to keep those wavs. Default is "no". Can
    use also "-k" in the command line. (Closes: #160372).
    This probably should be changed with an option to move the wav files to
    another directory instead of just keep de abcde.<cdid> directory.
  * Added documentation comments about OUTPUTTYPE (Closes: #184963).
  * abcde.conf cleanup: (Closes: #186230, #187400).

abcde 2.1.0-3

  * Since abcde does not depend on eject, an execution test ([-x]) was added,
    but that means abcde needs a test for eject in the patch if -x is passed:
    Closes: #184151.
  * Merged some more bits from Marc 'HE' Brockschmidt: Closes: #126289.
  * A bit of more info in abcde.conf: Closes: #184963.
  * cddb-tool version updated to 0.4.2

abcde 2.1.0-2

  * Old version string left behind. Updated.
  * Few more doc update bits.
  * Patches from Marc 'HE' Brockschmidt: Closes: #149499.
  * Small patch from Norbert Preining to support multiple output in the output
    directory.
  * cddb-tool parses CDYEAR with the help of awk: Closes: #114848.
  * cddb-tool does not globe "*" characters anymore: Closes: #157448.

 -- Jesus Climent <jesus.climent@hispalinux.es>  Fri, 7 Mar 2003

abcde 2.1.0
  * The infamous "Works for me(TM)" and "Time to release" release.
    + We preppend track number now: Closes: #128966.
    + Itegrate flac: Closes: #126311.
    + Multi-format encode: Closes: #148934.
    + Gapless lame encoding: Closes: #172696.
    + CDROM documented: Closes: #182403.
  * Applied OpenBSD patches to make the script more portable. Thanks to Han
    Boetes.
  * Documentation fixes: closes: #100844, #136741.
  * NetBSD patches applied:
    - EXPERIMENTAL Normalize and Batch support.
    - EXPERIMENTAL FLAC support.
  * EXPERIMENTAL multiple output support:
    + multiple output and error checking
    + multiple lists support
  * Default output file changed to have the $track_number in the begining.
  * abcde takeover.


>How-To-Repeat:
>Fix:


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/abcde/Makefile,v
retrieving revision 1.10
diff -b -u -r1.10 Makefile
--- Makefile	2003/01/01 19:06:01	1.10
+++ Makefile	2003/05/25 09:57:09
@@ -1,9 +1,8 @@
 # $NetBSD: Makefile,v 1.10 2003/01/01 19:06:01 kim Exp $

-DISTNAME=	abcde-2.0.3
-PKGREVISION=	3
+DISTNAME=	abcde-2.1.4
 CATEGORIES=	audio
-MASTER_SITES=	http://frantica.lly.org/~rcw/abcde/
+MASTER_SITES=	http://www.hispalinux.es/~data/files/
 DISTFILES=	${DISTNAME:S/-/_/}.orig.tar.gz

 MAINTAINER=	lukem@netbsd.org
@@ -24,7 +23,7 @@
 MESSAGE_SUBST+=	PKG_SYSCONFDIR=${PKG_SYSCONFDIR}

 pre-configure:
-	@cd ${WRKSRC} && for f in abcde abcde.1; do			\
+	@cd ${WRKSRC} && for f in abcde; do				\
 		${SED} "s,@PKG_SYSCONFDIR@,${PKG_SYSCONFDIR},"		\
 			$$f > $$f.tmp &&				\
 		${MV} $$f.tmp $$f;					\
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/audio/abcde/distinfo,v
retrieving revision 1.13
diff -b -u -r1.13 distinfo
--- distinfo	2003/01/01 19:06:01	1.13
+++ distinfo	2003/05/25 09:57:09
@@ -1,8 +1,7 @@
 $NetBSD: distinfo,v 1.13 2003/01/01 19:06:01 kim Exp $

-SHA1 (abcde_2.0.3.orig.tar.gz) = 66a7620a835baee29296f4d5e9322bb1679baa49
-Size (abcde_2.0.3.orig.tar.gz) = 35655 bytes
-SHA1 (patch-aa) = 262ab12dfe094f1fc50c5fa4ca19ab73a8b6541a
+SHA1 (abcde_2.1.4.orig.tar.gz) = 0d00d1ab462f38c449b575b17828bdc20c35ca65
+Size (abcde_2.1.4.orig.tar.gz) = 42945 bytes
 SHA1 (patch-ab) = 524452b3930c25351deee7a508f98bcd0f51a872
-SHA1 (patch-ac) = 59eccd903d65fe3834d9d728d69dca3c238a7f9e
-SHA1 (patch-ad) = b37aebe39a003da917d7b192e9169af4c2d17115
+SHA1 (patch-ac) = cafb1326d7417b8e283aae39ce870b46cf98295c
+SHA1 (patch-ad) = ce62d4ee4c79055664291e8debf82076f5ce0baf


$NetBSD: patch-ac,v 1.10 2003/01/01 19:06:02 kim Exp $

--- abcde.orig	2003-05-25 11:42:30.000000000 +0200
+++ abcde	2003-05-25 11:49:12.000000000 +0200
@@ -1233,8 +1233,8 @@
 fi

 # Load system defaults
-if [ -r /etc/abcde.conf ]; then
-	. /etc/abcde.conf
+if [ -r @PKG_SYSCONFDIR@/etc/abcde.conf ]; then
+	. @PKG_SYSCONFDIR@/etc/abcde.conf
 fi
 # Load user preference defaults
 if [ -r $HOME/.abcde.conf ]; then



$NetBSD: patch-ad,v 1.4 2002/11/29 19:12:38 kim Exp $

--- cddb-tool.orig	2003-05-25 11:49:49.000000000 +0200
+++ cddb-tool	2003-05-25 11:52:12.000000000 +0200
@@ -153,7 +153,7 @@
 	echo '#'
 	echo '# Track frame offsets:'
 	NUMTRACKS=$2
-	for x in $(f_seq 3 $(expr $NUMTRACKS + 2))
+	for x in $(jot $NUMTRACKS 3)
 	do
 		printf "#\t$(echo "$DISCID" | cut -f$x -d' ')\n"
 	done
@@ -171,13 +171,13 @@
 	echo "DYEAR="
 	echo "DGENRE="
 	# TTITLE0 -- TTITLEn
-	for x in $(f_seq 1 $NUMTRACKS)
+	for x in $(jot $NUMTRACKS 3)
 	do
 		echo "TTITLE$(expr $x - 1)=Track $x"
 	done
 	echo "EXTD="
 	# EXTT0 -- EXTTn
-	for x in $(f_seq 1 $NUMTRACKS)
+	for x in $(jot $NUMTRACKS 3)
 	do
 		echo "EXTT$(expr $x - 1)="
 	done
@@ -208,7 +208,7 @@
 read) # cddb-tool read serverurl proto user host genre discnumber
 	SERVER="$1"
 	PROTO="$2"
-	USER="$3"
+	uSER="$3"
 	HOST="$4"
 	CATEGORY="$5"
 	DISCID="$6"
>Release-Note:
>Audit-Trail:

From: Juan RP <jrp@hispabsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: Re: pkg/21671: Updated package audio/abcde
Date: Sun, 25 May 2003 12:43:04 +0200 (CEST)

 On Sun, 25 May 2003 12:00:01 +0200 (CEST)
 juan@xtraeme.unixbsd.org wrote:

 Sorry the patches patch-ac and patch-ad are wrong.
 These are the good patches:

 $NetBSD: patch-ac,v 1.10 2003/01/01 19:06:02 kim Exp $

 --- abcde.orig  2003-05-25 12:37:53.000000000 +0200
 +++ abcde       2003-05-25 12:40:44.000000000 +0200
 @@ -1233,8 +1233,8 @@
  fi

  # Load system defaults
 -if [ -r /etc/abcde.conf ]; then
 -       . /etc/abcde.conf
 +if [ -r @PKG_SYSCONFDIR@/etc/abcde.conf ]; then
 +       . @PKG_SYSCONFDIR@/etc/abcde.conf
  fi
  # Load user preference defaults
  if [ -r $HOME/.abcde.conf ]; then
 @@ -1260,8 +1260,9 @@
         elif [ -e /dev/acd0c ]; then
                 CDROM=/dev/acd0c
         else
 -               echo "abcde error: CDROM device cannot be found." >&2
 -               exit 1
 +            RAWPART=`sysctl -n kern.rawpartition | awk '{printf "%c",97+$0}'`
 +            CDROM=/dev/rcd0$RAWPART
 +            CDPARANOIAOPTS="-g ${CDROM}"
         fi
  fi

 ------ end patch-ac ------

 --- cddb-tool.orig      2003-05-25 12:32:29.000000000 +0200
 +++ cddb-tool   2003-05-25 12:34:12.000000000 +0200
 @@ -153,7 +153,7 @@
         echo '#'
         echo '# Track frame offsets:'
         NUMTRACKS=$2
 -       for x in $(f_seq 3 $(expr $NUMTRACKS + 2))
 +       for x in $(jot $NUMTRACKS 3))
         do
                 printf "#\t$(echo "$DISCID" | cut -f$x -d' ')\n"
         done
 @@ -171,13 +171,13 @@
         echo "DYEAR="
         echo "DGENRE="
         # TTITLE0 -- TTITLEn
 -       for x in $(f_seq 1 $NUMTRACKS)
 +       for x in $(jot $NUMTRACKS 3)
         do
                 echo "TTITLE$(expr $x - 1)=Track $x"
         done
         echo "EXTD="
         # EXTT0 -- EXTTn
 -       for x in $(f_seq 1 $NUMTRACKS)
 +       for x in $(jot $NUMTRACKS 3)
         do
                 echo "EXTT$(expr $x - 1)="
         done

 ----- end patch-ad ------


 Thank you.
 -- 
 Juan RP		jrp@hispabsd.org
 --

From: Soren Jacobsen <soren@blef.org>
To: juan@xtraeme.unixbsd.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/21671: Updated package audio/abcde
Date: Sun, 25 May 2003 08:37:18 -0700

 > @@ -208,7 +208,7 @@
 >  read) # cddb-tool read serverurl proto user host genre discnumber
 >  	SERVER="$1"
 >  	PROTO="$2"
 > -	USER="$3"
 > +	uSER="$3"

 Oops.

From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/21671 CVS commit: pkgsrc/audio/abcde
Date: Tue, 10 Jun 2003 06:29:08 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue Jun 10 06:29:07 UTC 2003

 Modified Files:
 	pkgsrc/audio/abcde: Makefile distinfo
 	pkgsrc/audio/abcde/patches: patch-ac patch-ad
 Removed Files:
 	pkgsrc/audio/abcde/patches: patch-aa

 Log Message:
 Update to 2.1.4, from Juan RP in PR 21671:
 abcde 2.1.4:

   * Small bug fixes:
     + COMMENT should work now.
     + Aesthetic padding on the total amount of tracks.
     + CDROM typo
     + CDROM is now checked after reading the user defined entries.
   * Remove trailing args from $EDITOR when checking -x: Closes #179222.

 abcde 2.1.3

   * Makefile was missing cddb-tool.1.
   * Introduced dagrab as CD ripping utility.
   * cddb-tool seq calls converted to functions. No more distro dependencies.
   * WGET* variables converted to HTTPGET* variables. FreeBSD can safelly use
     fetch.
   * More FreeBSD specific bits: CDROM and EJECT changes.
   * Typo in abcde.conf
   * Added CDDBPROTO for specifying the protocol level of the cddb query.
   * CDDB protocol upgraded to 5. CDYEAR and CDGENRE are now used for CD
     tagging.
   * COMMENT is now used for inline tagging with oggenc (my mistake it was
     missing): Closes: #191475.

 abcde 2.1.2

   * Documentation updates: Closes: #186230.
   * Usual set of bug fixes and corrections.
   * Default behaviour of VAOUTPUTFORMAT output changed to avoid multiple
     directories for a same album. I think the format is more logical, and you
     can always split the files once they are created.
   * Padding track wavs with 0 so if you want to burn those wavs just cdrecord
     *.wav will do it. Use "-p" to force it when encoding a small (<9) number
     of files (Closes: #111627).
   * Added "KEEPWAVS" as a variable to keep those wavs. Default is "no". Can
     use also "-k" in the command line. (Closes: #160372).
     This probably should be changed with an option to move the wav files to
     another directory instead of just keep de abcde.<cdid> directory.
   * Added documentation comments about OUTPUTTYPE (Closes: #184963).
   * abcde.conf cleanup: (Closes: #186230, #187400).

 abcde 2.1.0-3

   * Since abcde does not depend on eject, an execution test ([-x]) was added,
     but that means abcde needs a test for eject in the patch if -x is passed:
     Closes: #184151.
   * Merged some more bits from Marc 'HE' Brockschmidt: Closes: #126289.
   * A bit of more info in abcde.conf: Closes: #184963.
   * cddb-tool version updated to 0.4.2

 abcde 2.1.0-2

   * Old version string left behind. Updated.
   * Few more doc update bits.
   * Patches from Marc 'HE' Brockschmidt: Closes: #149499.
   * Small patch from Norbert Preining to support multiple output in the output
     directory.
   * cddb-tool parses CDYEAR with the help of awk: Closes: #114848.
   * cddb-tool does not globe "*" characters anymore: Closes: #157448.

 abcde 2.1.0
   * The infamous "Works for me(TM)" and "Time to release" release.
     + We preppend track number now: Closes: #128966.
     + Itegrate flac: Closes: #126311.
     + Multi-format encode: Closes: #148934.
     + Gapless lame encoding: Closes: #172696.
     + CDROM documented: Closes: #182403.
   * Applied OpenBSD patches to make the script more portable. Thanks to Han
     Boetes.
   * Documentation fixes: closes: #100844, #136741.
   * NetBSD patches applied:
     - EXPERIMENTAL Normalize and Batch support.
     - EXPERIMENTAL FLAC support.
   * EXPERIMENTAL multiple output support:
     + multiple output and error checking
     + multiple lists support
   * Default output file changed to have the $track_number in the begining.
   * abcde takeover.


 To generate a diff of this commit:
 cvs rdiff -r1.10 -r1.11 pkgsrc/audio/abcde/Makefile
 cvs rdiff -r1.13 -r1.14 pkgsrc/audio/abcde/distinfo
 cvs rdiff -r1.7 -r0 pkgsrc/audio/abcde/patches/patch-aa
 cvs rdiff -r1.10 -r1.11 pkgsrc/audio/abcde/patches/patch-ac
 cvs rdiff -r1.4 -r1.5 pkgsrc/audio/abcde/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: wiz 
State-Changed-When: Tue Jun 10 06:32:47 UTC 2003 
State-Changed-Why:  
Committed, thanks. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.