NetBSD Problem Report #21831
Received: (qmail 25604 invoked by uid 605); 9 Jun 2003 13:06:02 -0000
Message-Id: <1055162698.134409.936.nullmailer@yamt.dyndns.org>
Date: Mon, 09 Jun 2003 21:44:58 +0900
From: yamt@mwd.biglobe.ne.jp
Sender: gnats-bugs-owner@netbsd.org
Reply-To: yamt@NetBSD.org
To: gnats-bugs@gnats.netbsd.org
Subject: bridge(4) should take care of checksum offloading
X-Send-Pr-Version: 3.95
>Number: 21831
>Category: kern
>Synopsis: bridge(4) should take care of checksum offloading
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jun 09 13:07:00 +0000 2003
>Closed-Date: Thu Jun 30 05:20:52 +0000 2016
>Last-Modified: Thu Jun 30 05:20:52 +0000 2016
>Originator: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release: NetBSD 1.6T
>Organization:
>Environment:
System: NetBSD kaeru 1.6T NetBSD 1.6T (build.kaeru) #: Mon Jun 9 15:41:32 JST 2003 takashi@kaeru:/usr/home/takashi/work/kernel/build.kaeru i386
Architecture: i386
Machine: i386
>Description:
bridge(4) doesn't take care of checksum offloading.
>How-To-Repeat:
>Fix:
- bridge_forward() should clear out csum_flags.
- bridge_output() and bridge_broadcast() should do checksum
if the interface has no h/w checksum support.
(or don't delay checksumming for bridge member.)
>Release-Note:
>Audit-Trail:
From: tron@zhadum.de (by way of Erik E. Fair)
To: NetBSD GNATS Problem Report Tracking System <gnats-bugs@gnats.netbsd.org>
Cc:
Subject: Re: kern/21831: bridge(4) should take care of checksum offloading
Date: Fri, 20 Jun 2003 12:03:49 -0700
In article <1055162698.134409.936.nullmailer@yamt.dyndns.org>,
yamt@mwd.biglobe.ne.jp writes:
> - bridge_output() and bridge_broadcast() should do checksum
> if the interface has no h/w checksum support.
> (or don't delay checksumming for bridge member.)
The last suggestion sounds like a bad idea from a performance point of view.
Kind regards
--
Matthias Scheler http://scheler.de/~matthias/
From: Christoph Badura <bad@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/21831 CVS commit: src/sys/net
Date: Wed, 6 Oct 2004 10:01:00 +0000 (UTC)
Module Name: src
Committed By: bad
Date: Wed Oct 6 10:01:00 UTC 2004
Modified Files:
src/sys/net: if_bridge.c
Log Message:
Interfaces that do checksum offloading indicate the checksum status of
received packets in csum_flags in the packet header. Packets that are
forwarded over the bridge need to have csum_flags cleared before being
put on the output queue. Do so in bridge_enqueue().
Discussed with Jason Thorpe.
Fixes PR kern/27007 and the first part of PR kern/21831.
To generate a diff of this commit:
cvs rdiff -r1.25 -r1.26 src/sys/net/if_bridge.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: James Chacon <jmc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/21831 CVS commit: [netbsd-2-0] src/sys/net
Date: Fri, 8 Oct 2004 03:11:13 +0000 (UTC)
Module Name: src
Committed By: jmc
Date: Fri Oct 8 03:11:13 UTC 2004
Modified Files:
src/sys/net [netbsd-2-0]: if_bridge.c
Log Message:
Pullup rev 1.26 (requested by bad in ticket #900)
Interfaces that do checksum offloading indicate the checksum status of
received packets in csum_flags in the packet header. Packets that are
forwarded over the bridge need to have csum_flags cleared before being
put on the output queue. Do so in bridge_enqueue(). PR#27007 PR#21831
To generate a diff of this commit:
cvs rdiff -r1.22 -r1.22.2.1 src/sys/net/if_bridge.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/21831: bridge(4) should take care of checksum offloading
Date: Mon, 30 May 2016 05:19:47 +0000
What's the state of this? The commit in 2004 addressed the first of
two items in the original Fix: section, and tron@ said that the second
part didn't seem like a good idea...
--
David A. Holland
dholland@netbsd.org
State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 26 Jun 2016 04:21:32 +0000
State-Changed-Why:
I asked a question ("what's the state of this?")
From: Masanobu SAITOH <msaitoh@execsw.org>
To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org,
netbsd-bugs@netbsd.org, gnats-admin@netbsd.org, dholland@NetBSD.org,
yamt@NetBSD.org
Cc: msaitoh@execsw.org
Subject: Re: kern/21831 (bridge(4) should take care of checksum offloading)
Date: Thu, 30 Jun 2016 14:11:29 +0900
On 2016/06/26 13:21, dholland@NetBSD.org wrote:
> Synopsis: bridge(4) should take care of checksum offloading
>
> State-Changed-From-To: open->feedback
> State-Changed-By: dholland@NetBSD.org
> State-Changed-When: Sun, 26 Jun 2016 04:21:32 +0000
> State-Changed-Why:
> I asked a question ("what's the state of this?")
I think it's ok to close because it's fixed.
--
-----------------------------------------------
SAITOH Masanobu (msaitoh@execsw.org
msaitoh@netbsd.org)
State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 30 Jun 2016 05:20:52 +0000
State-Changed-Why:
Fixed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.