NetBSD Problem Report #22226

Received: (qmail 21104 invoked by uid 605); 23 Jul 2003 04:08:03 -0000
Message-Id: <28915-1058933282@rainier.reedmedia.net>
Date: Tue, 22 Jul 2003 21:08:02 -0700
From: reed@reedmedia.net
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: reed@reedmedia.net
To: gnats-bugs@gnats.netbsd.org
Subject: pkgsrc/mail/pine/files/pgpdecode has unsafe tmp file usage
X-Send-Pr-Version: 3.95

>Number:         22226
>Category:       security
>Synopsis:       pkgsrc/mail/pine/files/pgpdecode has unsafe tmp file usage
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    security-officer
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 23 04:09:00 +0000 2003
>Closed-Date:    Fri May 07 20:05:15 +0000 2004
>Last-Modified:  Fri May 07 21:44:21 +0000 2004
>Originator:     
>Release:        NetBSD 1.6
>Organization:
http://bsd.reedmedia.net/
>Environment:


System: NetBSD rainier.reedmedia.net 1.6 NetBSD 1.6 (JCR-20020927) #3: Sat Sep 28 13:40:20 PDT 2002 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/JCR-20020927 i386
Architecture: i386
Machine: i386
>Description:
See pkgsrc/mail/pine/files/pgpdecode
It has unsafe tmp file usage.

>How-To-Repeat:
Use jot and make a bunch of symlinks for 
/tmp/pgpdecode.txt.${n} to overwrite your important files.

And wait for someone to run pgpdecode (probably
automatically).
>Fix:
FreeBSD has an additional port called:
port/mail/pine-pgp-filters
It is based on
http://dougbarton.net/FreeBSD/Downloads/pine-pgp-filters-1.0.tar.gz

It has various improvements.

Maybe we should add a new package pkgsrc/mail/pine-pgp-filters
and use that download above.

Let me know if you want to use the new package, and I'll submit it.
>Release-Note:
>Audit-Trail:

From: Thomas Klausner <wiz@NetBSD.org>
To: reed@NetBSD.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/22226
Date: Wed, 24 Mar 2004 12:59:41 +0100

 Hi!

 Please do as you suggest in the PR, during the freeze is ok.

 Thank you,
  Thomas
State-Changed-From-To: open->analyzed 
State-Changed-By: reed 
State-Changed-When: Fri May 7 15:13:23 UTC 2004 
State-Changed-Why:  
I plan on removing all the pgp add-ons from the pkgsrc/mail/pine package 
and using MESSAGE to suggest the user install another package (pinepgp) 
for that capability. I also packaged pine-pgp-filters but it needs 
testing. So later pine-pgp-filters and pgpenvelope (both in 
pkgsrc-wip) will be in pkgsrc too for a total of three alternatives). 

I am waiting for approval from the maintainer of the pkgsrc/mail/pine 
package. If I don't hear back, I will commit my changes on Monday morning 
and close the PR. 

From: "Jeremy C. Reed" <reed@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/22226 CVS commit: pkgsrc/mail/pine
Date: Fri,  7 May 2004 20:00:53 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	reed
 Date:		Fri May  7 20:00:53 UTC 2004

 Modified Files:
 	pkgsrc/mail/pine: MESSAGE Makefile PLIST
 Removed Files:
 	pkgsrc/mail/pine/files: dot.pinerc.pgp.sample pgpdecode pgpencrypt
 	    pgpsign

 Log Message:
 pgp-related files removed. pine package no longer installs these
 outdated pgp helper filters. This was okay'd by maintainer,
 Kimmo Suominen.

 This fix will close my PR 22226.

 The pgpdecode shell script has an insecure tmp file issue.
 These pgp help scripts were rewritten in perl and the author no
 longer uses pine and possibly the scripts may not work with new
 pine versions.

 So now MESSAGE suggests installing the security/pinepgp package
 instead. Also available are wip/pgpenvelope and wip/pine-pgp-filters
 and when they are available in regular pkgsrc these will be
 suggested in the MESSAGE too.


 To generate a diff of this commit:
 cvs rdiff -r1.1 -r1.2 pkgsrc/mail/pine/MESSAGE
 cvs rdiff -r1.86 -r1.87 pkgsrc/mail/pine/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/mail/pine/PLIST
 cvs rdiff -r1.2 -r0 pkgsrc/mail/pine/files/dot.pinerc.pgp.sample \
     pkgsrc/mail/pine/files/pgpdecode pkgsrc/mail/pine/files/pgpencrypt \
     pkgsrc/mail/pine/files/pgpsign

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: analyzed->closed 
State-Changed-By: reed 
State-Changed-When: Fri May 7 20:04:29 UTC 2004 
State-Changed-Why:  
I removed the PGP helper scripts from the package. 
Instead of installing them it suggests another package (pinepgp). 
>Unformatted:

 reed changed to notbeing confidential on 07/May/2004 so
 the gnats webpage could be displayed. (Which will be used
 for the URL for the pkg-vulnerabilities file.)

 Note that the pine code itself is not known to have a security
 issue; but the security issue was the add-on pgpdecode.

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.