NetBSD Problem Report #22538
Received: (qmail 28582 invoked by uid 605); 18 Aug 2003 21:42:54 -0000
Message-Id: <200308182141.h7ILfaS25462@watcher.eis.cs.tu-bs.de>
Date: Mon, 18 Aug 2003 23:41:36 +0200 (MEST)
From: Juergen Hannken-Illjes <hannken@watcher.eis.cs.tu-bs.de>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: hannken@watcher.eis.cs.tu-bs.de
To: gnats-bugs@gnats.netbsd.org
Subject: VMWare module fails on -current (with Patch)
X-Send-Pr-Version: 3.95
>Number: 22538
>Category: pkg
>Synopsis: VMWare module fails on -current (with Patch)
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: jdolecek
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Aug 18 21:43:00 +0000 2003
>Closed-Date: Tue Aug 26 19:02:55 +0000 2003
>Last-Modified: Tue Aug 26 19:02:55 +0000 2003
>Originator: Juergen Hannken-Illjes
>Release: NetBSD 1.6W
>Organization:
net
>Environment:
System: NetBSD / i386 / 1.6W
Architecture: i386
Machine: i386
>Description:
VMWare module3 has support for the proc->lwp change of 1.6V.
This change is no longer valid.
>How-To-Repeat:
Build package and try to start it.
>Fix:
diff -u2 -r source/linuxrtc/rtc.c source/linuxrtc/rtc.c
--- source/linuxrtc/rtc.c 2003-08-18 22:12:13.000000000 +0200
+++ source/linuxrtc/rtc.c 2003-06-30 19:41:56.000000000 +0200
@@ -70,5 +70,5 @@
/* change to pass lwp rather than proc to driver entry points in 1.6V */
-#if __NetBSD_Version__ == 106220000
+#if __NetBSD_Version__ >= 106220000
#define ENTRYARG lwp
#define LWP2PROC(l) (l->l_proc)
diff -u2 -r source/vmmon/netbsd/drv.c source/vmmon/netbsd/drv.c
--- source/vmmon/netbsd/drv.c 2003-08-18 22:12:20.000000000 +0200
+++ source/vmmon/netbsd/drv.c 2003-06-30 19:41:57.000000000 +0200
@@ -81,5 +81,5 @@
/* change to pass lwp rather than proc to driver entry points in 1.6V */
-#if __NetBSD_Version__ == 106220000
+#if __NetBSD_Version__ >= 106220000
#define ENTRYARG lwp
#define LWP2PROC(l) (l->l_proc)
diff -u2 -r source/vmnet/if_hubmod.c source/vmnet/if_hubmod.c
--- source/vmnet/if_hubmod.c 2003-08-18 22:12:33.000000000 +0200
+++ source/vmnet/if_hubmod.c 2003-06-30 19:41:57.000000000 +0200
@@ -102,5 +102,5 @@
/* change to pass lwp rather than proc to driver entry points in 1.6V */
-#if __NetBSD_Version__ == 106220000
+#if __NetBSD_Version__ >= 106220000
#define ENTRYARG lwp
#define LWP2PROC(l) (l->l_proc)
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->jdolecek
Responsible-Changed-By: jdolecek
Responsible-Changed-When: Tue Aug 19 08:30:42 UTC 2003
Responsible-Changed-Why:
I take care of the vmware3 module.
From: Jaromir Dolecek <jdolecek@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/22538 CVS commit: othersrc/vmware-modules/source
Date: Tue, 19 Aug 2003 08:40:29 +0000 (UTC)
Module Name: othersrc
Committed By: jdolecek
Date: Tue Aug 19 08:40:28 UTC 2003
Modified Files:
othersrc/vmware-modules/source/linuxrtc: rtc.c
othersrc/vmware-modules/source/vmmon/netbsd: drv.c
othersrc/vmware-modules/source/vmnet: if_hubmod.c
Log Message:
Only activate the proc->lwp macros for 1.6V; the change was backed out
later. Leave in place since some of this would be needed later.
Patch supplied in PR pkg/22538 by Juergen Hannken-Illjes
To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 othersrc/vmware-modules/source/linuxrtc/rtc.c
cvs rdiff -r1.9 -r1.10 othersrc/vmware-modules/source/vmmon/netbsd/drv.c
cvs rdiff -r1.9 -r1.10 othersrc/vmware-modules/source/vmnet/if_hubmod.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: jdolecek
State-Changed-When: Sun Aug 24 15:54:10 UTC 2003
State-Changed-Why:
The package was updated to vmware-module3 3.2.1.3, which fixes
the issue the way you proposed. Thanks for patch and report.
State-Changed-From-To: closed->analyzed
State-Changed-By: jdolecek
State-Changed-When: Sun Aug 24 18:58:49 UTC 2003
State-Changed-Why:
There are some remaining issues.
From: Jaromir Dolecek <jdolecek@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/22538 CVS commit: pkgsrc/emulators/vmware-module3
Date: Tue, 26 Aug 2003 19:01:53 +0000 (UTC)
Module Name: pkgsrc
Committed By: jdolecek
Date: Tue Aug 26 19:01:52 UTC 2003
Modified Files:
pkgsrc/emulators/vmware-module3: Makefile distinfo
Log Message:
Update to 3.2.1.4, which actually compiles and works fine without
my noncommitted LKM changes.
Pointed out by Juergen Hannken-Illjes in private e-mail, adresses
PR pkg/22538.
To generate a diff of this commit:
cvs rdiff -r1.13 -r1.14 pkgsrc/emulators/vmware-module3/Makefile
cvs rdiff -r1.6 -r1.7 pkgsrc/emulators/vmware-module3/distinfo
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: analyzed->closed
State-Changed-By: jdolecek
State-Changed-When: Tue Aug 26 19:02:06 UTC 2003
State-Changed-Why:
Version 3.2.1.4 of the vmware-module3 was confirmed compilable and
working, so this problem is solved. Thanks for feedback and testing.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.