NetBSD Problem Report #22562

Received: (qmail 9668 invoked by uid 605); 21 Aug 2003 21:13:10 -0000
Message-Id: <14795-1061500391@rainier.reedmedia.net>
Date: Thu, 21 Aug 2003 14:13:11 -0700
From: reed@reedmedia.net
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: reed@reedmedia.net
To: gnats-bugs@gnats.netbsd.org
Subject: pkgdiff should install man pages
X-Send-Pr-Version: 3.95

>Number:         22562
>Category:       pkg
>Synopsis:       pkgdiff should install man pages
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 21 21:14:00 +0000 2003
>Closed-Date:    Mon Sep 15 16:16:55 +0000 2003
>Last-Modified:  Mon Sep 15 16:17:03 +0000 2003
>Originator:     
>Release:        NetBSD 1.6.1_STABLE
>Organization:
http://bsd.reedmedia.net/
>Environment:


System: NetBSD rainier.reedmedia.net 1.6.1_STABLE NetBSD 1.6.1_STABLE (GENERIC) #0: Tue Aug 12 02:52:57 PDT 2003 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
pkgsrc/pkgtools/pkgdiff wants to use the MANINSTALL.
But on some systems (like those using pkgsrc/devel/mk-files) may not
have that defined.
So the manual pages are not installed.
(Also, not tested, but the Makefile sets it to nothing if on SunOS too.)
The PLIST is not dynamic so it still thinks the manual pages are installed.

Also with some versions of NetBSD's make, the check like:

!empty(MANINSTALL:Mcatinstall)

will fail, please use:

Index: pkgtools/pkgdiff/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkgdiff/Makefile,v
retrieving revision 1.39
diff -b -u -r1.39 Makefile
--- pkgtools/pkgdiff/Makefile	2003/07/17 22:52:17	1.39
+++ pkgtools/pkgdiff/Makefile	2003/08/21 21:11:39
@@ -44,7 +44,7 @@
 		< ${FILESDIR}/pkgdiff			\
 		> ${WRKSRC}/pkgdiff
 	${CP} ${FILESDIR}/pkgvi ${WRKSRC}
-.if !empty(MANINSTALL:Mcatinstall)
+.if defined(MANISTALL) && !empty(MANINSTALL:Mcatinstall)
 .  for FILE in mkpatches patchdiff pkgdiff pkgvi
 	${NROFF} -mandoc ${FILESDIR}/${FILE}.1 >${WRKSRC}/${FILE}.0
 .  endfor
@@ -53,10 +53,10 @@
 do-install:
 .for FILE in mkpatches patchdiff pkgdiff pkgvi
 	${INSTALL_SCRIPT} ${WRKSRC}/${FILE} ${PREFIX}/bin
-.   if !empty(MANINSTALL:Mcatinstall)
+.   if defined(MANINSTALL) && !empty(MANINSTALL:Mcatinstall)
 	${INSTALL_MAN} ${WRKSRC}/${FILE}.0 ${PREFIX}/man/cat1
 .   endif
-.   if !empty(MANINSTALL:Mmaninstall)
+.   if defined(MANINSTALL) && !empty(MANINSTALL:Mmaninstall)
 	${INSTALL_MAN} ${FILESDIR}/${FILE}.1 ${PREFIX}/man/man1
 .   endif
 .endfor

>How-To-Repeat:

>Fix:
Always install the man pages.

Maybe make the cat pages optional.

No patch provided at this time.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jmmv 
State-Changed-When: Mon Sep 15 15:45:12 UTC 2003 
State-Changed-Why:  
Fixed, thanks. 

From: "Julio M. Merino Vidal" <jmmv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/22562 CVS commit: pkgsrc/mk
Date: Mon, 15 Sep 2003 16:14:19 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	jmmv
 Date:		Mon Sep 15 16:14:18 UTC 2003

 Modified Files:
 	pkgsrc/mk: bsd.pkg.mk

 Log Message:
 Do not rely on MANINSTALL beeing set (it's always set now) to do manpage
 automatic handling.  Fixes part of PR pkg/22562 by reed@reedmedia.net.


 To generate a diff of this commit:
 cvs rdiff -r1.1285 -r1.1286 pkgsrc/mk/bsd.pkg.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: "Julio M. Merino Vidal" <jmmv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/22562 CVS commit: pkgsrc/pkgtools/pkgdiff
Date: Mon, 15 Sep 2003 16:16:41 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	jmmv
 Date:		Mon Sep 15 16:16:41 UTC 2003

 Modified Files:
 	pkgsrc/pkgtools/pkgdiff: Makefile

 Log Message:
 Add MANINSTALL to BUILD_DEFS.  With latest changes in bsd.pkg.mk, manual
 page handling is automatic when MANINSTALL is not defined; this closes
 PR pkg/22562 by reed@reedmedia.net.


 To generate a diff of this commit:
 cvs rdiff -r1.40 -r1.41 pkgsrc/pkgtools/pkgdiff/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.