NetBSD Problem Report #23151

Received: (qmail 24488 invoked by uid 605); 13 Oct 2003 17:29:53 -0000
Message-Id: <200310131729.h9DHT845002461@crusoe.naobsd.org>
Date: Tue, 14 Oct 2003 02:29:08 +0900 (JST)
From: naoki@fukaumi.org
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: naoki@fukaumi.org
To: gnats-bugs@gnats.netbsd.org
Subject: ath(4) multicast filter is broken
X-Send-Pr-Version: 3.95

>Number:         23151
>Category:       kern
>Synopsis:       ath(4) multicast filter is broken
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    enami
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 13 17:30:00 +0000 2003
>Closed-Date:    Thu Oct 23 07:20:04 +0000 2003
>Last-Modified:  Thu Oct 23 07:20:04 +0000 2003
>Originator:     FUKAUMI Naoki
>Release:        NetBSD 1.6ZC
>Organization:
	FUKAUMI Naoki
>Environment:
>Description:
	ath(4) multicast filter is broken.

	I can output a packet via ath0. but I can NOT get any packet
	from ath0 (incl broadcast packet).

	With ath_debug=1, I got this message,
	> ath_mode_init: RX filter 0x17, MC filter 00000000:00000000
	I thought MC filter is not setup correctly.

	ath.c::ath_mcastfilter_*() may be wrong.
>How-To-Repeat:
	Use ath(4).
>Fix:
	This is very dirty patch. But it solves my problem.
	(It sets MC filter to ffffffff:ffffffff)
Index: ath.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/ath.c,v
retrieving revision 1.2
diff -u -r1.2 ath.c
--- ath.c	2003/10/13 05:34:30	1.2
+++ ath.c	2003/10/13 17:10:06
@@ -311,7 +311,7 @@
 	}

 	ifp->if_softc = sc;
-	ifp->if_flags = IFF_SIMPLEX | IFF_BROADCAST | IFF_MULTICAST;
+	ifp->if_flags = IFF_SIMPLEX | IFF_BROADCAST | IFF_MULTICAST | IFF_ALLMULTI;
 	ifp->if_start = ath_start;
 	ifp->if_watchdog = ath_watchdog;
 	ifp->if_ioctl = ath_ioctl;
>Release-Note:
>Audit-Trail:

From: enami tsugutomo <enami@sm.sony.co.jp>
To: naoki@fukaumi.org
Cc: gnats-bugs@gnats.netbsd.org, dyoung@netbsd.org
Subject: Re: kern/23151: ath(4) multicast filter is broken
Date: 14 Oct 2003 16:39:19 +0900

 naoki@fukaumi.org writes:

 > 	With ath_debug=1, I got this message,
 > 	> ath_mode_init: RX filter 0x17, MC filter 00000000:00000000
 > 	I thought MC filter is not setup correctly.

 This is probably because ether_{add,del}multi() is never called.  The
 comment in SIOC{ADD,DEL}MULTI is not ture on NetBSD.

 Also, IFF_ALLMULTI handling in current ath(4) driver needs to be
 fixed.  On NetBSD, only each driver is responsible to set/clear
 IFF_ALLMULTI (testing the bit is incorrect).

 enami.

From: enami tsugutomo <enami@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/23151 CVS commit: src/sys/dev/ic
Date: Wed, 15 Oct 2003 03:04:03 +0000 (UTC)

 Module Name:	src
 Committed By:	enami
 Date:		Wed Oct 15 03:04:03 UTC 2003

 Modified Files:
 	src/sys/dev/ic: ath.c

 Log Message:
 Port multicast handling to NetBSD.  Addresses PR23151.


 To generate a diff of this commit:
 cvs rdiff -r1.4 -r1.5 src/sys/dev/ic/ath.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: enami tsugutomo <enami@sm.sony.co.jp>
To: naoki@fukaumi.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: kern/23151: ath(4) multicast filter is broken
Date: 15 Oct 2003 12:38:30 +0900

 naoki@fukaumi.org writes:

 > 	With ath_debug=1, I got this message,
 > 	> ath_mode_init: RX filter 0x17, MC filter 00000000:00000000
 > 	I thought MC filter is not setup correctly.

 Please try ath.c rev. 1.5.

 enami.

From: naoki@fukaumi.org
To: enami tsugutomo <enami@sm.sony.co.jp>
Cc: naoki@fukaumi.org, gnats-bugs@gnats.netbsd.org
Subject: Re: kern/23151: ath(4) multicast filter is broken
Date: Sun, 19 Oct 2003 02:04:42 +0900

 At 15 Oct 2003 12:38:30 +0900,
 enami tsugutomo wrote:
 > > 	With ath_debug=1, I got this message,
 > > 	> ath_mode_init: RX filter 0x17, MC filter 00000000:00000000
 > > 	I thought MC filter is not setup correctly.
 > 
 > Please try ath.c rev. 1.5.

 Thanks. But some multicast filter related bugs still remain in rev 1.5.

 IPv6 link local address is not set unless interface is in promiscuous
 mode.

 I'll try more recent source.

 Regards,

 --
 FUKAUMI Naoki

From: enami tsugutomo <enami@sm.sony.co.jp>
To: naoki@fukaumi.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: kern/23151: ath(4) multicast filter is broken
Date: 20 Oct 2003 10:50:49 +0900

 naoki@fukaumi.org writes:

 > Thanks. But some multicast filter related bugs still remain in rev 1.5.
 > 
 > IPv6 link local address is not set unless interface is in promiscuous
 > mode.
 > 
 > I'll try more recent source.

 Ya, there was a bug in 1.5.  Try rev 1.8 or newer.

 enami.

From: naoki@fukaumi.org
To: enami tsugutomo <enami@sm.sony.co.jp>
Cc: naoki@fukaumi.org, gnats-bugs@gnats.netbsd.org
Subject: Re: kern/23151: ath(4) multicast filter is broken
Date: Thu, 23 Oct 2003 01:34:14 +0900

 At 20 Oct 2003 10:50:49 +0900,
 enami tsugutomo wrote:
 > naoki@fukaumi.org writes:
 > 
 > > Thanks. But some multicast filter related bugs still remain in rev 1.5.
 > > 
 > > IPv6 link local address is not set unless interface is in promiscuous
 > > mode.
 > > 
 > > I'll try more recent source.
 > 
 > Ya, there was a bug in 1.5.  Try rev 1.8 or newer.

 All bugs that I got are resolved.

 Thank you!

 --
 FUKAUMI Naoki
State-Changed-From-To: open->closed 
State-Changed-By: enami 
State-Changed-When: Thu Oct 23 07:18:03 UTC 2003 
State-Changed-Why:  
bug is fixed with changes in ath.c rev 1.5 and 1.8 
thanks for the report. 


Responsible-Changed-From-To: kern-bug-people->enami 
Responsible-Changed-By: enami 
Responsible-Changed-When: Thu Oct 23 07:18:03 UTC 2003 
Responsible-Changed-Why:  
i've commited the both fix. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.