NetBSD Problem Report #23461

Received: (qmail 12838 invoked by uid 605); 16 Nov 2003 22:08:23 -0000
Message-Id: <20031116220820.6D428569B@localhost>
Date: Sun, 16 Nov 2003 23:08:20 +0100 (CET)
From: Christian Biere <christianbiere@gmx.de>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: Christian Biere <christianbiere@gmx.de>
To: gnats-bugs@gnats.netbsd.org
Subject: security/john overwrites compiler flags
X-Send-Pr-Version: 3.95

>Number:         23461
>Category:       pkg
>Synopsis:       security/john overwrites compiler flags
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 16 22:09:00 +0000 2003
>Closed-Date:    Tue Nov 18 14:06:40 +0000 2003
>Last-Modified:  Tue Nov 18 14:06:40 +0000 2003
>Originator:     Christian Biere <christianbiere@gmx.de>
>Release:        NetBSD 1.6ZE
>Organization:
>Environment:
System: NetBSD cyclonus 1.6ZE NetBSD 1.6ZE (STARSCREAM) #5: Sat Nov 15 01:35:55 CET 2003 bin@cyclonus:/usr/build/sys/arch/i386/compile/STARSCREAM i386
Architecture: i386
Machine: i386
>Description:

The package security/john uses a very unflexible Makefile and it will
not use CFLAGS etc. from /etc/mk.conf because they hardcoded in the Makefile.
For easier fine-tuning, I suggest removing these hardcoded settings.

>How-To-Repeat:
>Fix:

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/john/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo	2001/04/19 15:40:32	1.2
+++ distinfo	2003/11/16 21:58:28
@@ -2,3 +2,4 @@

 SHA1 (john-1.6.tar.gz) = b49d371496b8ba5e439665b83190b1e4d4640bea
 Size (john-1.6.tar.gz) = 497341 bytes
+SHA1 (patch-aa) = 5bfea91c84b982239a4bd9264228be2d47e9745d


--- Makefile	1998-12-03 01:29:50.000000000 +0100
+++ Makefile	2003-11-16 04:42:05.000000000 +0100
@@ -13,10 +13,10 @@
 SED = sed
 NULL = /dev/null
 CPPFLAGS = -E
-CFLAGS = -c -Wall -O2 -fomit-frame-pointer
+CFLAGS += -c
 ASFLAGS = -c
 LDFLAGS = -s
-OPT_NORMAL = -funroll-loops
+OPT_NORMAL =
-OPT_INLINE = -finline-functions
+OPT_INLINE =

 JOHN_VERSION = 1.6
>Release-Note:
>Audit-Trail:

From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/23461 CVS commit: pkgsrc/security/john
Date: Tue, 18 Nov 2003 14:03:14 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	xtraeme
 Date:		Tue Nov 18 14:03:14 UTC 2003

 Modified Files:
 	pkgsrc/security/john: Makefile distinfo
 Added Files:
 	pkgsrc/security/john/patches: patch-aa

 Log Message:
 Remove harcoded CFLAGS from Makefile, pass our CFLAGS instead.
 Patch provided by Christian Biere in PR pkg/23461.

 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -r1.2 -r1.3 pkgsrc/security/john/Makefile \
     pkgsrc/security/john/distinfo
 cvs rdiff -r0 -r1.1 pkgsrc/security/john/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: xtraeme 
State-Changed-When: Tue Nov 18 14:06:21 UTC 2003 
State-Changed-Why:  
Commited, thanks. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.