NetBSD Problem Report #23542

Received: (qmail 20729 invoked by uid 605); 23 Nov 2003 07:33:42 -0000
Message-Id: <20031123073339.28816.qmail@blef.org>
Date: 23 Nov 2003 07:33:39 -0000
From: snj@pobox.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: snj@pobox.com
To: gnats-bugs@gnats.netbsd.org
Subject: mail/mailagent misuses dirname and id
X-Send-Pr-Version: 3.95

>Number:         23542
>Category:       pkg
>Synopsis:       mail/mailagent misuses dirname and id
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    salo
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 23 07:34:00 +0000 2003
>Closed-Date:    Sun Nov 23 07:41:49 +0000 2003
>Last-Modified:  Sun Nov 23 07:42:00 +0000 2003
>Originator:     Soren Jacobsen
>Release:        NetBSD 1.6.1
>Organization:
>Environment:
pkgsrc as of 11/20/2003.
>Description:
${DIRNAME} and ${ID} are the correct programs to use.
>How-To-Repeat:
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/mailagent/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- Makefile	2002/07/02 11:37:33	1.9
+++ Makefile	2003/11/23 07:32:11
@@ -21,7 +21,7 @@
 			-Dutmp='/var/run/utmp' \
 			-Dprefix='${PREFIX}' -Dmansrc='${PREFIX}/man/man1' \
 			-Dnotifypatches='false'
-MAKE_ENV=		PATH=`dirname ${PERL5}`:${PATH}
+MAKE_ENV=		PATH=`${DIRNAME} ${PERL5}`:${PATH}
 INSTALL_TARGET=		install install.man

 pre-extract:
@@ -29,7 +29,7 @@
 	  ${ECHO} "Please set umask to 022 before running make,"; \
 	  ${ECHO} "or mailagent will not build successfully."; \
 	  ${FALSE}; fi
-	@if [ `id -u` = 0 ]; then \
+	@if [ `${ID} -u` = 0 ]; then \
 	  ${ECHO} "Do not build mailagent as root or it won't pass the sanity tests."; \
 	  ${FALSE}; fi

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: salo 
State-Changed-When: Sun Nov 23 07:41:31 UTC 2003 
State-Changed-Why:  
fixed, thanks. 


Responsible-Changed-From-To: pkg-manager->salo 
Responsible-Changed-By: salo 
Responsible-Changed-When: Sun Nov 23 07:41:31 UTC 2003 
Responsible-Changed-Why:  

From: Lubomir Sedlacik <salo@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/23542 CVS commit: pkgsrc/mail/mailagent
Date: Sun, 23 Nov 2003 07:41:19 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	salo
 Date:		Sun Nov 23 07:41:19 UTC 2003

 Modified Files:
 	pkgsrc/mail/mailagent: Makefile

 Log Message:
 dirname -> ${DIRNAME}, id -> ${ID}
 From Soren Jacobsen via PR pkg/23542.


 To generate a diff of this commit:
 cvs rdiff -r1.9 -r1.10 pkgsrc/mail/mailagent/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.