NetBSD Problem Report #23640

Received: (qmail 27073 invoked by uid 605); 3 Dec 2003 21:03:55 -0000
Message-Id: <20031203210353.E9C5833EB3@sanctum.takilma.net>
Date: Wed,  3 Dec 2003 13:03:53 -0800 (PST)
From: collver1@comcast.net
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: collver1@comcast.net
To: gnats-bugs@gnats.netbsd.org
Subject: remove mktemp() from security/tripwire
X-Send-Pr-Version: 3.95

>Number:         23640
>Category:       pkg
>Synopsis:       remove mktemp() from security/tripwire
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ben
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 03 21:04:00 +0000 2003
>Closed-Date:    Fri Dec 05 05:44:54 +0000 2003
>Last-Modified:  Fri Dec 05 05:44:54 +0000 2003
>Originator:     
>Release:        NetBSD 1.6ZF
>Organization:
NetBSD: It's everywhere you want to be.
>Environment:
System: NetBSD sanctum 1.6ZF NetBSD 1.6ZF (SANCTUM) #1: Tue Dec 2 23:04:28 PST 2003 root@sanctum:/usr/src/sys/arch/i386/compile/SANCTUM i386
Architecture: i386
Machine: i386
>Description:
	tripwire still uses mktemp(), which the NetBSD man page suggests
	avoiding.  The referenced patch from FreeBSD's tripwire12 port
	replaces mktemp() with mkstemp().
>How-To-Repeat:
>Fix:
	http://backyard.homeunix.net:8080/~ben/pkgsrc/tripwire-sans-mktemp.diff
>Release-Note:
>Audit-Trail:

From: Ben Collver <collver1@comcast.net>
To: gnats-bugs@gnats.netbsd.org
Cc: collver1@comcast.net
Subject: Re: pkg/23640: remove mktemp() from security/tripwire
Date: Wed, 3 Dec 2003 13:57:43 -0800

 There are problems with these patches.  I am working on redoing them.

 Cheers,

 Ben
 -- 
 NetBSD: It's everywhere you want to be.
Responsible-Changed-From-To: pkg-manager->ben 
Responsible-Changed-By: ben 
Responsible-Changed-When: Thu Dec 4 04:19:10 UTC 2003 
Responsible-Changed-Why:  
The patches are now ready to go, and I also fixed a typo in the PR 
s/mktemps/mkstemp/ 

Ben 

From: Ben Collver <ben@netbsd.org>
To: Masao Uebayashi <uebayasi@pultek.co.jp>
Cc: wiz@netbsd.org, uebayasi@netbsd.org, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/23640: remove mktemp() from security/tripwire]
Date: Wed, 3 Dec 2003 21:05:01 -0800

 Okay, now I am really embarassed, I can't read my own diff.  I do think I
 was modifying something else recently and had mkstemp() on my brain.
 Well, I am ambivilent about whether we use tmpnam() or mkstemp().  I used
 the FreeBSD patches because I was lazy.  Should I redo it with mkstemp()?

 Cheers,

 Ben
 -- 
 NetBSD: It's everywhere you want to be.

From: Masao Uebayashi <uebayasi@pultek.co.jp>
To: ben@netbsd.org
Cc: wiz@netbsd.org, uebayasi@netbsd.org, gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/23640: remove mktemp() from security/tripwire]
Date: Thu, 04 Dec 2003 14:24:51 +0900 (JST)

 To do things more lazily (and surely), let's keep the difference from
 the original code as small as possible.  If updating Tripwire, we will
 probably do by ourselves instead looking at FreeBSD Ports again, so
 Pkgsrc <-> FreeBSD Ports difference need not be small.  I think.

 Masao

From: Ben Collver <ben@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/23640 CVS commit: pkgsrc/security/tripwire
Date: Fri,  5 Dec 2003 05:40:32 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	ben
 Date:		Fri Dec  5 05:40:32 UTC 2003

 Modified Files:
 	pkgsrc/security/tripwire: Makefile distinfo
 	pkgsrc/security/tripwire/patches: patch-ad
 Added Files:
 	pkgsrc/security/tripwire/patches: patch-ae patch-af patch-ag patch-ah
 	    patch-ai

 Log Message:
 Replace all uses of mktemp() with mkstemp() and close PR 23640.


 To generate a diff of this commit:
 cvs rdiff -r1.16 -r1.17 pkgsrc/security/tripwire/Makefile
 cvs rdiff -r1.5 -r1.6 pkgsrc/security/tripwire/distinfo
 cvs rdiff -r1.1 -r1.2 pkgsrc/security/tripwire/patches/patch-ad
 cvs rdiff -r0 -r1.1 pkgsrc/security/tripwire/patches/patch-ae \
     pkgsrc/security/tripwire/patches/patch-af \
     pkgsrc/security/tripwire/patches/patch-ag \
     pkgsrc/security/tripwire/patches/patch-ah \
     pkgsrc/security/tripwire/patches/patch-ai

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: ben 
State-Changed-When: Fri Dec 5 05:44:17 UTC 2003 
State-Changed-Why:  
Supplied patch committed, thank you for the PR. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.