NetBSD Problem Report #24024

Received: (qmail 8127 invoked by uid 605); 8 Jan 2004 16:54:00 -0000
Message-Id: <200401081653.i08GrwZ6011839@socrates.olib.org>
Date: Thu, 8 Jan 2004 10:53:58 -0600 (CST)
From: Richard Rauch <rkr@socrates.olib.org>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: rkr@olib.org
To: gnats-bugs@gnats.netbsd.org
Subject: ...pkgsrc/games/xdoom has AMD64 problems. (patches available)
X-Send-Pr-Version: 3.95

>Number:         24024
>Category:       pkg
>Synopsis:       ...pkgsrc/games/xdoom has AMD64 problems. (patches available)
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 08 16:54:01 +0000 2004
>Closed-Date:    Sun Feb 21 16:18:15 +0000 2010
>Last-Modified:  Mon Feb 22 22:00:03 +0000 2010
>Originator:     Richard Rauch
>Release:        NetBSD 1.6ZG
>Organization:
  "I probably don't know what I'm talking about."  http://www.olib.org/~rkr/
>Environment:
System: NetBSD socrates 1.6ZG NetBSD 1.6ZG (socrates) #1: Wed Dec 31 15:24:34 CST 2003 root@socrates:/usr/netbsd/current/src/sys/arch/amd64/compile/obj.amd64/socrates amd64
Architecture: x86_64
Machine: amd64
>Description:
	On NetBSD/amd64, the xdoom game from pkgsrc does not work.

	After patching several files to deal with type-abuse
	issues (one problem was left unresolved for lack of
	enthusiasm, but it may or may not be a real problem,
	depending on whether any upper-32 bits are ever used
	in pointers), the program still does not run.

	It complains about sound (errno 22, from memory) not
	being available, and then freezes early (about 1 second
	after starting).

	The unresolved bug has to do with storing a pointer into
	an {int} variable.  Fixing it would involve changing at
	least one data structure and a number of variable types.
	Probably easy, but since I have smaller PR's with patches
	outstanding for other pkgsrc entries already, I thought
	that I'd see if there was interest before bothering deal
	with the last problem.  (I'm moreso inclined since the end
	result doesn't run anyway.)
>How-To-Repeat:
	Compile.  Doom go boom.
>Fix:
	If memory serves, the original code compiled with numerous
	warnings, and the bits that I modified looked dodgy.  I do
	not think that there were any compiler errors, though.

	The code basically assumes that {sizeof int == sizeof void *;}.
	This works for 32-bit systems like i386, but fails on AMD64
	where pointers are 64-bit.

	Most of these had fairly straightforward problems and solutions,
	I think.  One of them is a bit more involved, since it is
	tied up into a hokey method used to stitch numerous global
	variables into the appearance of some kind of order.

	Additionally, there are numerous warnings about possibly
	uninitialized variables; I did not address those as a spot-
	check suggested that they were fine, and if they were really
	problems, they would bite everyone.

	Patches for what I did are available, though collecting them
	is a pain if they aren't going to be used anytime soon.  They
	do not seem to completely fix the software, and I am not that
	deeply concerned about it.  (^&
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->garbled
Responsible-Changed-By: joerg@netbsd.org
Responsible-Changed-When: Wed, 04 Oct 2006 14:41:48 +0000
Responsible-Changed-Why:
Tim maintains games^Wxdoom.


Responsible-Changed-From-To: garbled->pkg-manager
Responsible-Changed-By: wiz@narn.netbsd.org
Responsible-Changed-When: Sat, 19 Jan 2008 09:17:27 +0000
Responsible-Changed-Why:
Maintainer reset, back to role account.


State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 21 Feb 2010 16:18:15 +0000
State-Changed-Why:
Removed xdoom; use prboom instead.
Thanks for the PR!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/24024 CVS commit: pkgsrc/games
Date: Sun, 21 Feb 2010 16:17:13 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sun Feb 21 16:17:13 UTC 2010

 Modified Files:
 	pkgsrc/games: Makefile
 Removed Files:
 	pkgsrc/games/xdoom: DESCR Makefile PLIST distinfo
 	pkgsrc/games/xdoom/patches: patch-aa patch-ab patch-ac patch-ad
 	    patch-ae patch-af patch-ag patch-ah patch-ai patch-aj patch-ak
 	    patch-al patch-am patch-an patch-ao patch-ap patch-aq patch-ar
 	    patch-as patch-at patch-au patch-av patch-aw patch-ax patch-ay
 	    patch-az patch-ba patch-bb patch-bc patch-bd patch-be

 Log Message:
 Remove xdoom, use prboom instead, which also works on 64bit machines
 (see PR 24024).


 To generate a diff of this commit:
 cvs rdiff -u -r1.329 -r1.330 pkgsrc/games/Makefile
 cvs rdiff -u -r1.2 -r0 pkgsrc/games/xdoom/DESCR pkgsrc/games/xdoom/PLIST
 cvs rdiff -u -r1.44 -r0 pkgsrc/games/xdoom/Makefile
 cvs rdiff -u -r1.16 -r0 pkgsrc/games/xdoom/distinfo
 cvs rdiff -u -r1.7 -r0 pkgsrc/games/xdoom/patches/patch-aa
 cvs rdiff -u -r1.3 -r0 pkgsrc/games/xdoom/patches/patch-ab \
     pkgsrc/games/xdoom/patches/patch-ac pkgsrc/games/xdoom/patches/patch-ad \
     pkgsrc/games/xdoom/patches/patch-ae pkgsrc/games/xdoom/patches/patch-ah \
     pkgsrc/games/xdoom/patches/patch-ap pkgsrc/games/xdoom/patches/patch-ax \
     pkgsrc/games/xdoom/patches/patch-ay
 cvs rdiff -u -r1.5 -r0 pkgsrc/games/xdoom/patches/patch-af
 cvs rdiff -u -r1.2 -r0 pkgsrc/games/xdoom/patches/patch-ag \
     pkgsrc/games/xdoom/patches/patch-ar pkgsrc/games/xdoom/patches/patch-au \
     pkgsrc/games/xdoom/patches/patch-av pkgsrc/games/xdoom/patches/patch-aw \
     pkgsrc/games/xdoom/patches/patch-az
 cvs rdiff -u -r1.4 -r0 pkgsrc/games/xdoom/patches/patch-ai
 cvs rdiff -u -r1.1 -r0 pkgsrc/games/xdoom/patches/patch-aj \
     pkgsrc/games/xdoom/patches/patch-ak pkgsrc/games/xdoom/patches/patch-al \
     pkgsrc/games/xdoom/patches/patch-am pkgsrc/games/xdoom/patches/patch-an \
     pkgsrc/games/xdoom/patches/patch-ao pkgsrc/games/xdoom/patches/patch-aq \
     pkgsrc/games/xdoom/patches/patch-as pkgsrc/games/xdoom/patches/patch-at \
     pkgsrc/games/xdoom/patches/patch-ba pkgsrc/games/xdoom/patches/patch-bb \
     pkgsrc/games/xdoom/patches/patch-bc pkgsrc/games/xdoom/patches/patch-bd \
     pkgsrc/games/xdoom/patches/patch-be

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/24024 CVS commit: pkgsrc
Date: Mon, 22 Feb 2010 21:58:48 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Mon Feb 22 21:58:48 UTC 2010

 Modified Files:
 	pkgsrc/games: Makefile
 Added Files:
 	pkgsrc/games/xdoom: DESCR Makefile PLIST distinfo
 	pkgsrc/games/xdoom/patches: patch-aa patch-ab patch-ac patch-ad
 	    patch-ae patch-af patch-ag patch-ah patch-ai patch-aj patch-ak
 	    patch-al patch-am patch-an patch-ao patch-ap patch-aq patch-ar
 	    patch-as patch-at patch-au patch-av patch-aw patch-ax patch-ay
 	    patch-az patch-ba patch-bb patch-bc patch-bd patch-be
 	pkgsrc/licenses: xdoom-license

 Log Message:
 Re-add xdoom, requested by drochner.
 Address PR 24024 by marking it as not-for-lp64platforms.


 To generate a diff of this commit:
 cvs rdiff -u -r1.330 -r1.331 pkgsrc/games/Makefile
 cvs rdiff -u -r0 -r1.4 pkgsrc/games/xdoom/DESCR pkgsrc/games/xdoom/PLIST
 cvs rdiff -u -r0 -r1.46 pkgsrc/games/xdoom/Makefile
 cvs rdiff -u -r0 -r1.18 pkgsrc/games/xdoom/distinfo
 cvs rdiff -u -r0 -r1.9 pkgsrc/games/xdoom/patches/patch-aa
 cvs rdiff -u -r0 -r1.5 pkgsrc/games/xdoom/patches/patch-ab \
     pkgsrc/games/xdoom/patches/patch-ac pkgsrc/games/xdoom/patches/patch-ad \
     pkgsrc/games/xdoom/patches/patch-ae pkgsrc/games/xdoom/patches/patch-ah \
     pkgsrc/games/xdoom/patches/patch-ap pkgsrc/games/xdoom/patches/patch-ax \
     pkgsrc/games/xdoom/patches/patch-ay
 cvs rdiff -u -r0 -r1.7 pkgsrc/games/xdoom/patches/patch-af
 cvs rdiff -u -r0 -r1.4 pkgsrc/games/xdoom/patches/patch-ag \
     pkgsrc/games/xdoom/patches/patch-ar pkgsrc/games/xdoom/patches/patch-au \
     pkgsrc/games/xdoom/patches/patch-av pkgsrc/games/xdoom/patches/patch-aw \
     pkgsrc/games/xdoom/patches/patch-az
 cvs rdiff -u -r0 -r1.6 pkgsrc/games/xdoom/patches/patch-ai
 cvs rdiff -u -r0 -r1.3 pkgsrc/games/xdoom/patches/patch-aj \
     pkgsrc/games/xdoom/patches/patch-ak pkgsrc/games/xdoom/patches/patch-al \
     pkgsrc/games/xdoom/patches/patch-am pkgsrc/games/xdoom/patches/patch-an \
     pkgsrc/games/xdoom/patches/patch-ao pkgsrc/games/xdoom/patches/patch-aq \
     pkgsrc/games/xdoom/patches/patch-as pkgsrc/games/xdoom/patches/patch-at \
     pkgsrc/games/xdoom/patches/patch-ba pkgsrc/games/xdoom/patches/patch-bb \
     pkgsrc/games/xdoom/patches/patch-bc pkgsrc/games/xdoom/patches/patch-bd \
     pkgsrc/games/xdoom/patches/patch-be
 cvs rdiff -u -r0 -r1.3 pkgsrc/licenses/xdoom-license

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search