NetBSD Problem Report #24066

Received: (qmail 3534 invoked by uid 605); 12 Jan 2004 08:35:49 -0000
Message-Id: <200401120834.i0C8YlIA007400@164lx.naobsd.org>
Date: Mon, 12 Jan 2004 17:34:47 +0900 (JST)
From: naoki@fukaumi.org
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: naoki@fukaumi.org
To: gnats-bugs@gnats.NetBSD.org
Subject: [PATCH] uaudio bug fix
X-Send-Pr-Version: 3.95

>Number:         24066
>Category:       kern
>Synopsis:       [PATCH] uaudio bug fix
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 12 08:36:00 +0000 2004
>Closed-Date:    Fri Oct 06 23:29:48 +0000 2006
>Last-Modified:  Fri Oct 06 23:29:48 +0000 2006
>Originator:     FUKAUMI Naoki
>Release:        NetBSD 1.6ZH
>Organization:
	FUKAUMI Naoki
>Environment:
System: NetBSD 164lx.naobsd.org 1.6ZH NetBSD 1.6ZH (164LX) #1: Mon Jan 12 16:54:57 JST 2004 root@164lx.naobsd.org:/usr/obj/alpha/sys/arch/alpha/compile/164LX alpha
Architecture: alpha
Machine: alpha
>Description:
	uaudio.c::uaudio_set_params() (called by audio.c::audiosetinfo())
	can't handle "setmode = 0" case correctly.

	  UGETW(sc->sc_alts[raltidx].edesc->wMaxPacketSize)
	cause invalid memory access.
>How-To-Repeat:
	attach uaudio(4) device, and run
	  % audiorecord
	then kernel is crashed very soon.

	CPU 0: fatal kernel trap:

	CPU 0    trap entry = 0x2 (memory management fault)
	CPU 0    a0         = 0x5
	CPU 0    a1         = 0x1
	CPU 0    a2         = 0x0
	CPU 0    pc         = 0xfffffc000067497c
	CPU 0    ra         = 0xfffffc00005001e4
	CPU 0    pv         = 0xfffffc0000674760
	CPU 0    curlwp    = 0xfffffc0001627500
	CPU 0        pid = 8041, comm = audiorecord
>Fix:
Index: uaudio.c
===================================================================
RCS file: /home/fun/cvsroot/NetBSD/src/sys/dev/usb/uaudio.c,v
retrieving revision 1.69
diff -u -r1.69 uaudio.c
--- uaudio.c	14 Oct 2003 13:12:19 -0000	1.69
+++ uaudio.c	12 Jan 2004 07:54:09 -0000
@@ -2517,16 +2517,16 @@
 				sc->sc_alts[i].sc_busy = 1;
 			}
 		}
-	}

-	if ((usemode & AUMODE_PLAY) /*&& paltidx != sc->sc_playchan.altidx*/) {
-		/* XXX abort transfer if currently happening? */
-		uaudio_chan_init(&sc->sc_playchan, paltidx, play, 0);
-	}
-	if ((usemode & AUMODE_RECORD) /*&& raltidx != sc->sc_recchan.altidx*/) {
-		/* XXX abort transfer if currently happening? */
-		uaudio_chan_init(&sc->sc_recchan, raltidx, rec,
-		    UGETW(sc->sc_alts[raltidx].edesc->wMaxPacketSize));
+		if ((usemode & AUMODE_PLAY) /*&& paltidx != sc->sc_playchan.altidx*/) {
+			/* XXX abort transfer if currently happening? */
+			uaudio_chan_init(&sc->sc_playchan, paltidx, play, 0);
+		}
+		if ((usemode & AUMODE_RECORD) /*&& raltidx != sc->sc_recchan.altidx*/) {
+			/* XXX abort transfer if currently happening? */
+			uaudio_chan_init(&sc->sc_recchan, raltidx, rec,
+			    UGETW(sc->sc_alts[raltidx].edesc->wMaxPacketSize));
+		}
 	}

 	DPRINTF(("uaudio_set_params: use altidx=p%d/r%d, altno=p%d/r%d\n",
>Release-Note:
>Audit-Trail:

From: naoki@fukaumi.org
To: gnats-bugs@netbsd.org
Cc:  
Subject: Re: kern/24066
Date: Mon, 12 Jan 2004 18:25:30 +0900

 Sorry, previous patch is not good. This is better...

 Index: uaudio.c
 ===================================================================
 RCS file: /home/fun/cvsroot/NetBSD/src/sys/dev/usb/uaudio.c,v
 retrieving revision 1.69
 diff -u -r1.69 uaudio.c
 --- uaudio.c	14 Oct 2003 13:12:19 -0000	1.69
 +++ uaudio.c	12 Jan 2004 09:18:16 -0000
 @@ -2519,11 +2519,11 @@
  		}
  	}

 -	if ((usemode & AUMODE_PLAY) /*&& paltidx != sc->sc_playchan.altidx*/) {
 +	if ((usemode & AUMODE_PLAY) && paltidx != -1) {
  		/* XXX abort transfer if currently happening? */
  		uaudio_chan_init(&sc->sc_playchan, paltidx, play, 0);
  	}
 -	if ((usemode & AUMODE_RECORD) /*&& raltidx != sc->sc_recchan.altidx*/) {
 +	if ((usemode & AUMODE_RECORD) && raltidx != -1) {
  		/* XXX abort transfer if currently happening? */
  		uaudio_chan_init(&sc->sc_recchan, raltidx, rec,
  		    UGETW(sc->sc_alts[raltidx].edesc->wMaxPacketSize));
State-Changed-From-To: open->feedback 
State-Changed-By: mycroft 
State-Changed-When: Wed Jul 7 20:15:05 UTC 2004 
State-Changed-Why:  
Should be fixed by uaudio.c 1.72.  Please verify. 


Responsible-Changed-From-To: kern-bug-people->mycroft 
Responsible-Changed-By: mycroft 
Responsible-Changed-When: Wed Jul 7 20:15:05 UTC 2004 
Responsible-Changed-Why:  
. 

From: "Charles M. Hannum" <mycroft@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/24066 CVS commit: src/sys/dev/usb
Date: Wed,  7 Jul 2004 20:21:06 +0000 (UTC)

 Module Name:	src
 Committed By:	mycroft
 Date:		Wed Jul  7 20:21:06 UTC 2004

 Modified Files:
 	src/sys/dev/usb: uaudio.c

 Log Message:
 Rearrange to fix a potential crash when changing parameters with audioctl and
 the device is closed.  Reported in PR 24066.


 To generate a diff of this commit:
 cvs rdiff -r1.71 -r1.72 src/sys/dev/usb/uaudio.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: mycroft->kern-bug-people
Responsible-Changed-By: wiz@netbsd.org
Responsible-Changed-When: Sun, 03 Sep 2006 01:15:34 +0000
Responsible-Changed-Why:
Back to role account, mycroft doesn't have commit access any longer.


State-Changed-From-To: feedback->closed
State-Changed-By: elad@netbsd.org
State-Changed-When: Fri, 06 Oct 2006 23:29:48 +0000
State-Changed-Why:
mycroft fixed it, feedback timeout


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.