NetBSD Problem Report #24248

Received: (qmail 8560 invoked by uid 605); 26 Jan 2004 14:13:33 -0000
Message-Id: <20040126141332.F29BE11152@narn.netbsd.org>
Date: Mon, 26 Jan 2004 14:13:32 +0000 (UTC)
From: geos@epost.de
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: georg.schwarz@freenet.de
To: gnats-bugs@gnats.NetBSD.org
Subject: in pkgsrc ${FIND} does not consistently use -print
X-Send-Pr-Version: www-1.0

>Number:         24248
>Category:       pkg
>Synopsis:       in pkgsrc ${FIND} does not consistently use -print
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    schwarz
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 26 14:14:00 +0000 2004
>Closed-Date:    Sat Oct 07 19:00:29 +0000 2006
>Last-Modified:  Sat Oct 07 19:00:29 +0000 2006
>Originator:     Georg Schwarz
>Release:        current pkgsrc
>Organization:
>Environment:
IRIX lorenz 5.3 08031225 IP20 mips
>Description:
While in most occurrences ${FIND} in the pkgsrc mk-Skripts does have -print, there are just a few instances where it doesn't: one in mk/bulk/bsd.bulk-pkg.mk, three in mk/bsd.pkg.mk. Please do a favour to users of antique UNIX systems and add those few extra characters.
In addition, mk/bulk/post-build directly uses "find" (sometimes with and sometimes without
-print!). Shouldn't that rather be ${FIND}? (and better always with -print).
>How-To-Repeat:
use a system with an find app that requires -print to yield any output
>Fix:
add those -print and change find into ${FIND}
>Release-Note:
>Audit-Trail:

From: David Brownlee <abs@absd.org>
To: geos@epost.de
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/24248: in pkgsrc ${FIND} does not consistently use -print
Date: Mon, 26 Jan 2004 15:04:34 +0000 (GMT)

 	Another option on this might be to make those systems set FIND to
 	a trivial script that appends '-print' to the list of arguments
 	then calls the real find.

 	Not the cleanest option, but might be worth considering.

 -- 
 			   David Brownlee -- abs@absd.org

From: Georg Schwarz <geos@epost.de>
To: David Brownlee <abs@absd.org>
Cc: geos@epost.de, gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/24248: in pkgsrc ${FIND} does not consistently use -print
Date: Mon, 26 Jan 2004 16:26:40 +0100 (CET)

 > 	Another option on this might be to make those systems set FIND to
 > 	a trivial script that appends '-print' to the list of arguments
 > 	then calls the real find.
 > 
 > 	Not the cleanest option, but might be worth considering.

 yes, sure it would do, just as having ${FIND} point to GNU find. This however
 I would prefer to call this a workaround, not a nice fix.
 The -print issue should be trivial to fix, it won't hurt other platforms
 (aside from the extra 7 bytes penalty :-)) and it would make pkgsrc more
 consistent (-print is already being used in numerous cases).


 -- 
 Georg Schwarz    http://home.pages.de/~schwarz/
  geos@epost.de     +49 177 8811442


From: geos@epost.de (Georg Schwarz)
To: gnats-bugs@NetBSD.org
Cc:  
Subject: Re: pkg/24248: list of further files to be fixed
Date: Mon, 26 Jan 2004 16:31:28 +0100

 As an addition to the two find issues reported earlier today here are
 two lists of some more files from pkgsrc that should get a fix:

 use '${FIND}' instead of 'find': 

 mk/bulk/pre-build
 mk/gnu-config/missing
 games/craft/Makefile


 add '-print' to FIND:

 audio/festvox-abc/Makefile
 audio/nas/Makefile
 benchmarks/bytebench/Makefile
 cad/boolean/Makefile
 comms/fidogate/Makefile (twice)
 cross/i386-msdosdjgpp/Makefile
 devel/mit-pthreads/Makefile
 devel/ptl2/Makefile (four times)
 devel/stlport/Makefile
 devel/unproven-pthreads/Makefile
 editors/emacs-nox11/Makefile
 editors/emacs/Makefile
 editors/emacs20/Makefile
 editors/xemacs/Makefile
 emulators/linux-locale/Makefile
 fonts/t1lib/Makefile
 games/craft/Makefile (two times)
 games/iso-pernangband/Makefile
 games/mirrormagic-sdl/Makefile (twice)
 games/mirrormagic/Makefile (twice)
 games/pysol/Makefile (twice)
 games/rocksndiamonds-levels/Makefile
 games/rollemup/Makefile (twice)
 games/tuxmath/Makefile
 graphics/aalib-x11/Makefile
 graphics/netpbm/Makefile (twice)
 graphics/tcm/Makefile
 graphics/urt/Makefile (and shouldn't it be ${FIND} . -d -print instead
 of ${FIND} -d . ??)
 inputmethod/canna-dict/Makefile
 inputmethod/sj3-server-bin/Makefile
 lang/bwbasic/Makefile (twice)
 lang/drscheme/Makefile
 lang/mercury/Makefile (twice)
 lang/nhc98/Makefile
 lang/sather/Makefile
 mail/wl/Makefile
 math/octave/Makefile
 misc/linuxls/Makefile
 misc/tds/Makefile
 net/p5-Wais/Makefile
 net/sitescooper/Makefile
 net/xipdump/Makefile
 security/netramet/Makefile
 sysutils/tkdesk/Makefile (once)
 textproc/dict-dictionaries/Makefile
 textproc/rtf-tools/Makefile
 textproc/troffcvt/Makefile
 textproc/xalan-c/Makefile
 wm/enlightenment/Makefile (twice)
 wm/ethemes/Makefile (twice)
 x11/kdebase/Makefile (twice)
 x11/mlterm/Makefile
 x11/py-Pmw/Makefile (twice)
 x11/rep-gtk/Makefile
 x11/xjman/Makefile (twice)
 x11/xservers/Makefile (twice)

 -- 
 Georg Schwarz    http://home.pages.de/~schwarz/
  geos@epost.de     +49 177 8811442
Responsible-Changed-From-To: pkg-manager->heinz 
Responsible-Changed-By: heinz 
Responsible-Changed-When: Mon Jan 26 20:03:43 UTC 2004 
Responsible-Changed-Why:  
I'll take care of this. 

From: Klaus Heinz <heinz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/24248 CVS commit: pkgsrc/mk
Date: Mon, 26 Jan 2004 21:10:32 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	heinz
 Date:		Mon Jan 26 21:10:32 UTC 2004

 Modified Files:
 	pkgsrc/mk: bsd.pkg.mk
 	pkgsrc/mk/bulk: bsd.bulk-pkg.mk post-build

 Log Message:
 Use $FIND with "-print". Noted by Georg Schwarz in PR pkg/24248


 To generate a diff of this commit:
 cvs rdiff -r1.1359 -r1.1360 pkgsrc/mk/bsd.pkg.mk
 cvs rdiff -r1.54 -r1.55 pkgsrc/mk/bulk/bsd.bulk-pkg.mk
 cvs rdiff -r1.27 -r1.28 pkgsrc/mk/bulk/post-build

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Klaus Heinz <heinz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/24248 CVS commit: pkgsrc
Date: Tue, 27 Jan 2004 00:53:12 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	heinz
 Date:		Tue Jan 27 00:53:12 UTC 2004

 Modified Files:
 	pkgsrc/audio/festvox-abc: Makefile
 	pkgsrc/audio/nas: Makefile
 	pkgsrc/benchmarks/bytebench: Makefile
 	pkgsrc/comms/fidogate: Makefile
 	pkgsrc/cross/i386-msdosdjgpp: Makefile
 	pkgsrc/databases/unixodbc: Makefile.common
 	pkgsrc/devel/mit-pthreads: Makefile
 	pkgsrc/devel/ptl2: Makefile
 	pkgsrc/devel/rt-mysql: Makefile.common
 	pkgsrc/devel/stlport: Makefile
 	pkgsrc/devel/unproven-pthreads: Makefile
 	pkgsrc/editors/emacs: Makefile
 	pkgsrc/editors/emacs-nox11: Makefile
 	pkgsrc/editors/emacs20: Makefile
 	pkgsrc/editors/xemacs: Makefile
 	pkgsrc/emulators/linux-locale: Makefile
 	pkgsrc/fonts/t1lib: Makefile
 	pkgsrc/games/craft: Makefile
 	pkgsrc/games/iso-pernangband: Makefile
 	pkgsrc/games/mirrormagic: Makefile
 	pkgsrc/games/mirrormagic-sdl: Makefile
 	pkgsrc/games/pysol: Makefile
 	pkgsrc/games/rocksndiamonds-levels: Makefile
 	pkgsrc/games/rollemup: Makefile
 	pkgsrc/games/tuxmath: Makefile
 	pkgsrc/graphics/aalib: Makefile.common
 	pkgsrc/graphics/aalib-x11: Makefile
 	pkgsrc/graphics/tcm: Makefile
 	pkgsrc/graphics/urt: Makefile
 	pkgsrc/inputmethod/canna-dict: Makefile
 	pkgsrc/inputmethod/ja-freewnn-lib: Makefile.common
 	pkgsrc/inputmethod/sj3-server-bin: Makefile
 	pkgsrc/lang/bwbasic: Makefile
 	pkgsrc/lang/drscheme: Makefile
 	pkgsrc/lang/mercury: Makefile
 	pkgsrc/lang/nhc98: Makefile
 	pkgsrc/lang/sather: Makefile
 	pkgsrc/mail/wl: Makefile
 	pkgsrc/math/octave: Makefile
 	pkgsrc/misc/linuxls: Makefile
 	pkgsrc/misc/tds: Makefile
 	pkgsrc/net/sitescooper: Makefile
 	pkgsrc/net/xipdump: Makefile
 	pkgsrc/print/texfamily-share: Makefile
 	pkgsrc/security/cyrus-sasl2: Makefile.common
 	pkgsrc/security/netramet: Makefile
 	pkgsrc/sysutils/tkdesk: Makefile
 	pkgsrc/textproc/dict-dictionaries: Makefile
 	pkgsrc/textproc/rtf-tools: Makefile
 	pkgsrc/textproc/troffcvt: Makefile
 	pkgsrc/textproc/xalan-c: Makefile
 	pkgsrc/wm/enlightenment: Makefile
 	pkgsrc/wm/ethemes: Makefile
 	pkgsrc/www/w3m: Makefile.common
 	pkgsrc/x11/mlterm: Makefile
 	pkgsrc/x11/py-Pmw: Makefile
 	pkgsrc/x11/rep-gtk: Makefile
 	pkgsrc/x11/xjman: Makefile
 	pkgsrc/x11/xservers: Makefile

 Log Message:
 Use $FIND with "-print". Noted by Georg Schwarz in PR pkg/24248


 To generate a diff of this commit:
 cvs rdiff -r1.16 -r1.17 pkgsrc/audio/festvox-abc/Makefile
 cvs rdiff -r1.39 -r1.40 pkgsrc/audio/nas/Makefile
 cvs rdiff -r1.13 -r1.14 pkgsrc/benchmarks/bytebench/Makefile
 cvs rdiff -r1.29 -r1.30 pkgsrc/comms/fidogate/Makefile
 cvs rdiff -r1.17 -r1.18 pkgsrc/cross/i386-msdosdjgpp/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/databases/unixodbc/Makefile.common
 cvs rdiff -r1.38 -r1.39 pkgsrc/devel/mit-pthreads/Makefile
 cvs rdiff -r1.42 -r1.43 pkgsrc/devel/ptl2/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/devel/rt-mysql/Makefile.common
 cvs rdiff -r1.14 -r1.15 pkgsrc/devel/stlport/Makefile
 cvs rdiff -r1.38 -r1.39 pkgsrc/devel/unproven-pthreads/Makefile
 cvs rdiff -r1.66 -r1.67 pkgsrc/editors/emacs/Makefile
 cvs rdiff -r1.7 -r1.8 pkgsrc/editors/emacs-nox11/Makefile
 cvs rdiff -r1.9 -r1.10 pkgsrc/editors/emacs20/Makefile
 cvs rdiff -r1.66 -r1.67 pkgsrc/editors/xemacs/Makefile
 cvs rdiff -r1.18 -r1.19 pkgsrc/emulators/linux-locale/Makefile
 cvs rdiff -r1.9 -r1.10 pkgsrc/fonts/t1lib/Makefile
 cvs rdiff -r1.12 -r1.13 pkgsrc/games/craft/Makefile
 cvs rdiff -r1.16 -r1.17 pkgsrc/games/iso-pernangband/Makefile
 cvs rdiff -r1.17 -r1.18 pkgsrc/games/mirrormagic/Makefile
 cvs rdiff -r1.9 -r1.10 pkgsrc/games/mirrormagic-sdl/Makefile
 cvs rdiff -r1.15 -r1.16 pkgsrc/games/pysol/Makefile
 cvs rdiff -r1.5 -r1.6 pkgsrc/games/rocksndiamonds-levels/Makefile
 cvs rdiff -r1.23 -r1.24 pkgsrc/games/rollemup/Makefile
 cvs rdiff -r1.7 -r1.8 pkgsrc/games/tuxmath/Makefile
 cvs rdiff -r1.13 -r1.14 pkgsrc/graphics/aalib/Makefile.common
 cvs rdiff -r1.6 -r1.7 pkgsrc/graphics/aalib-x11/Makefile
 cvs rdiff -r1.18 -r1.19 pkgsrc/graphics/tcm/Makefile
 cvs rdiff -r1.31 -r1.32 pkgsrc/graphics/urt/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/inputmethod/canna-dict/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/inputmethod/ja-freewnn-lib/Makefile.common
 cvs rdiff -r1.5 -r1.6 pkgsrc/inputmethod/sj3-server-bin/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/lang/bwbasic/Makefile
 cvs rdiff -r1.16 -r1.17 pkgsrc/lang/drscheme/Makefile
 cvs rdiff -r1.17 -r1.18 pkgsrc/lang/mercury/Makefile
 cvs rdiff -r1.26 -r1.27 pkgsrc/lang/nhc98/Makefile
 cvs rdiff -r1.14 -r1.15 pkgsrc/lang/sather/Makefile
 cvs rdiff -r1.16 -r1.17 pkgsrc/mail/wl/Makefile
 cvs rdiff -r1.42 -r1.43 pkgsrc/math/octave/Makefile
 cvs rdiff -r1.12 -r1.13 pkgsrc/misc/linuxls/Makefile
 cvs rdiff -r1.8 -r1.9 pkgsrc/misc/tds/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/net/sitescooper/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/net/xipdump/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/print/texfamily-share/Makefile
 cvs rdiff -r1.11 -r1.12 pkgsrc/security/cyrus-sasl2/Makefile.common
 cvs rdiff -r1.3 -r1.4 pkgsrc/security/netramet/Makefile
 cvs rdiff -r1.5 -r1.6 pkgsrc/sysutils/tkdesk/Makefile
 cvs rdiff -r1.2 -r1.3 pkgsrc/textproc/dict-dictionaries/Makefile
 cvs rdiff -r1.14 -r1.15 pkgsrc/textproc/rtf-tools/Makefile
 cvs rdiff -r1.9 -r1.10 pkgsrc/textproc/troffcvt/Makefile
 cvs rdiff -r1.11 -r1.12 pkgsrc/textproc/xalan-c/Makefile
 cvs rdiff -r1.19 -r1.20 pkgsrc/wm/enlightenment/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/wm/ethemes/Makefile
 cvs rdiff -r1.22 -r1.23 pkgsrc/www/w3m/Makefile.common
 cvs rdiff -r1.18 -r1.19 pkgsrc/x11/mlterm/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/x11/py-Pmw/Makefile
 cvs rdiff -r1.22 -r1.23 pkgsrc/x11/rep-gtk/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/x11/xjman/Makefile
 cvs rdiff -r1.12 -r1.13 pkgsrc/x11/xservers/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: geos@epost.de (Georg Schwarz)
To: gnats-bugs@NetBSD.org
Cc:  
Subject: Re: pkg/24248: some files left to be fixed
Date: Sun, 8 Feb 2004 20:31:45 +0100

 While it appears that most occurrences of find/FIND have been corrected
 in pkgsrc there are still three file I would like to add:

 *** mk/bulk/pre-build   Sun Feb  8 18:17:54 2004
 --- mk/bulk/pre-build.orig      Sun Feb  8 18:16:53 2004
 ***************
 *** 191,197 ****
   case "$PRUNELINKS" in
   yes|YES)
         echo "Checking for and removing orphaned packages links"
 !       ${FIND} $PACKAGES -type l -print |  \
         while read f
         do
                 if [ ! -d $f -a ! -f $f ]; then
 --- 191,197 ----
   case "$PRUNELINKS" in
   yes|YES)
         echo "Checking for and removing orphaned packages links"
 !       find $PACKAGES -type l -print |  \
         while read f
         do
                 if [ ! -d $f -a ! -f $f ]; then


 *** mk/gnu-config/missing       Sun Feb  8 18:27:28 2004
 --- mk/gnu-config/missing.orig  Sun Feb  8 18:27:11 2004
 ***************
 *** 153,159 ****
            you modified \`Makefile.am', \`acinclude.m4' or
 \`${configure_ac}'.
            You might want to install the \`Automake' and \`Perl'
 packages.
            Grab them from any GNU archive site."
 !     ${FIND} . -type f -name Makefile.am -print |
            sed 's/\.am$/.in/' |
            while read f; do touch "$f"; done
       ;;
 --- 153,159 ----
            you modified \`Makefile.am', \`acinclude.m4' or
 \`${configure_ac}'.
            You might want to install the \`Automake' and \`Perl'
 packages.
            Grab them from any GNU archive site."
 !     find . -type f -name Makefile.am -print |
            sed 's/\.am$/.in/' |
            while read f; do touch "$f"; done
       ;;


 *** ./textproc/xalan-c/Makefile Sun Feb  8 18:57:11 2004
 --- ./textproc/xalan-c/Makefile.orig    Sun Feb  8 18:56:18 2004
 ***************
 *** 36,42 ****
             ${ECHO} creating ${PREFIX}/include/$${i}; \
             ${INSTALL_DATA_DIR} ${PREFIX}/include/$${i}; \
         done; \
 !       for i in `$${FIND} $${XMLDIRS} -type f -name "*.hpp" -print`; do
 \
             ${ECHO} installing ${PREFIX}/include/$${i}; \
             ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/include/$${i}; \
         done
 --- 36,42 ----
             ${ECHO} creating ${PREFIX}/include/$${i}; \
             ${INSTALL_DATA_DIR} ${PREFIX}/include/$${i}; \
         done; \
 !       for i in `find $${XMLDIRS} -type f -name "*.hpp" -print`; do \
             ${ECHO} installing ${PREFIX}/include/$${i}; \
             ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/include/$${i}; \
         done




 -- 
 Georg Schwarz    http://home.pages.de/~schwarz/
  geos@epost.de     +49 177 8811442

From: geos@epost.de (Georg Schwarz)
To: gnats-bugs@NetBSD.org
Cc:  
Subject: Re: pkg/24248: pkgsrc/www/libwww/Makefile also affected 
Date: Sat, 13 Mar 2004 21:02:33 +0100

 pkgsrc/www/libwww/Makefile also needs a -print for ${FIND}.
From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/24248
Date: Mon, 8 May 2006 18:12:54 -0700 (PDT)

 Georg:

 Can you commit any needed few leftover find -print problems and close this 
 PR?

 Thanks!

  Jeremy C. Reed

Responsible-Changed-From-To: heinz->schwarz
Responsible-Changed-By: joerg@netbsd.org
Responsible-Changed-When: Wed, 04 Oct 2006 14:52:42 +0000
Responsible-Changed-Why:
Eat your own bugs.


State-Changed-From-To: open->feedback
State-Changed-By: joerg@netbsd.org
State-Changed-When: Wed, 04 Oct 2006 14:52:42 +0000
State-Changed-Why:
Unsure if problem still exist.


State-Changed-From-To: feedback->closed
State-Changed-By: schwarz@netbsd.org
State-Changed-When: Sat, 07 Oct 2006 19:00:29 +0000
State-Changed-Why:
all known occurrences have been corrected.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.