NetBSD Problem Report #24652

Received: (qmail 28825 invoked by uid 605); 3 Mar 2004 04:53:52 -0000
Message-Id: <20040303045348.4414611159@narn.netbsd.org>
Date: Wed,  3 Mar 2004 04:53:48 +0000 (UTC)
From: kailashsethuraman@yahoo.com.sg
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: kailashsethuraman@yahoo.com.sg
To: gnats-bugs@gnats.NetBSD.org
Subject: netinet/ip_mroute.h included twice in  sys/netinet/ip_encap.c
X-Send-Pr-Version: www-1.0

>Number:         24652
>Category:       kern
>Synopsis:       netinet/ip_mroute.h included twice in  sys/netinet/ip_encap.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          support
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 03 04:54:00 +0000 2004
>Closed-Date:    Thu Mar 04 15:15:19 +0000 2004
>Last-Modified:  Thu Mar 04 15:16:00 +0000 2004
>Originator:     Kailash Sethuraman
>Release:        NetBSD 1.6.2
>Organization:
>Environment:
NetBSD harold 1.6.2 NetBSD 1.6.2 (GENERIC_LAPTOP) #0: Tue Feb 10 22:02:37 UTC 2004     autobuild@tgm.netbsd.org:/autobuild/netbsd-1-6-PATCH002/i386/OBJ/autobuild/netbsd-1-6-PATCH002/src/sys/arch/i386/compile/GENERIC_LAPTOP i386

>Description:
 /usr/src/sys/netinet/ip_encap.c includes  <netinet/ip_mroute.h> twice.
A check on cvsweb shows this is also true for the ip_encap.c with the latest. __KERNEL_RCSID(0, "$NetBSD: ip_encap.c,v 1.15 2003/10/28 20:27:22 mycroft Exp $");
The trivial fix removes one of the 2 includes of mroute.h. 
>How-To-Repeat:

>Fix:
 diff -bu ip_encap.c.orig ip_encap.c 
--- ip_encap.c.orig     Fri Aug  2 08:34:13 2002
+++ ip_encap.c  Wed Mar  3 12:50:04 2004
@@ -107,10 +107,6 @@

 #include <machine/stdarg.h>

-#ifdef MROUTING
-#include <netinet/ip_mroute.h>
-#endif
-
 #include <net/net_osdep.h>

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: wiz 
State-Changed-When: Thu Mar 4 15:15:12 UTC 2004 
State-Changed-Why:  
Fixed, thanks. 

From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/24652 CVS commit: src/sys/netinet
Date: Thu,  4 Mar 2004 15:15:06 +0000 (UTC)

 Module Name:	src
 Committed By:	wiz
 Date:		Thu Mar  4 15:15:06 UTC 2004

 Modified Files:
 	src/sys/netinet: ip_encap.c

 Log Message:
 No need to include netinet/ip_mroute.h twice.
 Closes PR 24652 by Kailash Sethuraman.


 To generate a diff of this commit:
 cvs rdiff -r1.16 -r1.17 src/sys/netinet/ip_encap.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.