NetBSD Problem Report #24723

Received: (qmail 4549 invoked by uid 605); 9 Mar 2004 21:57:01 -0000
Message-Id: <200403092156.i29LuxbG026822@cuw.ojctech.com>
Date: Tue, 9 Mar 2004 15:56:59 -0600 (CST)
From: bdcribbs@ojctech.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: bdcribbs@ojctech.com
To: gnats-bugs@gnats.NetBSD.org
Subject: makefs -s and blocksize
X-Send-Pr-Version: 3.95

>Number:         24723
>Category:       bin
>Synopsis:       makefs -s and blocksize
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 09 21:58:00 +0000 2004
>Closed-Date:    
>Last-Modified:  Sun Mar 21 21:15:45 +0000 2004
>Originator:     Bryan Cribbs
>Release:        NetBSD 1.6ZJ
>Organization:
>Environment:
System: NetBSD cuw.ojctech.com 1.6ZJ NetBSD 1.6ZJ (GENERIC.pcibios) #7: Fri Feb 20 20:24:13 CST 2004 dyoung@cuw.ojctech.com:/u1/dyoung/pristine-nbsd/O/sys/arch/i386/compile/GENERIC.pcibios i386
Architecture: i386
Machine: i386
>Description:

If one uses the -s flag to makefs and specifies a size that is not 
evenly divisible by the blocksize, makefs is guaranteed to fail.

From checking out the source I found this happens because: 
  fsopts->minsize = fsopts->maxsize = arg to -s
and in the last steps of ffs_validate():
 - make sure size is at least minsize 
 - round up to the next block 
 - check that size is not greater then maxsize 

I'm not sure if this behaviour should be considered a bug.
At the least, the error message ("size of xxx greater than maxsize") 
is misleading in this case.

>How-To-Repeat:

>Fix:



>Release-Note:
>Audit-Trail:
>Unformatted:
 $NetBSD: ffs.c,v 1.25 2003/10/26

Home	PR Database Search