NetBSD Problem Report #25259

Received: (qmail 29626 invoked by uid 605); 20 Apr 2004 16:11:29 -0000
Message-Id: <20040420161127.0E5A6FC26@firefly.localdomain>
Date: Wed, 21 Apr 2004 01:11:27 +0900 (JST)
From: hira@po6.nsk.ne.jp
Sender: gnats-bugs-owner@NetBSD.org
To: gnats-bugs@gnats.NetBSD.org
Subject: extra `$' in pkgtools/pkg_tarup
X-Send-Pr-Version: 3.95

>Number:         25259
>Category:       pkg
>Synopsis:       extra `$' in pkgtools/pkg_tarup
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 20 16:12:00 +0000 2004
>Closed-Date:    Tue Apr 20 16:41:30 +0000 2004
>Last-Modified:  Tue Apr 20 16:41:30 +0000 2004
>Originator:     Kouichirou Hiratsuka
>Release:        NetBSD 2.0_BETA
>Organization:
>Environment:
System: NetBSD firefly.localdomain 2.0_BETA NetBSD 2.0_BETA (FIREFLY.MP) #11: Sun Apr 18 19:26:24 JST 2004 root@firefly.localdomain:/usr/src/sys/arch/i386/compile/FIREFLY.MP i386
Architecture: i386
Machine: i386
>Description:
	When the pkgtools/pkg_tarup is used by a non-root user, it fails to
	execute the awk(1).

% pkg_tarup mozilla-gtk2
Becoming root@firefly.localdomain to create a binary package
/usr/bin/awk: illegal field $(/usr/bin/su), name "1"
 input record number 1, file
 source line number 1
 Password:

>How-To-Repeat:
	cd ${PKGSRCDIR}/pkgtools/pkg_tarup
	make && make install
	pkg_tarup <installed package>

>Fix:
Index: files/pkg_tarup
===================================================================
RCS file: /cvs/cvsroot/pkgsrc/pkgtools/pkg_tarup/files/pkg_tarup,v
retrieving revision 1.11
diff -u -r1.11 pkg_tarup
--- files/pkg_tarup	11 Dec 2003 16:29:08 -0000	1.11
+++ files/pkg_tarup	20 Apr 2004 15:22:34 -0000
@@ -24,7 +24,7 @@

 if [ `${ID} -u` != 0 ]; then
 	${ECHO} "Becoming root@`/bin/hostname` to create a binary package"
-	${ECHO} -n "`${ECHO} ${SU} | ${AWK} '{ print $$1 }'` ";\
+	${ECHO} -n "`${ECHO} ${SU} | ${AWK} '{ print $1 }'` ";\
 	exec ${SU} root -c "$0 $@"
 fi

Index: files/pkg_tarup_all
===================================================================
RCS file: /cvs/cvsroot/pkgsrc/pkgtools/pkg_tarup/files/pkg_tarup_all,v
retrieving revision 1.2
diff -u -r1.2 pkg_tarup_all
--- files/pkg_tarup_all	16 Sep 2003 23:19:47 -0000	1.2
+++ files/pkg_tarup_all	20 Apr 2004 15:24:02 -0000
@@ -21,7 +21,7 @@

 if [ `${ID} -u` != 0 ]; then
 	${ECHO} "Becoming root@`/bin/hostname` to create binary packages"
-	${ECHO} -n "`${ECHO} ${SU} | ${AWK} '{ print $$1 }'` ";\
+	${ECHO} -n "`${ECHO} ${SU} | ${AWK} '{ print $1 }'` ";\
 	exec ${SU} root -c "$0 $@"
 fi

>Release-Note:
>Audit-Trail:

From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/25259 CVS commit: pkgsrc/pkgtools/pkg_tarup
Date: Tue, 20 Apr 2004 16:26:07 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue Apr 20 16:26:07 UTC 2004

 Modified Files:
 	pkgsrc/pkgtools/pkg_tarup: Makefile
 	pkgsrc/pkgtools/pkg_tarup/files: pkg_tarup pkg_tarup_all

 Log Message:
 1.5.2: Use proper number of dollars for variable.
 Reported by Kouichirou Hiratsuka in PR 25259.


 To generate a diff of this commit:
 cvs rdiff -r1.18 -r1.19 pkgsrc/pkgtools/pkg_tarup/Makefile
 cvs rdiff -r1.11 -r1.12 pkgsrc/pkgtools/pkg_tarup/files/pkg_tarup
 cvs rdiff -r1.2 -r1.3 pkgsrc/pkgtools/pkg_tarup/files/pkg_tarup_all

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: wiz 
State-Changed-When: Tue Apr 20 16:41:24 UTC 2004 
State-Changed-Why:  
Committed, thanks. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.