NetBSD Problem Report #25539

Received: (qmail 22305 invoked by uid 605); 11 May 2004 20:39:14 -0000
Message-Id: <1084307950.327438.638.nullmailer@yamt.dyndns.org>
Date: Wed, 12 May 2004 05:39:10 +0900
From: yamt@mwd.biglobe.ne.jp
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: yamt@mwd.biglobe.ne.jp
To: gnats-bugs@gnats.netbsd.org
Subject: nfsd exclusive CREATE rpc handling is improper
X-Send-Pr-Version: 3.95

>Number:         25539
>Category:       kern
>Synopsis:       nfsd exclusive CREATE rpc handling is improper
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 11 20:40:00 +0000 2004
>Closed-Date:    
>Last-Modified:  
>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release:        NetBSD 2.0E
>Organization:

>Environment:


System: NetBSD kaeru 2.0E NetBSD 2.0E (build.kaeru) #1287: Tue May 11 20:24:01 JST 2004 takashi@kaeru:/home/takashi/work/kernel/build.kaeru i386
Architecture: i386
Machine: i386
>Description:
	1) our nfsd handles nfsv3 exclusive CREATE rpcs as the following.
		1. VOP_CREATE
		2. VOP_SETATTR with the given create verf.

	there's no way to avoid improper EEXIST
	if the server crashes between 1 and 2.

	2) our nfsd uses atime for a create verf.  however,
	   atime doesn't have enough bits for create verf.
	   note that -1 (== VNOVAL) is valid value for create verf.

>How-To-Repeat:
	code inspection.
>Fix:
	1) change VOP_CREATE to use the given vattr as an initial attribute.
	2) repeal VNOVAL and use bitmap to specify validity of fields instead.

>Release-Note:
>Audit-Trail:
>Unformatted:

Home	PR Database Search