NetBSD Problem Report #25551

Received: (qmail 14474 invoked by uid 605); 12 May 2004 21:36:53 -0000
Message-Id: <20040512213648.50F5114401@tiamat.goathill.org>
Date: Wed, 12 May 2004 16:36:48 -0500 (CDT)
From: mlh@goathill.org
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: mlh@goathill.org
To: gnats-bugs@gnats.NetBSD.org
Subject: sort - doesn't sort reverse numeric keys correctly
X-Send-Pr-Version: 3.95

>Number:         25551
>Category:       bin
>Synopsis:       sort - doesn't sort reverse numeric keys correctly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jdolecek
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 12 21:37:00 +0000 2004
>Closed-Date:    Sat Aug 22 11:14:33 +0000 2009
>Last-Modified:  Wed Oct 14 20:45:03 +0000 2009
>Originator:     MLH
>Release:        NetBSD 2.0E
>Organization:
none

>Environment:


System: NetBSD enki.goathill.org 2.0E NetBSD 2.0E (GENERIC.MP) #0: Thu May 6 16:36:24 CDT 2004 build@enki.goathill.org:/opt/obj/i386/opt/src/sys/arch/i386/compile/GENERIC.MP i386
Architecture: i386
Machine: i386
>Description:

Reverse numeric sorts don't appear to handle empty strings consistently. 
The first key appears correct but subsequent keys don't.

I can't determine that changing the weighting table can fix this and
I can't determine what the difference is between how the first key
is handled and the second key. I would appreciate some assistance with
fixing this.

>How-To-Repeat:
$ cat testsort

      0.0
      1.0
  0.0
  0.0 0.0
  0.0 1.0
  1.0
  1.0 0.0
  1.0 1.0
------------------------
Forward numeric (and nonnumeric) 2nd keys sort correctly:
$ sort -t: -k1.6n,1.9 -k1.1n,1.5 testsort

  0.0
  1.0
      0.0
  0.0 0.0
  1.0 0.0
      1.0
  0.0 1.0
  1.0 1.0
$ sort -t: -k1.6n,1.9 -k1.1,1.5 testsort

  0.0
  1.0
      0.0
  0.0 0.0
  1.0 0.0
      1.0
  0.0 1.0
  1.0 1.0
-------------------------
Reverse numeric first key sorts correctly but not second key:
$ sort -t: -k1.6rn,1.9 -k1.1r,1.5 testsort
  1.0 1.0
  0.0 1.0
      1.0
  1.0 0.0
  0.0 0.0
      0.0
  1.0
  0.0

-------------------------
Reverse numeric first key and reverse nonnumeric second key sorts correctly :
$ sort -t: -k1.6rn,1.9 -k1.1,1.5 testsort
      1.0
  0.0 1.0
  1.0 1.0
      0.0
  0.0 0.0
  1.0 0.0

  0.0
  1.0

>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: bin-bug-people->jdolecek 
Responsible-Changed-By: jdolecek 
Responsible-Changed-When: Fri May 14 20:35:38 UTC 2004 
Responsible-Changed-Why:  
I take care of sort(1). 
From: David Laight <dsl@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/25551 CVS commit: src/usr.bin/sort
Date: Sat, 22 Aug 2009 10:53:29 +0000

 Module Name:	src
 Committed By:	dsl
 Date:		Sat Aug 22 10:53:28 UTC 2009

 Modified Files:
 	src/usr.bin/sort: append.c fields.c files.c fsort.c init.c msort.c
 	    sort.c sort.h

 Log Message:
 Rework the way sort generates sort keys:
 - If we generate a key, it is always sortable using memcmp()
 - If we are sorting the whole record, then a weight-table must be used
   during compares.
 - Major surgery to encoding of numbers to ensure unique keys for equal
   numeric values.  Reverse numerics are handled by inverting the sign.
 - Case folding (-f) is handled when the sort keys are generated. No other
   code has to care at all.
 - Key uniqueness (-u) is done during merge for large datasets. It only
   has to be done when writing the output file for small files.
   Since the file is in key order this is simple!
 Probably fixes all of: PR/27257 PR/25551 PR/22182 PR/31095 PR/30504
 PR/36816 PR/37860 PR/39308
 Also PR/18614 should no longer die, but a little more work needs to be
 done on the merging for very large files.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 src/usr.bin/sort/append.c src/usr.bin/sort/init.c
 cvs rdiff -u -r1.24 -r1.25 src/usr.bin/sort/fields.c src/usr.bin/sort/sort.h
 cvs rdiff -u -r1.34 -r1.35 src/usr.bin/sort/files.c
 cvs rdiff -u -r1.38 -r1.39 src/usr.bin/sort/fsort.c
 cvs rdiff -u -r1.22 -r1.23 src/usr.bin/sort/msort.c
 cvs rdiff -u -r1.51 -r1.52 src/usr.bin/sort/sort.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dsl@NetBSD.org
State-Changed-When: Sat, 22 Aug 2009 11:14:33 +0000
State-Changed-Why:
fixed - see above


From: Stephen Borrill <sborrill@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/25551 CVS commit: [netbsd-5] src/usr.bin/sort
Date: Wed, 14 Oct 2009 20:41:53 +0000

 Module Name:	src
 Committed By:	sborrill
 Date:		Wed Oct 14 20:41:53 UTC 2009

 Modified Files:
 	src/usr.bin/sort [netbsd-5]: Makefile append.c fields.c files.c fsort.c
 	    fsort.h init.c msort.c sort.1 sort.c sort.h tmp.c
 Added Files:
 	src/usr.bin/sort [netbsd-5]: radix_sort.c

 Log Message:
 Pull up the following revisions(s) (requested by dsl in ticket #1084):
 	usr.bin/sort/Makefile:	revision 1.6-1.8
 	usr.bin/sort/append.c:	revision 1.15-1.22
 	usr.bin/sort/fields.c:	revision 1.20-1.30
 	usr.bin/sort/files.c:	revision 1.27-1.40
 	usr.bin/sort/fsort.c:	revision 1.33-1.45
 	usr.bin/sort/fsort.h:	revision 1.14-1.17
 	usr.bin/sort/init.c:	revision 1.19-1.23
 	usr.bin/sort/msort.c:	revision 1.19-1.28
 	usr.bin/sort/radix_sort.c:	revision 1.1-1.4
 	usr.bin/sort/sort.1:	revision 1.27-1.29
 	usr.bin/sort/sort.c:	revision 1.47-1.56
 	usr.bin/sort/sort.h:	revision 1.20-1.30
 	usr.bin/sort/tmp.c:	revision 1.14-1.15

 Only use radix sort for in-memory sort, always merge temporary files.
 Use a local radixsort() function so we can pass record length.
 Avoid use of weight tables for key compares.
 Fix generation of keys for numbers, negate value for reverse sort.
 Write file in reverse-key order for 'sort -n'.
 'sort -S' now does a posix sort (sort matching keys by record data).
 Ensure merge sort doesn't have too many temporary files open.
 Fixes: PR#18614 PR#27257 PR#25551 PR#22182 PR#31095 PR#30504 PR#36816
 PR#37860 PR#39308 PR#42094


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.5.40.1 src/usr.bin/sort/Makefile
 cvs rdiff -u -r1.14 -r1.14.6.1 src/usr.bin/sort/append.c
 cvs rdiff -u -r1.19 -r1.19.6.1 src/usr.bin/sort/fields.c \
     src/usr.bin/sort/sort.h
 cvs rdiff -u -r1.26 -r1.26.6.1 src/usr.bin/sort/files.c \
     src/usr.bin/sort/sort.1
 cvs rdiff -u -r1.32 -r1.32.6.1 src/usr.bin/sort/fsort.c
 cvs rdiff -u -r1.13 -r1.13.6.1 src/usr.bin/sort/fsort.h \
     src/usr.bin/sort/tmp.c
 cvs rdiff -u -r1.18 -r1.18.6.1 src/usr.bin/sort/init.c \
     src/usr.bin/sort/msort.c
 cvs rdiff -u -r0 -r1.4.2.2 src/usr.bin/sort/radix_sort.c
 cvs rdiff -u -r1.46 -r1.46.4.1 src/usr.bin/sort/sort.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search