NetBSD Problem Report #25949

Received: (qmail 18577 invoked by uid 605); 16 Jun 2004 20:50:56 -0000
Message-Id: <20040616205053.7383C97@maailma.yok.utu.fi>
Date: Wed, 16 Jun 2004 23:50:53 +0300 (EEST)
From: arto.huusko@utu.fi
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: arto.huusko@utu.fi
To: gnats-bugs@gnats.NetBSD.org
Subject: Add support for AD1888 AC97 codec
X-Send-Pr-Version: 3.95

>Number:         25949
>Category:       kern
>Synopsis:       Patch to support AD1888 AC97 codec
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kent
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 16 20:51:00 +0000 2004
>Closed-Date:    Tue Aug 10 04:03:09 +0000 2004
>Last-Modified:  Tue Aug 10 04:03:09 +0000 2004
>Originator:     Arto Huusko
>Release:        NetBSD 2.0E
>Organization:
>Environment:
auvia0 at pci0 dev 17 function 5: VIA Technologies VT8235 AC'97 Audio (rev 0x60)
auvia0: interrupting at ioapic0 pin 22 (irq 5)
auvia0: ac97: Analog Devices AD1888 codec; headphone, 20 bit DAC, no 3D stereo
auvia0: ac97: ext id 3c7<AMAP,LDAC,SDAC,CDAC,SPDIF,DRA,VRA>
>Description:
	Add support for AD1888, which is not supported currently. This codec is
	found, for example, on Asus A7V600-X.
>How-To-Repeat:

>Fix:
	This patch makes AD1888 work. Note that AD1888 misc register bits are
	identical to 1985, only 2MIC is missing. I also changed the datatype
	of the variable that holds the register data just to be slightly more
	correct.

Index: sys/dev/ic/ac97.c
===================================================================
RCS file: /cvsroot/netbsd/src/sys/dev/ic/ac97.c,v
retrieving revision 1.52
diff -r1.52 ac97.c
99c99
< static void ac97_ad198x_init(struct ac97_softc *);
---
> static void ac97_ad1x8x_init(struct ac97_softc *);
373a374,375
> 	{ AC97_CODEC_ID('A', 'D', 'S', 0x68),
> 	  0xffffffff,			"Analog Devices AD1888", ac97_ad1x8x_init },
375c377
< 	  0xffffffff,			"Analog Devices AD1980", ac97_ad198x_init },
---
> 	  0xffffffff,			"Analog Devices AD1980", ac97_ad1x8x_init },
381c383
< 	  0xffffffff,			"Analog Devices AD1985", ac97_ad198x_init },
---
> 	  0xffffffff,			"Analog Devices AD1985", ac97_ad1x8x_init },
1459a1462,1477
> #define	AD1888_REG_MISC	0x76
> #define		AD1888_MISC_MBG0	0x0001	/* 0 */
> #define		AD1888_MISC_MBG1	0x0002	/* 1 */
> #define		AD1888_MISC_VREFD	0x0004	/* 2 */
> #define		AD1888_MISC_VREFH	0x0008	/* 3 */
> #define		AD1888_MISC_SRU		0x0010	/* 4 */
> #define		AD1888_MISC_LOSEL	0x0020	/* 5 */
> #define		AD1888_MISC_SPRD	0x0080	/* 7 */
> #define		AD1888_MISC_DMIX0	0x0100	/* 8 */
> #define		AD1888_MISC_DMIX1	0x0200	/* 9 */
> #define		AD1888_MISC_HPSEL	0x0400	/*10 */
> #define		AD1888_MISC_CLDIS	0x0800	/*11 */
> #define		AD1888_MISC_LODIS	0x1000	/*12 */
> #define		AD1888_MISC_MSPLT	0x2000	/*13 */
> #define		AD1888_MISC_AC97NC	0x4000	/*14 */
> #define		AD1888_MISC_DACZ	0x8000	/*15 */
1488c1506
< ac97_ad198x_init(struct ac97_softc *as)
---
> ac97_ad1x8x_init(struct ac97_softc *as)
1491c1509
< 	unsigned short misc;
---
> 	u_int16_t misc;
>Release-Note:
>Audit-Trail:

From: TAMURA Kent <kent@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/25949 CVS commit: src/sys/dev/ic
Date: Sat,  7 Aug 2004 17:37:31 +0000 (UTC)

 Module Name:	src
 Committed By:	kent
 Date:		Sat Aug  7 17:37:31 UTC 2004

 Modified Files:
 	src/sys/dev/ic: ac97.c

 Log Message:
 AD1888 support.
 PR kern/25949


 To generate a diff of this commit:
 cvs rdiff -r1.54 -r1.55 src/sys/dev/ic/ac97.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback 
State-Changed-By: kent 
State-Changed-When: Sat Aug 7 17:51:54 UTC 2004 
State-Changed-Why:  
The patch was incorporated.  Please check. 


Responsible-Changed-From-To: kern-bug-people->kent 
Responsible-Changed-By: kent 
Responsible-Changed-When: Sat Aug 7 17:51:54 UTC 2004 
Responsible-Changed-Why:  

From: Arto Huusko <arto.huusko@utu.fi>
To: gnats-bugs@gnats.netbsd.org
Cc: kent@netbsd.org
Subject: Re: kern/25949
Date: Mon, 09 Aug 2004 18:25:52 +0300 (EEST)

 OK, AD 1888 is identified and works with ac97.c rev 1.58.

 Thanks.
State-Changed-From-To: feedback->closed 
State-Changed-By: kent 
State-Changed-When: Tue Aug 10 04:02:51 UTC 2004 
State-Changed-Why:  
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.