NetBSD Problem Report #25969

Received: (qmail 4774 invoked by uid 605); 19 Jun 2004 15:23:53 -0000
Message-Id: <200406191523.i5JFNJD27085@steinba.ch>
Date: Sat, 19 Jun 2004 17:23:19 +0200 (CEST)
From: Ingolf Steinbach <1obv0ik02@sneakemail.com>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: Ingolf Steinbach <1obv0ik02@sneakemail.com>
To: gnats-bugs@gnats.NetBSD.org
Subject: editors/vim on 2.0 BETA m68k: conflicting struct names
X-Send-Pr-Version: 3.95

>Number:         25969
>Category:       port-m68k
>Synopsis:       vim cannot be built on 2.0 BETA m68k due to conflicting struct names
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    is
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 19 15:24:01 +0000 2004
>Closed-Date:    Sun Apr 09 15:34:16 +0000 2006
>Last-Modified:  Sun Apr 09 15:34:16 +0000 2006
>Originator:     Ingolf Steinbach
>Release:        NetBSD 2.0_BETA
>Organization:
	none
>Environment:
System: NetBSD aphrodite 2.0_BETA NetBSD 2.0_BETA (INSTALL) #0: Sat Jun 12 16:56:01 UTC 2004 autobuild@tgm.netbsd.org:/autobuild/netbsd-2-0/amiga/OBJ/autobuild/netbsd-2-0/src/sys/arch/amiga/compile/INSTALL amiga
Architecture: m68k
Machine: amiga
>Description:
	On a freshly installed NetBSD 2.0 BETA / amiga (and probably m68k
in general) machine (2004-06-12 snapshot) pkgsrc/editors/vim cannot be
built:
CC="gcc -Iproto -DHAVE_CONFIG_H   -I/usr/include  -O2 -m68060 -finline-functions -ffast-math -fomit-frame-pointer -I/usr/include       " srcdir=. sh ./osdef.sh
gcc -c -I. -Iproto -DHAVE_CONFIG_H   -I/usr/include  -O2 -m68060 -finline-functions -ffast-math -fomit-frame-pointer -I/usr/include        -o objects/buffer.o buffer.c
In file included from vim.h:1345,
                 from buffer.c:29:
structs.h:1261: error: redefinition of `struct frame'

The previous definition comes from /usr/include/m68k/cpuframe.h which
seens to be included indirectly via <sys/signal.h>.
>How-To-Repeat:
	Try to compile editors/vim on above platform.
>Fix:
	Two possibilities:
a) patch vim to use another name than "frame"
b) change m68k/cpuframe.h to not "pollute" the global namespace with symbols
   which can easily cause this kind of conflicts.

If "frame" is not part of the official NetBSD/POSIX/whatever API, I'd
definitively vote for b).
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed 
State-Changed-By: is 
State-Changed-When: Fri Jun 25 12:09:37 UTC 2004 
State-Changed-Why:  
This is the same as port-m68k/26048. 


Responsible-Changed-From-To: pkg-manager->port-m68k-maintainer 
Responsible-Changed-By: is 
Responsible-Changed-When: Fri Jun 25 12:09:37 UTC 2004 
Responsible-Changed-Why:  
This is a problem in <m68k/signal.h>. 
Responsible-Changed-From-To: port-m68k-maintainer->is@netbsd.org 
Responsible-Changed-By: is 
Responsible-Changed-When: Fri Jun 25 12:11:09 UTC 2004 
Responsible-Changed-Why:  
I'm handling this. 
Responsible-Changed-From-To: is@netbsd.org->is 
Responsible-Changed-By: is 
Responsible-Changed-When: Fri Jun 25 12:12:08 UTC 2004 
Responsible-Changed-Why:  
Don't expose @. 
State-Changed-From-To: analyzed->feedback
State-Changed-By: tsutsui@netbsd.org
State-Changed-When: Sun, 02 Apr 2006 18:25:00 +0000
State-Changed-Why:
<m68k/signal.h> has been fixed:
http://mail-index.netbsd.org/source-changes/2006/04/01/0019.html


From: "Ingolf Steinbach" <1obv0ik02@sneakemail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: port-m68k/25969 (vim cannot be built on 2.0 BETA m68k due to conflicting struct names)
Date: Wed, 5 Apr 2006 20:43:59 +0200

 Am Sonntag, 2. April 2006 20:25 schrieb tsutsui@netbsd.org:
 > State-Changed-Why:
 > <m68k/signal.h> has been fixed:
 > http://mail-index.netbsd.org/source-changes/2006/04/01/0019.html

 This looks ok to me. Unfortunately I cannot test it as I do
 not have a -current m68k machine available. But in principle,
 the patch seems to do what is necessary to solve the PR. So
 I'd suggest to close the PR but also to request a pull-up of
 the fix to the 3.x branches.

 Thanks for fixing this.
     Ingolf

State-Changed-From-To: feedback->closed
State-Changed-By: tsutsui@netbsd.org
State-Changed-When: Sun, 09 Apr 2006 15:34:16 +0000
State-Changed-Why:
vim now can be built on -current, and fix has been pulled up to netbsd-3.


>Unformatted:

Home	PR Database Search