NetBSD Problem Report #26107

Received: (qmail 24727 invoked by uid 605); 29 Jun 2004 07:56:50 -0000
Message-Id: <20040629075646.82B5E4C97F@yerfable.azeotrope.org>
Date: Tue, 29 Jun 2004 02:56:46 -0500 (CDT)
From: khym@azeotrope.org
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: khym@azeotrope.org
To: gnats-bugs@gnats.NetBSD.org
Subject: comms/snooper package doesn't work
X-Send-Pr-Version: 3.95

>Number:         26107
>Category:       pkg
>Synopsis:       comms/snooper package doesn't work
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 29 07:57:00 +0000 2004
>Closed-Date:    Tue Jun 29 23:42:06 +0000 2004
>Last-Modified:  Tue Jun 29 23:43:01 +0000 2004
>Originator:     Dave Huang
>Release:        NetBSD 2.0_BETA
>Organization:
Name: Dave Huang         |  Mammal, mammal / their names are called /
INet: khym@azeotrope.org |  they raise a paw / the bat, the cat /
FurryMUCK: Dahan         |  dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 28 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++
>Environment:


System: NetBSD yerfable.azeotrope.org 2.0_BETA NetBSD 2.0_BETA (YERFABLE) #206: Mon May 31 05:53:47 CDT 2004 khym@yerfable.azeotrope.org:/usr2/obj.alpha/sys/arch/alpha/compile/YERFABLE alpha
Architecture: alpha
Machine: alpha
>Description:
	comms/snooper doesn't work; it displays the serial line
statuses, but doesn't display any data, and will hang using all the
CPU after a while.

>How-To-Repeat:
	Attempt to use snooper. E.g., snooper -b57600 tty02 tty04
>Fix:
	Don't know how this ever worked... ioctl(2) returns -1 on
failure, not on success.

Add this as patches/patch-aa:

--- ../src/scrn.c.orig	1998-08-12 09:32:02.000000000 -0500
+++ ../src/scrn.c	2004-06-29 02:44:50.000000000 -0500
@@ -33,7 +33,7 @@
 #ifdef TIOCGWINSZ
 			struct winsize win;

-			if (ioctl(STDERR_FILENO, TIOCGWINSZ, &win) == -1) {
+			if (ioctl(STDERR_FILENO, TIOCGWINSZ, &win) != -1) {
 				rows = win.ws_row;
 				cols = win.ws_col;
 			}

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: recht 
State-Changed-When: Tue Jun 29 23:41:45 UTC 2004 
State-Changed-Why:  
Patch commited. Thanks for the PR! 

From: Marc Recht <recht@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26107 CVS commit: pkgsrc/comms/snooper
Date: Tue, 29 Jun 2004 23:41:39 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	recht
 Date:		Tue Jun 29 23:41:39 UTC 2004

 Modified Files:
 	pkgsrc/comms/snooper: Makefile distinfo

 Log Message:
 Fix wrong interpretation of ioctl's return code:
 ioctl(2) returns -1 on failure, not on success

 Patch provided by Dave Huang in PR 26107

 bump PKGREVISION to 1


 To generate a diff of this commit:
 cvs rdiff -r1.15 -r1.16 pkgsrc/comms/snooper/Makefile
 cvs rdiff -r1.2 -r1.3 pkgsrc/comms/snooper/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.