NetBSD Problem Report #26113

Received: (qmail 20112 invoked by uid 605); 29 Jun 2004 16:02:28 -0000
Message-Id: <20040629160226.5722111154@narn.netbsd.org>
Date: Tue, 29 Jun 2004 16:02:26 +0000 (UTC)
From: jeffi@rcn.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: jeffi@rcn.com
To: gnats-bugs@gnats.NetBSD.org
Subject: remove duplicate includes from sys/kern code
X-Send-Pr-Version: www-1.0

>Number:         26113
>Category:       kern
>Synopsis:       remove duplicate includes from sys/kern code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 29 16:03:00 +0000 2004
>Closed-Date:    Sat Sep 23 15:36:46 +0000 2006
>Last-Modified:  Sat Sep 23 15:40:01 +0000 2006
>Originator:     Jeff Ito
>Release:        NetBSD 2.0F
>Organization:
>Environment:
NetBSD netbsd 2.0F NetBSD 2.0F (LAB) #12: Wed Jun 23 15:44:50 EDT 2004
>Description:
a number of the files in sys/kern contain duplicate #includes.
>How-To-Repeat:
n/a
>Fix:
Index: kern_exit.c
===================================================================
RCS file: /cvs/nbsd/src/sys/kern/kern_exit.c,v
retrieving revision 1.141
diff -u -r1.141 kern_exit.c
--- kern_exit.c 31 May 2004 15:33:38 -0000      1.141
+++ kern_exit.c 29 Jun 2004 15:55:43 -0000
@@ -90,7 +90,6 @@
 #include <sys/resource.h>
 #include <sys/kernel.h>
 #include <sys/ktrace.h>
-#include <sys/proc.h>
 #include <sys/buf.h>
 #include <sys/wait.h>
 #include <sys/file.h>
Index: sys_pipe.c
===================================================================
RCS file: /cvs/nbsd/src/sys/kern/sys_pipe.c,v
retrieving revision 1.57
diff -u -r1.57 sys_pipe.c
--- sys_pipe.c  25 Apr 2004 16:42:41 -0000      1.57
+++ sys_pipe.c  29 Jun 2004 15:55:43 -0000
@@ -101,14 +101,12 @@
 #include <sys/signalvar.h>
 #include <sys/vnode.h>
 #include <sys/uio.h>
-#include <sys/lock.h>
 #include <sys/select.h>
 #include <sys/mount.h>
 #include <sys/sa.h>
 #include <sys/syscallargs.h>
 #include <uvm/uvm.h>
 #include <sys/sysctl.h>
-#include <sys/kernel.h>

 #include <sys/pipe.h>

Index: tty_conf.c
===================================================================
RCS file: /cvs/nbsd/src/sys/kern/tty_conf.c,v
retrieving revision 1.44
diff -u -r1.44 tty_conf.c
--- tty_conf.c  23 Mar 2004 13:22:33 -0000      1.44
+++ tty_conf.c  29 Jun 2004 15:55:43 -0000
@@ -48,7 +48,6 @@
 #include <sys/ioctl.h>
 #include <sys/proc.h>
 #include <sys/tty.h>
-#include <sys/ioctl.h>
 #include <sys/ttycom.h>
 #include <sys/conf.h>
 #include <sys/malloc.h>
Index: tty_pty.c
===================================================================
RCS file: /cvs/nbsd/src/sys/kern/tty_pty.c,v
retrieving revision 1.80
diff -u -r1.80 tty_pty.c
--- tty_pty.c   18 Jun 2004 15:02:53 -0000      1.80
+++ tty_pty.c   29 Jun 2004 15:55:43 -0000
@@ -50,7 +50,6 @@
 #include <sys/tty.h>
 #include <sys/stat.h>
 #include <sys/file.h>
-#include <sys/uio.h>
 #include <sys/kernel.h>
 #include <sys/vnode.h>
 #include <sys/namei.h>
Index: vfs_subr.c
===================================================================
RCS file: /cvs/nbsd/src/sys/kern/vfs_subr.c,v
retrieving revision 1.229
diff -u -r1.229 vfs_subr.c
--- vfs_subr.c  19 Jun 2004 06:20:02 -0000      1.229
+++ vfs_subr.c  29 Jun 2004 15:55:43 -0000
@@ -117,8 +117,6 @@
 #include <uvm/uvm.h>
 #include <uvm/uvm_ddb.h>

-#include <netinet/in.h>
-
 #include <sys/sysctl.h>

 const enum vtype iftovt_tab[16] = {

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: xtraeme@netbsd.org
State-Changed-When: Sat, 23 Sep 2006 15:36:46 +0000
State-Changed-Why:
Fixed, thanks.


From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/26113 CVS commit: src/sys/kern
Date: Sat, 23 Sep 2006 15:36:13 +0000 (UTC)

 Module Name:	src
 Committed By:	xtraeme
 Date:		Sat Sep 23 15:36:13 UTC 2006

 Modified Files:
 	src/sys/kern: kern_exit.c sys_pipe.c tty_pty.c

 Log Message:
 Remove duplicated includes, from Jeff Ito -> PR kern/26113. Thanks.


 To generate a diff of this commit:
 cvs rdiff -r1.158 -r1.159 src/sys/kern/kern_exit.c
 cvs rdiff -r1.74 -r1.75 src/sys/kern/sys_pipe.c
 cvs rdiff -r1.93 -r1.94 src/sys/kern/tty_pty.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.