NetBSD Problem Report #26243

Received: (qmail 19928 invoked by uid 605); 11 Jul 2004 09:48:03 -0000
Message-Id: <20040711072358.6C14F1117A@narn.netbsd.org>
Date: Sun, 11 Jul 2004 07:23:58 +0000 (UTC)
From: geos@epost.de
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: geos@epost.de
To: gnats-bugs@gnats.NetBSD.org
Subject: USE_MMX should be in BUILD_DEFS only on x86
X-Send-Pr-Version: www-1.0

>Number:         26243
>Category:       pkg
>Synopsis:       USE_MMX should be in BUILD_DEFS only on x86
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    cube
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 11 09:49:00 +0000 2004
>Closed-Date:    Mon Jul 19 23:56:47 +0000 2004
>Last-Modified:  Mon Jul 19 23:58:00 +0000 2004
>Originator:     Georg Schwarz
>Release:        current pkgsrc
>Organization:
>Environment:
IRIX lorenz 5.3 08031225 IP20 mips
>Description:
USE_MMX is only meaningful on x86 platforms and should thus only there be included in BUILD_DEFS (where used). So far the following file unconditionally add it to BUILD_DEFS:

devel/libast/Makefile
emulators/snes9x/Makefile
graphics/imlib2/Makefile
multimedia/ffmpeg/Makefile

x11/eterm/Makefile adds USE_MMX to BUILD_DEFS only when it is not "NO", which is also incorrect.

multimedia/avidemux/Makefile and multimedia/xawtv/Makefile seem to imply they compile on x86 only but do not explicitly say so.

>How-To-Repeat:

>Fix:
Enclose BUILD_DEFS+= USE_MMX by  .if empty(USE_MMX:M[Yy][Ee][Ss]) ... .fi
in the affected Makefiles.
In case there packages work on x86 anyway, this should be denoted instead.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->cube 
Responsible-Changed-By: cube 
Responsible-Changed-When: Mon Jul 12 18:56:03 UTC 2004 
Responsible-Changed-Why:  
I'll handle it. 

From: Quentin Garnier <cube@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26243 CVS commit: pkgsrc/x11/eterm
Date: Mon, 12 Jul 2004 19:08:03 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	cube
 Date:		Mon Jul 12 19:08:03 UTC 2004

 Modified Files:
 	pkgsrc/x11/eterm: Makefile

 Log Message:
 Always register USE_MMX as a BUILD_DEF, and test against [Yy][Ee][Ss], as
 everywhere else.  About PR 26243.


 To generate a diff of this commit:
 cvs rdiff -r1.32 -r1.33 pkgsrc/x11/eterm/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Quentin Garnier <cube@cubidou.net>
To: geos@epost.de
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/26243: USE_MMX should be in BUILD_DEFS only on x86
Date: Mon, 12 Jul 2004 21:14:41 +0200

 Le Sun, 11 Jul 2004 07:23:58 +0000 (UTC)
 geos@epost.de a ecrit :
 > >Description:
 > USE_MMX is only meaningful on x86 platforms and should thus only there

 That's not true.  It is meaningful on amd64, too.  It might get meaningful
 on other future platforms, too.  Right now only packages make use on it
 only on i386, but that might change soon enough.

 > be included in BUILD_DEFS (where used). So far the following file

 Well, it should be more carefully checked.

 [...]
 > >Fix:
 > Enclose BUILD_DEFS+= USE_MMX by  .if empty(USE_MMX:M[Yy][Ee][Ss]) ...
 > .fi in the affected Makefiles.

 No!  It might me enclosed in .if MACHINE_ARCH == i386 blocks, but a
 BUILD_DEFS addition should _not_ be enclosed into its own test, it makes
 the whole thing completely useless.

 -- 
 Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
 "Feels like I'm fiddling while Rome is burning down.
 Should I lay my fiddle down and take a rifle from the ground ?"
 Leigh Nash/Sixpence None The Richer, Paralyzed, Divine Discontents, 2002.

From: Quentin Garnier <cube@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26243 CVS commit: pkgsrc
Date: Mon, 12 Jul 2004 19:27:05 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	cube
 Date:		Mon Jul 12 19:27:05 UTC 2004

 Modified Files:
 	pkgsrc/devel/libast: Makefile
 	pkgsrc/emulators/snes9x: Makefile
 	pkgsrc/graphics/imlib2: Makefile
 	pkgsrc/multimedia/ffmpeg: Makefile
 	pkgsrc/x11/eterm: Makefile

 Log Message:
 For USE_MMX users, do the following:
 o only include it in the BUILD_DEFS if the current platform is concerned.
   For now that only includes i386, but we might find amd64 users in the
   future.
 o test against [Yy][Ee][Ss], for consistency.

 Fixes part of PR 26243.


 To generate a diff of this commit:
 cvs rdiff -r1.10 -r1.11 pkgsrc/devel/libast/Makefile
 cvs rdiff -r1.19 -r1.20 pkgsrc/emulators/snes9x/Makefile
 cvs rdiff -r1.19 -r1.20 pkgsrc/graphics/imlib2/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/multimedia/ffmpeg/Makefile
 cvs rdiff -r1.33 -r1.34 pkgsrc/x11/eterm/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed 
State-Changed-By: xtraeme 
State-Changed-When: Mon Jul 19 23:56:38 UTC 2004 
State-Changed-Why:  
Fixed. 

From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26243 CVS commit: pkgsrc/multimedia
Date: Mon, 19 Jul 2004 23:56:21 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	xtraeme
 Date:		Mon Jul 19 23:56:21 UTC 2004

 Modified Files:
 	pkgsrc/multimedia/avidemux: Makefile
 	pkgsrc/multimedia/xawtv: Makefile

 Log Message:
 Only show USE_MMX in BUILD_DEFS when ${MACHINE_ARCH} == i386.
 This closes PR pkg/26243.


 To generate a diff of this commit:
 cvs rdiff -r1.5 -r1.6 pkgsrc/multimedia/avidemux/Makefile
 cvs rdiff -r1.3 -r1.4 pkgsrc/multimedia/xawtv/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.