NetBSD Problem Report #26272
Received: (qmail 16032 invoked by uid 605); 13 Jul 2004 14:38:51 -0000
Message-Id: <200407131438.i6DEcm0U020584@watcher.eis.cs.tu-bs.de>
Date: Tue, 13 Jul 2004 16:38:48 +0200 (MEST)
From: Juergen Hannken-Illjes <hannken@eis.cs.tu-bs.de>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: hannken@eis.cs.tu-bs.de
To: gnats-bugs@gnats.netbsd.org
Subject: vnd may dreference null pointer
X-Send-Pr-Version: 3.95
>Number: 26272
>Category: kern
>Synopsis: vnd may dreference null pointer
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bouyer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Jul 13 14:39:00 +0000 2004
>Closed-Date: Wed Apr 20 21:01:47 +0000 2005
>Last-Modified: Fri May 13 18:08:00 +0000 2005
>Originator: Juergen Hannken-Illjes
>Release: NetBSD 2.0 current
>Organization:
net
>Environment:
Architecture: any
Machine: any
>Description:
vnd uses VND_GETXFER() and VND_GETBUF() to allocate items from pools
and set PR_NOWAIT. The result is not checked against NULL.
>How-To-Repeat:
Code inspection.
>Fix:
Either use PR_WAIT or abort operation on NULL.
>Release-Note:
>Audit-Trail:
From: Manuel Bouyer <bouyer@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/26272 CVS commit: src/sys/dev
Date: Wed, 30 Mar 2005 19:23:08 +0000 (UTC)
Module Name: src
Committed By: bouyer
Date: Wed Mar 30 19:23:08 UTC 2005
Modified Files:
src/sys/dev: vnd.c vndvar.h
Log Message:
Make vnd do I/O to the underlying file from thread context. This
allows the strategy routine to be called from interrupt context, fixes
PR kern/29775 by Juan RP.
Now that pool_get() is only called from thread context, change PR_NOWAIT to
PR_WAITOK. Fix PR kern/26272 by Juergen Hannken-Illjes.
OK'd by thorpej@
To generate a diff of this commit:
cvs rdiff -r1.111 -r1.112 src/sys/dev/vnd.c
cvs rdiff -r1.13 -r1.14 src/sys/dev/vndvar.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Responsible-Changed-From-To: kern-bug-people->bouyer
Responsible-Changed-By: bouyer@netbsd.org
Responsible-Changed-When: Wed, 30 Mar 2005 19:26:40 +0000
Responsible-Changed-Why:
Just commited a fix to current, will send pullup requests in a day or two.
From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/26272 CVS commit: [netbsd-3] src/sys/dev
Date: Sun, 3 Apr 2005 13:32:40 +0000 (UTC)
Module Name: src
Committed By: tron
Date: Sun Apr 3 13:32:40 UTC 2005
Modified Files:
src/sys/dev [netbsd-3]: vndvar.h
Log Message:
Pull up revision 1.14 (requested by bouyer in ticket #85):
Make vnd do I/O to the underlying file from thread context. This
allows the strategy routine to be called from interrupt context, fixes
PR kern/29775 by Juan RP.
Now that pool_get() is only called from thread context, change PR_NOWAIT to
PR_WAITOK. Fix PR kern/26272 by Juergen Hannken-Illjes.
OK'd by thorpej@
To generate a diff of this commit:
cvs rdiff -r1.13 -r1.13.2.1 src/sys/dev/vndvar.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/26272 CVS commit: [netbsd-3] src/sys/dev
Date: Sun, 3 Apr 2005 13:32:45 +0000 (UTC)
Module Name: src
Committed By: tron
Date: Sun Apr 3 13:32:45 UTC 2005
Modified Files:
src/sys/dev [netbsd-3]: vnd.c
Log Message:
Pull up revision 1.112 (requested by bouyer in ticket #85):
Make vnd do I/O to the underlying file from thread context. This
allows the strategy routine to be called from interrupt context, fixes
PR kern/29775 by Juan RP.
Now that pool_get() is only called from thread context, change PR_NOWAIT to
PR_WAITOK. Fix PR kern/26272 by Juergen Hannken-Illjes.
OK'd by thorpej@
To generate a diff of this commit:
cvs rdiff -r1.111 -r1.111.10.1 src/sys/dev/vnd.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: bouyer@netbsd.org
State-Changed-When: Wed, 20 Apr 2005 21:01:47 +0000
State-Changed-Why:
Fixed in current and netbsd-3, pullup request sent for netbsd-2
From: Jeff Rizzo <riz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/26272 CVS commit: [netbsd-2] src/sys/dev
Date: Fri, 13 May 2005 18:06:35 +0000 (UTC)
Module Name: src
Committed By: riz
Date: Fri May 13 18:06:35 UTC 2005
Modified Files:
src/sys/dev [netbsd-2]: vndvar.h
Log Message:
Pull up revision 1.14 via patch (requested by bouyer in ticket #1417):
Make vnd do I/O to the underlying file from thread context. This
allows the strategy routine to be called from interrupt context
Now that pool_get() is only called from thread context, change PR_NOWAIT to
PR_WAITOK. Fix PR kern/26272 by Juergen Hannken-Illjes.
OK'd by thorpej@
To generate a diff of this commit:
cvs rdiff -r1.12 -r1.12.6.1 src/sys/dev/vndvar.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Jeff Rizzo <riz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/26272 CVS commit: [netbsd-2] src/sys/dev
Date: Fri, 13 May 2005 18:07:13 +0000 (UTC)
Module Name: src
Committed By: riz
Date: Fri May 13 18:07:13 UTC 2005
Modified Files:
src/sys/dev [netbsd-2]: vnd.c
Log Message:
Pull up revisions 1.112 and 1.114 via patch(requested by bouyer in
ticket #1417):
Make vnd do I/O to the underlying file from thread context. This
allows the strategy routine to be called from interrupt context
Now that pool_get() is only called from thread context, change PR_NOWAIT to
PR_WAITOK. Fix PR kern/26272 by Juergen Hannken-Illjes.
OK'd by thorpej@
Don't eventually leak vnx and bp on unconfigure, pointed out by YAMAMOTO
Takashi. Instead, let the current I/O complete before killing the thread.
To generate a diff of this commit:
cvs rdiff -r1.106 -r1.106.4.1 src/sys/dev/vnd.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.