NetBSD Problem Report #26412

Received: (qmail 15733 invoked by uid 605); 23 Jul 2004 07:14:44 -0000
Message-Id: <20040723065412.461375282B@whitey.babymeat.com>
Date: Thu, 22 Jul 2004 23:54:12 -0700 (PDT)
From: dogcow+netbsdspam@babymeat.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: dogcow+netbsdspam@babymeat.com
To: gnats-bugs@gnats.NetBSD.org
Subject: mplayer fails to compile libfaad2 on NetBSD >= 2.0F
X-Send-Pr-Version: 3.95

>Number:         26412
>Category:       pkg
>Synopsis:       mplayer fails to compile libfaad2 on NetBSD >= 2.0F
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 23 07:15:00 +0000 2004
>Closed-Date:    Sat Jul 31 08:11:20 +0000 2004
>Last-Modified:  Sat Nov 06 00:48:00 +0000 2004
>Originator:     Tom Spindler
>Release:        NetBSD 2.0G
>Organization:

>Environment:


System: NetBSD whitey 2.0G NetBSD 2.0G (WHITEY) #3: Mon Jul 5 06:42:07 PDT 2004 dogcow@whitey:/media/tmp/obj/obj/media/src/src/sys/arch/i386/compile/WHITEY i386
Architecture: i386
Machine: i386
>Description:

libfaad2 in Mplayer has an inlined lrintf; unfortunately, this definition
clashes with the one introduced in NetBSD-current recently (around 2.0F).
>How-To-Repeat:
cd pkgsrc/multimedia/mplayer; make install
.....
Checking for internal FAAD2 (AAC) support ... no (broken gcc)


>Fix:

here's a patch. it works on my system, looks mostly right to me.

--- libfaad2/common.h.orig      2004-06-23 06:50:49.000000000 -0700
+++ libfaad2/common.h   2004-07-22 23:39:30.000000000 -0700
@@ -34,6 +34,8 @@
 extern "C" {
 #endif

+#include <sys/param.h>
+
 /* Allow build on cygwin*/
 #if defined(__CYGWIN__)
 #define __STRICT_ANSI__
@@ -336,6 +338,7 @@
     }
   #elif (defined(__i386__) && defined(__GNUC__)) && !defined(__MINGW32__)
     #define HAS_LRINTF
+    #if (__NetBSD_Version__ < 200060000)
     // from http://www.stereopsis.com/FPU.html
     static INLINE int lrintf(float f)
     {
@@ -348,6 +351,7 @@
         return i;
     }
+    #endif
   #endif


   #ifdef __ICL /* only Intel C compiler has fmath ??? */

>Release-Note:
>Audit-Trail:

From: Thomas Klausner <wiz@NetBSD.org>
To: dogcow+netbsdspam@babymeat.com
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/26412: mplayer fails to compile libfaad2 on NetBSD >= 2.0F
Date: Sat, 24 Jul 2004 13:53:32 +0200

 --TeJTyD9hb8KJN2Jy
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On Thu, Jul 22, 2004 at 11:54:12PM -0700, dogcow+netbsdspam@babymeat.com wrote:
 > >Synopsis:       mplayer fails to compile libfaad2 on NetBSD >= 2.0F

 The attached patch looks saner to me -- configure already checks
 for the symbol. Does this patch work for you?

  Thomas

 --TeJTyD9hb8KJN2Jy
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch-ac

 $NetBSD$

 --- libfaad2/common.h.orig	2004-06-23 15:50:49.000000000 +0200
 +++ libfaad2/common.h
 @@ -335,6 +335,7 @@ char *strchr(), *strrchr();
          return i;
      }
    #elif (defined(__i386__) && defined(__GNUC__)) && !defined(__MINGW32__)
 +    #ifndef HAVE_LRINTF
      #define HAS_LRINTF
      // from http://www.stereopsis.com/FPU.html
      static INLINE int lrintf(float f)
 @@ -347,6 +348,7 @@ char *strchr(), *strrchr();
              : "m" (f));
          return i;
      }
 +    #endif
    #endif



 --TeJTyD9hb8KJN2Jy--

From: Tom Spindler <dogcow@babymeat.com>
To: Thomas Klausner <wiz@NetBSD.org>
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/26412: mplayer fails to compile libfaad2 on NetBSD >= 2.0F
Date: Sat, 24 Jul 2004 10:56:50 -0700

 > The attached patch looks saner to me -- configure already checks
 > for the symbol. Does this patch work for you?

 The problem is that the config.h file doesn't get generated until the
 end of configure time - and the faad2 test is still during configure.

 Since it's pretty unclear for what version of gcc things are expected
 to fail - and this is precisely one of the things pkgsrc automatically
 codes around - I'd think that removing that cc_check entirely is
 a reasonable thing to do Another way of 'fixing' it is requiring
 the external faad2 package, I suppose.

State-Changed-From-To: open->closed 
State-Changed-By: xtraeme 
State-Changed-When: Sat Jul 31 08:11:06 UTC 2004 
State-Changed-Why:  
Fixed, thanks. 

From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26412 CVS commit: pkgsrc/audio/faad2
Date: Sat, 31 Jul 2004 08:10:47 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	xtraeme
 Date:		Sat Jul 31 08:10:47 UTC 2004

 Modified Files:
 	pkgsrc/audio/faad2: Makefile distinfo
 	pkgsrc/audio/faad2/patches: patch-ad

 Log Message:
 Fix lrintf() function in libfaad/common.h to make this build on
 NetBSD -current, this closes PR pkg/26412.


 To generate a diff of this commit:
 cvs rdiff -r1.18 -r1.19 pkgsrc/audio/faad2/Makefile
 cvs rdiff -r1.3 -r1.4 pkgsrc/audio/faad2/distinfo
 cvs rdiff -r1.1 -r1.2 pkgsrc/audio/faad2/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26412 CVS commit: pkgsrc/multimedia
Date: Sat,  6 Nov 2004 00:47:34 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sat Nov  6 00:47:34 UTC 2004

 Modified Files:
 	pkgsrc/multimedia/gmplayer: Makefile
 	pkgsrc/multimedia/mencoder: Makefile
 	pkgsrc/multimedia/mplayer: Makefile
 	pkgsrc/multimedia/mplayer-share: distinfo
 Added Files:
 	pkgsrc/multimedia/mplayer-share/patches: patch-ac

 Log Message:
 Fix faad2 test in configure script on -current;
 based on PR 26412 by Tom Spindler.
 Bump PKGREVISION on all affected packages.


 To generate a diff of this commit:
 cvs rdiff -r1.24 -r1.25 pkgsrc/multimedia/gmplayer/Makefile
 cvs rdiff -r1.13 -r1.14 pkgsrc/multimedia/mencoder/Makefile
 cvs rdiff -r1.11 -r1.12 pkgsrc/multimedia/mplayer/Makefile
 cvs rdiff -r1.12 -r1.13 pkgsrc/multimedia/mplayer-share/distinfo
 cvs rdiff -r0 -r1.3 pkgsrc/multimedia/mplayer-share/patches/patch-ac

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:
 >Quarter:
 >Keywords:
 >Date-Required:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.