NetBSD Problem Report #26475

Received: (qmail 27136 invoked by uid 605); 29 Jul 2004 20:05:30 -0000
Message-Id: <20040729174119.17F9111152@narn.netbsd.org>
Date: Thu, 29 Jul 2004 17:41:19 +0000 (UTC)
From: bbehr@networkstoragecorp.com
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: bbehr@networkstoragecorp.com
To: gnats-bugs@gnats.NetBSD.org
Subject: symbols defined in uvm_map.h may conflict with user variable names
X-Send-Pr-Version: www-1.0

>Number:         26475
>Category:       kern
>Synopsis:       symbols defined in uvm_map.h may conflict with user variable names
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 29 20:06:00 +0000 2004
>Closed-Date:    Fri Feb 11 02:13:58 +0000 2005
>Last-Modified:  Fri Feb 11 02:13:58 +0000 2005
>Originator:     William Behr
>Release:        NetBSD 2.0 BETA
>Organization:
Network Storage Corporation
>Environment:
NetBSD raider 2.0_BETA NetBSD 2.0_BETA (GENERIC) #1: Thu Jul 29 15:10:02 EDT 2004
>Description:
nonspecific symbols min_offset and max_offset defined in uvm_map.h
may conflict with the names of unrelated simple variables declared
in other non-uvm source modules which indirectly include this file.
>How-To-Repeat:
compile any program source that includes <sys/vnode.h>
and declares variables named min_offset or max_offset.
>Fix:
suggested resolution: delete these symbol definitions in uvm_map.h,
modify the vm_map_min() and vm_map_max() macros to incorporate the
appropriate substitution directly, and alter all references to the
deleted symbols (27 total) in other modules to employ these macros.

modules affected:

sys/uvm/uvm_map.h (4)
sys/uvm/uvm_map.c (16)
sys/uvm/uvm_map_i.h (4)
sys/uvm/uvm_mmap.c (1)
sys/kern/kern_exec.c (1)
sys/arch/acorn26/acorn26/machdep.c (1)
>Release-Note:
>Audit-Trail:
From: Chuck Silvers <chs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/26475 CVS commit: src
Date: Fri, 11 Feb 2005 02:12:03 +0000 (UTC)

 Module Name:	src
 Committed By:	chs
 Date:		Fri Feb 11 02:12:03 UTC 2005

 Modified Files:
 	src/sys/kern: kern_exec.c
 	src/sys/uvm: uvm_map.c uvm_map.h uvm_map_i.h uvm_mmap.c
 	src/usr.bin/pmap: pmap.c

 Log Message:
 use vm_map_{min,max}() instead of dereferencing the vm_map pointer directly.
 define and use vm_map_set{min,max}() for modifying these values.
 remove the {min,max}_offset aliases for these vm_map fields to be more
 namespace-friendly.  PR 26475.


 To generate a diff of this commit:
 cvs rdiff -r1.191 -r1.192 src/sys/kern/kern_exec.c
 cvs rdiff -r1.183 -r1.184 src/sys/uvm/uvm_map.c
 cvs rdiff -r1.44 -r1.45 src/sys/uvm/uvm_map.h
 cvs rdiff -r1.31 -r1.32 src/sys/uvm/uvm_map_i.h
 cvs rdiff -r1.87 -r1.88 src/sys/uvm/uvm_mmap.c
 cvs rdiff -r1.24 -r1.25 src/usr.bin/pmap/pmap.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: chs@netbsd.org
State-Changed-When: Fri, 11 Feb 2005 02:13:58 +0000
State-Changed-Why:
change applied, thanks.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.