NetBSD Problem Report #265

From gnats  Fri May 27 01:48:51 1994
Received: from infko.uni-koblenz.de (mailhost.uni-koblenz.de [141.26.4.1]) by sun-lamp.cs.berkeley.edu (8.6.9/8.6.9) with ESMTP id BAA06365 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Fri, 27 May 1994 01:48:32 -0700
Message-Id: <199405270847.KAA19218@infko.uni-koblenz.de>
Date: Fri, 27 May 1994 10:47:53 +0200
From: arndt@mailhost.uni-koblenz.de
Reply-To: arndt@mailhost.uni-koblenz.de
To: gnats-bugs@sun-lamp.cs.berkeley.edu
Subject: nfsstat prints junk info
X-Send-Pr-Version: 3.2

>Number:         265
>Category:       bin
>Synopsis:       nfsstat should use libkvm
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 27 01:50:05 +0000 1994
>Closed-Date:    Fri May 27 11:18:41 +0000 1994
>Last-Modified:  
>Originator:     Uwe Arndt
>Release:        
>Organization:
Uwe Arndt                              | arndt@uniko.uni-koblenz.de
Universitaet Koblenz,                  |
Rechenzentrum                          | Voice: +49 261 9119-642
Rheinau 1, D-56075 Koblenz, Germany    | Fax:   +49 261 9119-499
>Environment:

System: NetBSD harvey.uni-koblenz.de NetBSD 0.9B NetBSD 0.9B (HARVEY) #4: Thu May 19 19:29:21 MET DST 1994 root@harvey.uni-koblenz.de:/usr/src/sys/arch/i386/compile/HARVEY i386


>Description:
	nfsstat prints random info
>How-To-Repeat:
	call nfsstat
>Fix:
	apply following patch and nfsstat will use kvm_* routines to get
	kernel info


*** Makefile.orig	Fri May 27 10:32:30 1994
--- Makefile.own	Fri May 27 10:35:15 1994
***************
*** 6,9 ****
--- 6,11 ----
  BINGRP=	kmem
  BINMODE=2555

+ LDADD=-lkvm
+ 
  .include <bsd.prog.mk>
*** nfsstat.c.orig	Fri May 27 10:11:35 1994
--- nfsstat.c.own	Fri May 27 10:42:14 1994
***************
*** 66,71 ****
--- 66,72 ----
  #include <stdlib.h>
  #include <string.h>
  #include <paths.h>
+ #include <kvm.h>

  struct nlist nl[] = {
  #define	N_NFSSTAT	0
***************
*** 83,93 ****
  struct pte *Sysmap;
  #endif

! int kflag, kmem;
  char *kernel = _PATH_UNIX;
  char *kmemf = _PATH_KMEM;

- off_t klseek();
  void intpr(), printhdr(), sidewaysintpr(), usage();

  main(argc, argv)
--- 84,94 ----
  struct pte *Sysmap;
  #endif

! int kflag;
! kvm_t *kmem;
  char *kernel = _PATH_UNIX;
  char *kmemf = _PATH_KMEM;

  void intpr(), printhdr(), sidewaysintpr(), usage();

  main(argc, argv)
***************
*** 133,142 ****
  		(void)fprintf(stderr, "nfsstate: %s: no namelist\n", kernel);
  		exit(1);
  	}
! 	kmem = open(kmemf, O_RDONLY);
! 	if (kmem < 0) {
  		(void)fprintf(stderr,
  		    "nfsstat: %s: %s\n", kmemf, strerror(errno));
  		exit(1);
  	}
  	if (kflag) {
--- 134,144 ----
  		(void)fprintf(stderr, "nfsstate: %s: no namelist\n", kernel);
  		exit(1);
  	}
! 	kmem = kvm_open(NULL,NULL,NULL,O_RDONLY,"kvm_open");
! 	if (kmem == NULL) {
  		(void)fprintf(stderr,
  		    "nfsstat: %s: %s\n", kmemf, strerror(errno));
+ 		kvm_close(kmem);
  		exit(1);
  	}
  	if (kflag) {
***************
*** 152,172 ****
  			(void)fprintf(stderr, "nfsstat: %s\n", strerror(errno));
  			exit(1);
  		}
! 		off = nl[N_SYSMAP].n_value & ~KERNBASE;
! 		(void)lseek(kmem, off, L_SET);
! 		(void)read(kmem, (char *)Sysmap,
! 		    (int)(nl[N_SYSSIZE].n_value * sizeof(struct pte)));
  #endif
  	}

  	if (!nl[N_NFSSTAT].n_value) {
  		(void)fprintf(stderr, "nfsstat: nfsstats symbol not defined\n");
  		exit(1);
  	}
  	if (interval)
  		sidewaysintpr(interval, nl[N_NFSSTAT].n_value);
  	else
  		intpr(nl[N_NFSSTAT].n_value);
  	exit(0);
  }

--- 154,174 ----
  			(void)fprintf(stderr, "nfsstat: %s\n", strerror(errno));
  			exit(1);
  		}
! 		kvm_read(kmem, (long) nl[N_SYSMAP].n_value, (char *)Sysmap,
! 			(int)(nl[N_SYSSIZE].n_value * sizeof(struct pte)));
  #endif
  	}

  	if (!nl[N_NFSSTAT].n_value) {
  		(void)fprintf(stderr, "nfsstat: nfsstats symbol not defined\n");
+ 		kvm_close(kmem);
  		exit(1);
  	}
  	if (interval)
  		sidewaysintpr(interval, nl[N_NFSSTAT].n_value);
  	else
  		intpr(nl[N_NFSSTAT].n_value);
+ 	kvm_close(kmem);
  	exit(0);
  }

***************
*** 179,186 ****
  {
  	struct nfsstats nfsstats;

! 	klseek(kmem, nfsstataddr, 0L);
! 	read(kmem, (char *)&nfsstats, sizeof(struct nfsstats));
  	printf("Client Info:\n");
  	printf("Rpc Counts:\n");
  	printf("%9.9s %9.9s %9.9s %9.9s %9.9s %9.9s %9.9s %9.9s\n",
--- 181,187 ----
  {
  	struct nfsstats nfsstats;

! 	kvm_read(kmem, nfsstataddr, (char *)&nfsstats, sizeof(struct nfsstats));
  	printf("Client Info:\n");
  	printf("Rpc Counts:\n");
  	printf("%9.9s %9.9s %9.9s %9.9s %9.9s %9.9s %9.9s %9.9s\n",
***************
*** 293,300 ****
  	int hdrcnt, oldmask;
  	void catchalarm();

- 	klseek(kmem, off, 0L);
- 
  	(void)signal(SIGALRM, catchalarm);
  	signalled = 0;
  	(void)alarm(interval);
--- 294,299 ----
***************
*** 305,312 ****
  			printhdr();
  			hdrcnt = 20;
  		}
! 		klseek(kmem, off, 0L);
! 		read(kmem, (char *)&nfsstats, sizeof nfsstats);
  		printf("Client: %8d %8d %8d %8d %8d %8d %8d %8d\n",
  		    nfsstats.rpccnt[1]-lastst.rpccnt[1],
  		    nfsstats.rpccnt[4]-lastst.rpccnt[4],
--- 304,311 ----
  			printhdr();
  			hdrcnt = 20;
  		}
! 		kvm_read(kmem, off, (char *)&nfsstats,
! 			sizeof(struct nfsstats));
  		printf("Client: %8d %8d %8d %8d %8d %8d %8d %8d\n",
  		    nfsstats.rpccnt[1]-lastst.rpccnt[1],
  		    nfsstats.rpccnt[4]-lastst.rpccnt[4],
***************
*** 354,377 ****
  catchalarm()
  {
  	signalled = 1;
- }
- 
- /*
-  * Seek into the kernel for a value.
-  */
- off_t
- klseek(fd, base, off)
- 	int fd, off;
- 	off_t base;
- {
- #ifndef NEWVM
- 	if (kflag) {
- 		/* get kernel pte */
- 		base &= ~KERNBASE;
- 		base = ctob(Sysmap[btop(base)].pg_pfnum) + (base & PGOFSET);
- 	}
- #endif
- 	return (lseek(fd, base, off));
  }

  void
--- 353,358 ----
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: cgd 
State-Changed-When: Fri May 27 04:18:41 PDT 1994 
State-Changed-Why:  
patch works and was applied.  This will probably be obsoleted by 4.4-Lite 
nfsstat. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.