NetBSD Problem Report #26522

Received: (qmail 1475 invoked by uid 605); 2 Aug 2004 21:59:07 -0000
Message-Id: <20040802225848.462E79236@panser>
Date: Mon,  2 Aug 2004 22:58:48 +0000 (UTC)
From: pancake@phreaker.net
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: pancake@phreaker.net
To: gnats-bugs@gnats.NetBSD.org
Subject: ProFTPd doesn't handle PAM support
X-Send-Pr-Version: 3.95

>Number:         26522
>Category:       pkg
>Synopsis:       PAM support for ProFTPd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    martti
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Aug 02 22:00:00 +0000 2004
>Closed-Date:    Mon Aug 30 18:14:10 +0000 2004
>Last-Modified:  Mon Aug 30 18:14:10 +0000 2004
>Originator:     
>Release:        NetBSD 2.0G
>Organization:

>Environment:


System: NetBSD pl2 2.0G NetBSD 2.0G (pancake-laptop) #10: Wed Jul 21 20:57:24 CEST 2004 pancake@panser:/usr/src/sys/arch/i386/compile/PANCAKE_LAPTOP i386
Architecture: i386
Machine: i386
>Description:
	adds PAM support to proftpd

>How-To-Repeat:
	patch -p0 <...

>Fix:
	apply this to net/proftpd

--- Makefile.orig	2004-08-02 11:11:17.000000000 -0400
+++ Makefile	2004-08-02 11:55:05.000000000 -0400
@@ -1,6 +1,5 @@
 # $NetBSD: Makefile,v 1.12 2004/01/24 14:50:06 grant Exp $

-PKGNAME=	proftpd-1.2.9
 DISTNAME=	proftpd-1.2.9
 CATEGORIES=	net
 MASTER_SITES=	ftp://ftp.proftpd.org/distrib/source/
@@ -12,6 +11,7 @@

 WRKSRC=		${WRKDIR}/${PKGNAME_NOREV}

+USE_BUILDLINK3= YES
 GNU_CONFIGURE=	# defined
 USE_GNU_TOOLS+=	make
 USE_PKGINSTALL=	YES
@@ -20,10 +20,17 @@
 CONFIGURE_ARGS+=--localstatedir=/var/run
 CONFIGURE_ARGS+=--disable-sendfile

+.include "../../mk/bsd.prefs.mk"
+BUILD_DEFS+=	PROFTPD_USE_PAM
+PROFTPD_USE_PAM?=NO
+
 RCD_SCRIPTS=	proftpd

 CONF_FILES=	${PREFIX}/share/examples/proftpd/basic.conf \
 		${PKG_SYSCONFDIR}/proftpd.conf
+.if defined(PROFTPD_USE_PAM) && ${PROFTPD_USE_PAM} == "YES"
+CONFIGURE_ARGS+=--enable-auth-pam
+.endif

 ## .if defined(PROFTPD_USE_LDAP) && ${PROFTPD_USE_LDAP} == "YES"
 ## MODULES:=	${MODULES}:mod_ldap
@@ -70,4 +77,8 @@
 	${INSTALL_DATA} ${WRKSRC}/sample-configurations/*.conf \
 		${PREFIX}/share/examples/proftpd

+.if ${PROFTPD_USE_PAM} == YES
+.include "../../security/PAM/buildlink3.mk"
+.endif
+
 .include "../../mk/bsd.pkg.mk"

>Release-Note:
>Audit-Trail:

From: "Jeremy C. Reed" <reed@reedmedia.net>
To: pancake@phreaker.net
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/26522: ProFTPd doesn't handle PAM support
Date: Mon, 2 Aug 2004 15:30:14 -0700 (PDT)

 On Mon, 2 Aug 2004 pancake@phreaker.net wrote:

 > +.include "../../mk/bsd.prefs.mk"
 > +BUILD_DEFS+=	PROFTPD_USE_PAM
 > +PROFTPD_USE_PAM?=NO

 We already have a USE_PAM setting. Being specific for ProFTPd is probably
 not needed.

 Also, this could be a good candidate for the new mk/bsd.options.mk
 infrastructure.


  Jeremy C. Reed

  	  	 	 BSD News, BSD tutorials, BSD links
 	  	 	 http://www.bsdnewsletter.com/


From: pancake <pancake@phreaker.net>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pkg/26522
Date: Tue, 3 Aug 2004 20:04:26 +0000

 Just another way to do the same, but using bsd.options.mk.

 --- Makefile.orig	2004-08-02 11:11:17.000000000 -0400
 +++ Makefile	2004-08-03 05:05:07.000000000 -0400
 @@ -25,6 +25,29 @@
  CONF_FILES=	${PREFIX}/share/examples/proftpd/basic.conf \
  		${PKG_SYSCONFDIR}/proftpd.conf

 +PKG_SUPPORTED_OPTIONS = pam wrap quota
 +PKG_OPTIONS_VAR       = PROFTPD_OPTIONS
 +
 +# This (or something like this must be in mk/bsd.options.mk) to allow 
 +# to see the supported options
 +##BUILD_DEFS+=PKG_SUPPORTED_OPTIONS
 +
 +.include "../../mk/bsd.options.mk"
 +
 +.if !empty(PKG_OPTIONS:Mpam)
 +CONFIGURE_ARGS+=--enable-auth-pam
 +.include "../../security/PAM/buildlink3.mk"
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mwrap)
 +MODULES:=${MODULES}mod_wrap
 +.endif
 +
 +MODULES=#defined
 +.if !empty(PKG_OPTIONS:Mquota)
 +MODULES:=${MODULES}mod_quota
 +.endif
 +
  ## .if defined(PROFTPD_USE_LDAP) && ${PROFTPD_USE_LDAP} == "YES"
  ## MODULES:=	${MODULES}:mod_ldap
  ## DEPENDS+=	openldap-[0-9]*:../../databases/openldap
 @@ -40,21 +63,13 @@
  ## DEPENDS+=	postgresql-client-[0-9]*:../../databases/postgresql-client
  ## .endif
  ##
 -## .if defined(PROFTPD_USE_QUOTA) && ${PROFTPD_USE_QUOTA} == "YES"
 -## MODULES:=	${MODULES}:mod_quota
 -## .endif
 -##
  ## .if defined(PROFTPD_USE_README) && ${PROFTPD_USE_README} == "YES"
  ## MODULES:=	${MODULES}:mod_readme
  ## .endif
 -##
 -## .if defined(PROFTPD_USE_WRAP) && ${PROFTPD_USE_WRAP} == "YES"
 -## MODULES:=	${MODULES}:mod_wrap
 -## .endif
 -##
 -## .if !empty(MODULES)
 -## CONFIGURE_ARGS+=--with-modules=${MODULES}
 -## .endif
 +
 +.if !empty(MODULES)
 +CONFIGURE_ARGS+=--with-modules=${MODULES}
 +.endif

  post-install:
  	# documentation
Responsible-Changed-From-To: pkg-manager->martti 
Responsible-Changed-By: cube 
Responsible-Changed-When: Wed Aug 4 14:18:07 UTC 2004 
Responsible-Changed-Why:  
Martti accepted to handle it. 
State-Changed-From-To: open->closed 
State-Changed-By: martti 
State-Changed-When: Mon Aug 30 18:13:20 UTC 2004 
State-Changed-Why:  
Committed, thanks! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.