NetBSD Problem Report #26590

Received: (qmail 17555 invoked by uid 605); 8 Aug 2004 02:23:56 -0000
Message-Id: <200408080223.i782Ngtx014147@edge.back-street.net>
Date: Sun, 8 Aug 2004 11:23:42 +0900 (JST)
From: Takahiro Kambe <taca@back-street.net>
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: taca@back-street.net
To: gnats-bugs@gnats.NetBSD.org
Subject: mail/dovecot/options.mk assumes USE_INET6 isn't always defined
X-Send-Pr-Version: 3.95

>Number:         26590
>Category:       pkg
>Synopsis:       mail/dovecot/options.mk assumes USE_INET6 isn't always defined
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 08 02:24:04 +0000 2004
>Closed-Date:    Mon Aug 23 13:04:12 +0000 2004
>Last-Modified:  Mon Aug 23 13:04:12 +0000 2004
>Originator:     Takahiro Kambe
>Release:        NetBSD 2.0G
>Organization:
Takahiro Kambe
>Environment:


System: NetBSD edge.back-street.net 2.0G NetBSD 2.0G (CF-R1) #151: Fri Aug 6 13:38:13 JST 2004 taca@edge.back-street.net:/var/obj/sys/arch/i386/compile/CF-R1 i386
Architecture: i386
Machine: i386
>Description:
	mail/dovecot/options.mk assumes USE_INET6 isn't always defined,
	but it is wrong.  With bsd.prefs.mk revsion 1.164, USE_INET6 is
	defined always defined as boolean value like "YES" or "NO".

	And mail/dovcot/options.mk has these lines:

# Global and legacy options
.if defined(DOVECOT_USE_GNUTLS) || defined(DOVECOT_USE_MYSQL) || \
    defined(DOVECOT_USE_PGSQL) || defined(USE_INET6) || \
    defined(USE_OPENLDAP) || defined(USE_SASL2)
...

	Since USE_INET6 is always defined as I noted, this first ".if" is
	always defined and it results dovecot pkgsrc always ignore
	PKG_DEFAULT_OPTIONS.
>How-To-Repeat:
	Set PKG_DEFAULT_OPTIONS to /etc/mk.conf and check that it is
	effected to dovecot pkgsrc.
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: jlam 
State-Changed-When: Sun Aug 22 19:33:18 UTC 2004 
State-Changed-Why:  
The semantics have been changed so that the default options is the union 
of PKG_DEFAULT_OPTIONS and any old FOO_USE_* and USE_* options still set 
within pkgsrc.  Please let me know if this fixes the problem.  Thanks! 

From: "Johnny C. Lam" <jlam@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/26590 CVS commit: pkgsrc
Date: Sun, 22 Aug 2004 19:32:52 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	jlam
 Date:		Sun Aug 22 19:32:52 UTC 2004

 Modified Files:
 	pkgsrc/databases/openldap: options.mk
 	pkgsrc/devel/rt3: Makefile.options
 	pkgsrc/emulators/vice: Makefile
 	pkgsrc/graphics/freetype2: Makefile
 	pkgsrc/mail/clamav: Makefile
 	pkgsrc/mail/cyrus-imapd21: Makefile
 	pkgsrc/mail/cyrus-imapd22: Makefile
 	pkgsrc/mail/dovecot: options.mk
 	pkgsrc/mail/dspam: options.mk
 	pkgsrc/mail/ezmlm-idx: options.mk
 	pkgsrc/mail/fetchmail: options.mk
 	pkgsrc/mail/mutt: options.mk
 	pkgsrc/mail/mutt-devel: options.mk
 	pkgsrc/mail/postfix: options.mk
 	pkgsrc/mail/postfix-current: options.mk
 	pkgsrc/mail/qmail: options.mk
 	pkgsrc/mk: bsd.options.mk
 	pkgsrc/net/flow-tools: Makefile
 	pkgsrc/net/samba: options.mk
 	pkgsrc/print/cups: Makefile
 	pkgsrc/security/PAM: Makefile
 	pkgsrc/security/amavisd-new: Makefile
 	pkgsrc/security/cy2-sql: Makefile
 	pkgsrc/security/cyrus-sasl: Makefile
 	pkgsrc/security/cyrus-saslauthd: options.mk
 	pkgsrc/security/heimdal: Makefile
 	pkgsrc/security/mit-krb5: Makefile
 	pkgsrc/security/openssl: Makefile
 	pkgsrc/security/sudo: Makefile
 	pkgsrc/shells/bash2: Makefile
 	pkgsrc/www/apache: Makefile
 	pkgsrc/www/lynx: options.mk
 	pkgsrc/www/php4: Makefile.php

 Log Message:
 Change the way that legacy USE_* and FOO_USE_* options are converted
 into the bsd.options.mk framework.  Instead of appending to
 ${PKG_OPTIONS_VAR}, it appends to PKG_DEFAULT_OPTIONS.  This causes
 the default options to be the union of PKG_DEFAULT_OPTIONS and any
 old USE_* and FOO_USE_* settings.

 This fixes PR pkg/26590.


 To generate a diff of this commit:
 cvs rdiff -r1.1 -r1.2 pkgsrc/databases/openldap/options.mk
 cvs rdiff -r1.1.1.1 -r1.2 pkgsrc/devel/rt3/Makefile.options
 cvs rdiff -r1.48 -r1.49 pkgsrc/emulators/vice/Makefile
 cvs rdiff -r1.36 -r1.37 pkgsrc/graphics/freetype2/Makefile
 cvs rdiff -r1.23 -r1.24 pkgsrc/mail/clamav/Makefile
 cvs rdiff -r1.22 -r1.23 pkgsrc/mail/cyrus-imapd21/Makefile
 cvs rdiff -r1.19 -r1.20 pkgsrc/mail/cyrus-imapd22/Makefile
 cvs rdiff -r1.3 -r1.4 pkgsrc/mail/dovecot/options.mk
 cvs rdiff -r1.2 -r1.3 pkgsrc/mail/dspam/options.mk
 cvs rdiff -r1.1 -r1.2 pkgsrc/mail/ezmlm-idx/options.mk
 cvs rdiff -r1.2 -r1.3 pkgsrc/mail/fetchmail/options.mk
 cvs rdiff -r1.1 -r1.2 pkgsrc/mail/mutt/options.mk
 cvs rdiff -r1.2 -r1.3 pkgsrc/mail/mutt-devel/options.mk
 cvs rdiff -r1.6 -r1.7 pkgsrc/mail/postfix/options.mk
 cvs rdiff -r1.3 -r1.4 pkgsrc/mail/postfix-current/options.mk
 cvs rdiff -r1.1 -r1.2 pkgsrc/mail/qmail/options.mk
 cvs rdiff -r1.6 -r1.7 pkgsrc/mk/bsd.options.mk
 cvs rdiff -r1.8 -r1.9 pkgsrc/net/flow-tools/Makefile
 cvs rdiff -r1.1 -r1.2 pkgsrc/net/samba/options.mk
 cvs rdiff -r1.78 -r1.79 pkgsrc/print/cups/Makefile
 cvs rdiff -r1.26 -r1.27 pkgsrc/security/PAM/Makefile
 cvs rdiff -r1.1.1.1 -r1.2 pkgsrc/security/amavisd-new/Makefile
 cvs rdiff -r1.2 -r1.3 pkgsrc/security/cy2-sql/Makefile
 cvs rdiff -r1.44 -r1.45 pkgsrc/security/cyrus-sasl/Makefile
 cvs rdiff -r1.1 -r1.2 pkgsrc/security/cyrus-saslauthd/options.mk
 cvs rdiff -r1.19 -r1.20 pkgsrc/security/heimdal/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/security/mit-krb5/Makefile
 cvs rdiff -r1.94 -r1.95 pkgsrc/security/openssl/Makefile
 cvs rdiff -r1.64 -r1.65 pkgsrc/security/sudo/Makefile
 cvs rdiff -r1.55 -r1.56 pkgsrc/shells/bash2/Makefile
 cvs rdiff -r1.149 -r1.150 pkgsrc/www/apache/Makefile
 cvs rdiff -r1.1 -r1.2 pkgsrc/www/lynx/options.mk
 cvs rdiff -r1.16 -r1.17 pkgsrc/www/php4/Makefile.php

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Takahiro Kambe <taca@back-street.net>
To: gnats-bugs@gnats.netbsd.org, jlam@netbsd.org
Cc: pkg-manager@netbsd.org
Subject: Re: pkg/26590
Date: Mon, 23 Aug 2004 22:02:22 +0900 (JST)

 In message <20040822193456.25651.qmail@mail.netbsd.org>
 	on 22 Aug 2004 19:34:56 -0000,
 	jlam@netbsd.org wrote:
 > The semantics have been changed so that the default options is the union
 > of PKG_DEFAULT_OPTIONS and any old FOO_USE_* and USE_* options still set
 > within pkgsrc.  Please let me know if this fixes the problem.  Thanks!
 I've checked that the problem fixed fine.  Thanks much.

 -- 
 Takahiro Kambe <taca@back-street.net>
State-Changed-From-To: feedback->closed 
State-Changed-By: wiz 
State-Changed-When: Mon Aug 23 13:03:54 UTC 2004 
State-Changed-Why:  
Submitter reports problem is fixed. 
Thanks for the bug report! 
>Unformatted:

Home	PR Database Search