NetBSD Problem Report #26776
Received: (qmail 22132 invoked by uid 605); 27 Aug 2004 08:58:22 -0000
Message-Id: <20040827085820.32F4311152@narn.netbsd.org>
Date: Fri, 27 Aug 2004 08:58:20 +0000 (UTC)
From: palle@lyckegaard.dk
Sender: gnats-bugs-owner@NetBSD.org
Reply-To: palle@lyckegaard.dk
To: gnats-bugs@gnats.NetBSD.org
Subject: raidframe will not build with with 'options RAID_DIAGNOSTIC'
X-Send-Pr-Version: www-1.0
>Number: 26776
>Category: kern
>Synopsis: raidframe will not build with with 'options RAID_DIAGNOSTIC'
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Aug 27 08:59:00 +0000 2004
>Closed-Date: Fri Aug 27 15:59:08 +0000 2004
>Last-Modified: Mon Aug 30 08:45:25 +0000 2004
>Originator: Palle Lyckegaard
>Release: netbsd-2-0 BETA
>Organization:
>Environment:
odin# uname -a
NetBSD odin.lyckegaard.dk 2.0_BETA NetBSD 2.0_BETA (ODIN) #0: Thu Aug 19 14:28:09 CEST 2004 palle@odin.lyckegaard.dk:/mnt/cvs/netbsd-2-0/src/sys/arch/i386/compile/obj/ODIN i386
>Description:
The kernel will not compile with 'options RAID_DIAGNISTIC'.
The following three files need minor ajustments (all related to RF_ASSERT()):
sys/dev/raidframe/rf_dagdegrd.c
sys/dev/raidframe/rf_dagffwr.c
sys/dev/raidframe/rf_raid0.c
>How-To-Repeat:
Add the following line to the GENERIC configuration:
options RAID_DIAGNOSTIC
>Fix:
The following are diffs making the kernel build with RAID_DIAGNISTIC again:
odin# cvs diff sys/dev/raidframe/rf_dagdegrd.c
Index: sys/dev/raidframe/rf_dagdegrd.c
===================================================================
RCS file: /cvsroot/src/sys/dev/raidframe/rf_dagdegrd.c,v
retrieving revision 1.21
diff -r1.21 rf_dagdegrd.c
528c528
< RF_ASSERT(rrdNode->numSuccedents == 1);
---
> RF_ASSERT(rrdNodes->numSuccedents == 1);
odin# cvs diff sys/dev/raidframe/rf_dagffwr.c
Index: sys/dev/raidframe/rf_dagffwr.c
===================================================================
RCS file: /cvsroot/src/sys/dev/raidframe/rf_dagffwr.c,v
retrieving revision 1.26.2.1
diff -r1.26.2.1 rf_dagffwr.c
412c412
< RF_ASSERT(tmpNode.numAntecedents == 1);
---
> RF_ASSERT(tmpNode->numAntecedents == 1);
418c418
< RF_ASSERT(tmpNode.numSuccedents == 1);
---
> RF_ASSERT(tmpNode->numSuccedents == 1);
1113c1113
< RF_ASSERT(tmpwriteDataNodes->numAntecedents == 1);
---
> RF_ASSERT(tmpwriteDataNode->numAntecedents == 1);
odin# cvs diff sys/dev/raidframe/rf_raid0.c
Index: sys/dev/raidframe/rf_raid0.c
===================================================================
RCS file: /cvsroot/src/sys/dev/raidframe/rf_raid0.c,v
retrieving revision 1.10
diff -r1.10 rf_raid0.c
74c74
< RF_ASSERT(raidPtr->numRow == 1);
---
> RF_ASSERT(raidPtr->numCol == 1);
>Release-Note:
>Audit-Trail:
From: Greg Oster <oster@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/26776 CVS commit: src/sys/dev/raidframe
Date: Fri, 27 Aug 2004 15:55:51 +0000 (UTC)
Module Name: src
Committed By: oster
Date: Fri Aug 27 15:55:51 UTC 2004
Modified Files:
src/sys/dev/raidframe: rf_dagdegrd.c rf_dagffwr.c rf_raid0.c
Log Message:
Correct some RF_ASSERTS() that were missed when fixing memory issues
with this code. Thanks to palle at lyckegaard.dk for pointing them
out. Addresses PR#26776 (but doesn't use all the suggested fixes).
To generate a diff of this commit:
cvs rdiff -r1.21 -r1.22 src/sys/dev/raidframe/rf_dagdegrd.c
cvs rdiff -r1.27 -r1.28 src/sys/dev/raidframe/rf_dagffwr.c
cvs rdiff -r1.10 -r1.11 src/sys/dev/raidframe/rf_raid0.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: oster
State-Changed-When: Fri Aug 27 15:58:18 UTC 2004
State-Changed-Why:
Fixed the problem, but not with all of the changes supplied by PR submitter.
From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/26776 CVS commit: [netbsd-2-0] src/sys/dev/raidframe
Date: Mon, 30 Aug 2004 08:44:25 +0000 (UTC)
Module Name: src
Committed By: tron
Date: Mon Aug 30 08:44:25 UTC 2004
Modified Files:
src/sys/dev/raidframe [netbsd-2-0]: rf_raid0.c
Log Message:
Pull up revision 1.11 (requested by oster in ticket #798):
Correct some RF_ASSERTS() that were missed when fixing memory issues
with this code. Thanks to palle at lyckegaard.dk for pointing them
out. Addresses PR#26776 (but doesn't use all the suggested fixes).
To generate a diff of this commit:
cvs rdiff -r1.10 -r1.10.2.1 src/sys/dev/raidframe/rf_raid0.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/26776 CVS commit: [netbsd-2-0] src/sys/dev/raidframe
Date: Mon, 30 Aug 2004 08:44:32 +0000 (UTC)
Module Name: src
Committed By: tron
Date: Mon Aug 30 08:44:32 UTC 2004
Modified Files:
src/sys/dev/raidframe [netbsd-2-0]: rf_dagdegrd.c
Log Message:
Pull up revision 1.22 (requested by oster in ticket #798):
Correct some RF_ASSERTS() that were missed when fixing memory issues
with this code. Thanks to palle at lyckegaard.dk for pointing them
out. Addresses PR#26776 (but doesn't use all the suggested fixes).
To generate a diff of this commit:
cvs rdiff -r1.21 -r1.21.2.1 src/sys/dev/raidframe/rf_dagdegrd.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/26776 CVS commit: [netbsd-2-0] src/sys/dev/raidframe
Date: Mon, 30 Aug 2004 08:44:40 +0000 (UTC)
Module Name: src
Committed By: tron
Date: Mon Aug 30 08:44:40 UTC 2004
Modified Files:
src/sys/dev/raidframe [netbsd-2-0]: rf_dagffwr.c
Log Message:
Pull up revision 1.28 (requested by oster in ticket #798):
Correct some RF_ASSERTS() that were missed when fixing memory issues
with this code. Thanks to palle at lyckegaard.dk for pointing them
out. Addresses PR#26776 (but doesn't use all the suggested fixes).
To generate a diff of this commit:
cvs rdiff -r1.26.2.1 -r1.26.2.2 src/sys/dev/raidframe/rf_dagffwr.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.