NetBSD Problem Report #27317

From john@johnrshannon.com  Thu Oct 21 22:43:43 2004
Return-Path: <john@johnrshannon.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.netbsd.org (Postfix) with SMTP id 96997251EB8
	for <gnats@www.netbsd.org>; Thu, 21 Oct 2004 22:43:43 +0000 (UTC)
Message-Id: <20041021224339.502BB10623@colleen.internal.johnrshannon.com>
Date: Thu, 21 Oct 2004 16:43:39 -0600 (MDT)
From: shannonjr@netbsd.org
Reply-To: shannonjr@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: gcrypt.h references struct timeval without including sys/time.h
X-Send-Pr-Version: 3.95

>Number:         27317
>Category:       pkg
>Synopsis:       pkgsrc/security/libgcrypt installs header gcrypt.h with missing include
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 22 08:47:02 +0000 2004
>Closed-Date:    Sat Oct 23 09:02:47 +0000 2004
>Last-Modified:  Wed Oct 27 05:48:00 +0000 2004
>Originator:     shannonjr@netbsd.org
>Release:        NetBSD 2.0_RC4
>Organization:
NetBSD
>Environment:
System: NetBSD colleen.internal.johnrshannon.com 2.0_RC4 NetBSD 2.0_RC4 (KERNEL) #1: Fri Oct 8 05:30:25 MDT 2004 root@colleen.internal.johnrshannon.com:/usr/obj/usr/src/sys/arch/i386/compile/KERNEL i386
Architecture: i386
Machine: i386
>Description:
	pkgsrc/security/libgcrypt installs header gcrypt.h. This header references struct timeval without including sys/time.h.
	Code compiled against this header encounter an undeclared type.
>How-To-Repeat:
	Obvious by code inspection.
>Fix:
	Add this as patch-ac:


$NetBSD$

--- src/gcrypt.h.orig	2004-04-15 03:10:37.000000000 -0600
+++ src/gcrypt.h
@@ -29,6 +29,7 @@

 #include <sys/types.h>
 #include <sys/socket.h>
+#include <sys/time.h>

 /* This is required for error code compatibility. */
 #define _GCRY_ERR_SOURCE_DEFAULT GPG_ERR_SOURCE_GCRYPT
>Release-Note:
>Audit-Trail:

From: Thomas Klausner <wiz@NetBSD.org>
To: "John R. Shannon" <shannonjr@netbsd.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/27317
Date: Sat, 23 Oct 2004 01:24:36 +0200

 On Fri, Oct 22, 2004 at 12:04:02PM -0600, John R. Shannon wrote:
 > May I apply the patch submitted with the PR and close it out?
 > 
 > I've rebuilt 27 dependent packages here after applying the patch without 
 > encountering problems.

 Yes, please. Please also bump PKGREVISION and update
 BUILDLINK_DEPENDS if necessary.

 Thanks,
  Thomas
State-Changed-From-To: open->closed 
State-Changed-By: shannonjr 
State-Changed-When: Sat Oct 23 09:00:34 UTC 2004 
State-Changed-Why:  
Applied patch submitted with PR and bumped PKGREVISION. 

From: "Jeremy C. Reed" <reed@reedmedia.net>
To: john@johnrshannon.com
Cc: gnats-bugs@gnats.NetBSD.org
Subject: re: pkg/27317
Date: Tue, 26 Oct 2004 22:46:36 -0700 (PDT)

 I noticed that you bumped BUILDLINK_RECOMMENDED.libgcrypt.

 Your bug description said "Code compiled against this header encounter an
 undeclared type."

 Were these failures that stopped the builds?

 I had been using libgcrypt-1.2.0nb2 fine (for opencdk-0.5.5nb1,
 libxslt-1.1.10nb1 and gnutls-1.0.20nb2).

 Maybe the BUILDLINK_RECOMMENDED.libgcrypt should only have been bumped for
 packages that actually failed.

  Jeremy C. Reed

  	  	 	 technical support & remote administration
 	  	 	 http://www.pugetsoundtechnology.com/

>Unformatted:
 >Quarter:        
 >Keywords:       
 >Date-Required:  

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.