NetBSD Problem Report #27340
From www@www.netbsd.org Fri Oct 22 12:06:23 2004
Return-Path: <www@www.netbsd.org>
Received: by narn.netbsd.org (Postfix, from userid 31301)
id E58952521EE; Fri, 22 Oct 2004 12:06:22 +0000 (UTC)
Message-Id: <20041022120622.E58952521EE@narn.netbsd.org>
Date: Fri, 22 Oct 2004 12:06:22 +0000 (UTC)
From: lems@gmx.net
Reply-To: lems@gmx.net
To: gnats-bugs@gnats.NetBSD.org
Subject: audio/aumix: Add knob USE_GTK2
X-Send-Pr-Version: www-1.0
>Number: 27340
>Category: pkg
>Synopsis: audio/aumix: Add knob USE_GTK2
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Fri Oct 22 12:07:00 +0000 2004
>Closed-Date: Fri Oct 22 18:32:20 +0000 2004
>Last-Modified: Fri Oct 22 18:33:00 +0000 2004
>Originator: Leonard Schmidt
>Release: NetBSD 2.0_RC4
>Organization:
>Environment:
NetBSD kafka 2.0_RC4 NetBSD 2.0_RC4 (THEWIRED) #1: Wed Oct 20 12:41:14 GMT 2004 lems@kafka:/usr/src/sys/arch/i386/compile/THEWIRED i386
>Description:
Let the user decide if he/she wants to build aumix with GTK2 support.
I don't know if this is the cleanest way to do it, but I think some packages (especially mplayer) really should ask the user if he/she wants specific features to be enabled or disabled.
>How-To-Repeat:
Build audio/aumix and notice how much bloat gets added by default if you don't hack up the Makefile to disable GTK2 support.
>Fix:
diff -ruN /usr/pkgsrc/audio/aumix/Makefile aumix/Makefile
--- /usr/pkgsrc/audio/aumix/Makefile 2004-10-22 13:43:57.000000000 +0000
+++ aumix/Makefile 2004-10-22 13:38:52.000000000 +0000
@@ -23,7 +23,15 @@
CONFIGURE_ARGS+= --enable-nls
CONFIGURE_ARGS+= --without-gtk1
+.include "../../mk/bsd.prefs.mk"
+
+BUILD_DEFS+= USE_GTK2
+.if defined(USE_GTK2) && !empty(USE_GTK2:M[Yy][Ee][Ss])
+.include "../../x11/gtk2/buildlink3.mk"
+.else
+CONFIGURE_ARGS+= --without-gtk
+.endif
+
.include "../../devel/gettext-lib/buildlink3.mk"
.include "../../devel/ncurses/buildlink3.mk"
-.include "../../x11/gtk2/buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
>Release-Note:
>Audit-Trail:
From: "Julio M. Merino Vidal" <jmmv@menta.net>
To: lems@gmx.net
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/27340: audio/aumix: Add knob USE_GTK2
Date: Fri, 22 Oct 2004 14:50:42 +0200
On Fri, 22 Oct 2004 12:06:22 +0000 (UTC)
lems@gmx.net wrote:
> >Description:
> Let the user decide if he/she wants to build aumix with GTK2 support.
>
> I don't know if this is the cleanest way to do it,
No, this is not the way to go, specially in this case. A new package should
be created, say aumix-gtk, and aumix should be modified to install a version
w/o gtk support.
(There are multiple examples of this in pkgsrc. You may use them as reference.)
--
Julio M. Merino Vidal <jmmv@menta.net>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/
From: Leonard Schmidt <lems@gmx.net>
To: "Julio M. Merino Vidal" <jmmv@menta.net>
Cc: gnats-bugs@gnats.NetBSD.org
Subject: Re: pkg/27340: audio/aumix: Add knob USE_GTK2
Date: Fri, 22 Oct 2004 17:11:08 +0000
--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
* Julio M. Merino Vidal <jmmv@menta.net> [2004-10-22 15:16]:
> No, this is not the way to go, specially in this case.
Yeah, I already thought so. :/ Thanks for the clarification,
though. Since it's not that urgent (I use vim-gtk2, gqview and=20
firefox-gtk2 myself, so the GTK2 dependency isn't that big of
a problem) I better let aumix untouched (I'd rather like to=20
see rexima in pkgsrc but I can't get the damn thing to compile.. :/).
Thanks and regards
Leonard Emil Manfred Schmidt a.k.a lems
--opJtzjQTFsWo+cga
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
iD8DBQFBeT8seffumNo0U88RAmzJAKCKjAWDRz3Bgf84JyrCBvZWj/+VkQCeIKEN
3ABbybLNa/aZJyVNnCIG6Ao=
=pZJz
-----END PGP SIGNATURE-----
--opJtzjQTFsWo+cga--
State-Changed-From-To: open->closed
State-Changed-By: jmmv
State-Changed-When: Fri Oct 22 18:30:56 UTC 2004
State-Changed-Why:
I've split aumix into aumix (ncurses only) and aumix-gtk (ncurses + GTK 2.x).
Thanks.
From: "Julio M. Merino Vidal" <jmmv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: pr/27340 CVS commit: pkgsrc
Date: Fri, 22 Oct 2004 18:30:43 +0000 (UTC)
Module Name: pkgsrc
Committed By: jmmv
Date: Fri Oct 22 18:30:43 UTC 2004
Modified Files:
pkgsrc/audio: Makefile
pkgsrc/audio/aumix: DESCR Makefile
pkgsrc/doc: CHANGES
Added Files:
pkgsrc/audio/aumix: Makefile.common
pkgsrc/audio/aumix-gtk: DESCR Makefile
Log Message:
Split aumix into two different packages:
- aumix 2.8nb6, which only provides ncurses support. Note that its revision
is bumped to note the differences from the previous package.
- aumix-gtk 2.8, which includes GTK 2.x and ncurses support. While here,
add a missing build dependency on pkgconfig.
The descriptions have also been rewritten to note the differences.
Addresses PR pkg/27340.
To generate a diff of this commit:
cvs rdiff -r1.254 -r1.255 pkgsrc/audio/Makefile
cvs rdiff -r1.1 -r1.2 pkgsrc/audio/aumix/DESCR
cvs rdiff -r1.22 -r1.23 pkgsrc/audio/aumix/Makefile
cvs rdiff -r0 -r1.1 pkgsrc/audio/aumix/Makefile.common
cvs rdiff -r0 -r1.1 pkgsrc/audio/aumix-gtk/DESCR \
pkgsrc/audio/aumix-gtk/Makefile
cvs rdiff -r1.7525 -r1.7526 pkgsrc/doc/CHANGES
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
>Quarter:
>Keywords:
>Date-Required:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.